All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] net: dm: fec: Fix time unit error in phy-reset-duration
Date: Fri, 5 Oct 2018 07:42:58 +0200	[thread overview]
Message-ID: <CAOf5uwndjW3GjJB+z+FXoeqz7wVgcOoEV+_VbTmZHo6uqYf82A@mail.gmail.com> (raw)
In-Reply-To: <1538675965-4495-2-git-send-email-martin.fuzzey@flowbird.group>

Hi

On Thu, Oct 4, 2018 at 7:59 PM Martin Fuzzey
<martin.fuzzey@flowbird.group> wrote:
>
> The DT binding says that phy-reset-duration is in ms, but the driver
> currently uses udelay().
>
> Switch to mdelay() to fix this.
>
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
> ---
>  drivers/net/fec_mxc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> index dac07b6..a1295fc 100644
> --- a/drivers/net/fec_mxc.c
> +++ b/drivers/net/fec_mxc.c
> @@ -1254,7 +1254,7 @@ static void fec_gpio_reset(struct fec_priv *priv)
>         debug("fec_gpio_reset: fec_gpio_reset(dev)\n");
>         if (dm_gpio_is_valid(&priv->phy_reset_gpio)) {
>                 dm_gpio_set_value(&priv->phy_reset_gpio, 1);
> -               udelay(priv->reset_delay);
> +               mdelay(priv->reset_delay);
>                 dm_gpio_set_value(&priv->phy_reset_gpio, 0);
>         }

Reviewed-by: Michael Trimarchi <michael@amarulasolutions.com>
>  }
> --
> 1.9.1
>


-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

  reply	other threads:[~2018-10-05  5:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 17:59 [U-Boot] [PATCH 0/4] net: dm: fec: Fixes and improvements Martin Fuzzey
2018-10-04 17:59 ` [U-Boot] [PATCH 1/4] net: dm: fec: Fix time unit error in phy-reset-duration Martin Fuzzey
2018-10-05  5:42   ` Michael Nazzareno Trimarchi [this message]
2018-10-22 20:53   ` Joe Hershberger
2018-10-24 19:56   ` [U-Boot] " Joe Hershberger
2018-10-04 17:59 ` [U-Boot] [PATCH 2/4] net: dm: fec: Fix phy-reset-duration clamping and defaults Martin Fuzzey
2018-10-22 20:54   ` Joe Hershberger
2018-10-24 19:56   ` [U-Boot] " Joe Hershberger
2018-10-04 17:59 ` [U-Boot] [PATCH 3/4] net: dm: fec: Support the phy-supply binding Martin Fuzzey
2018-10-22 20:51   ` Joe Hershberger
2018-10-24 19:56   ` [U-Boot] " Joe Hershberger
2018-10-04 17:59 ` [U-Boot] [PATCH 4/4] net: dm: fec: Obtain the transceiver type from the DT Martin Fuzzey
2018-10-22 20:56   ` Joe Hershberger
2018-10-24 19:57   ` [U-Boot] " Joe Hershberger
  -- strict thread matches above, loose matches on Subject: below --
2018-10-04 17:53 [U-Boot] [PATCH 0/4] net: dm: fec: Fixes and improvements Martin Fuzzey
2018-10-04 17:53 ` [U-Boot] [PATCH 1/4] net: dm: fec: Fix time unit error in phy-reset-duration Martin Fuzzey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOf5uwndjW3GjJB+z+FXoeqz7wVgcOoEV+_VbTmZHo6uqYf82A@mail.gmail.com \
    --to=michael@amarulasolutions.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.