From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f50.google.com ([209.85.215.50]:33423 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752198AbcAVTVq (ORCPT ); Fri, 22 Jan 2016 14:21:46 -0500 Received: by mail-lf0-f50.google.com with SMTP id m198so53261616lfm.0 for ; Fri, 22 Jan 2016 11:21:45 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20160122071147.GY17997@ZenIV.linux.org.uk> <20160122170838.GZ17997@ZenIV.linux.org.uk> <20160122174338.GA17997@ZenIV.linux.org.uk> <20160122183720.GB17997@ZenIV.linux.org.uk> Date: Fri, 22 Jan 2016 14:21:44 -0500 Message-ID: Subject: Re: Orangefs ABI documentation From: Mike Marshall To: Al Viro Cc: Linus Torvalds , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Al... I think that my commit f987f4c28 "don't trigger copy_attributes_to_inode from d_revalidate." doesn't really do the job... I think I at least need to write code that checks some of the attributes and fails the revalidate if they got changed via some external process... does that sound right? -Mike On Fri, Jan 22, 2016 at 2:07 PM, Mike Marshall wrote: > Martin's the only other one subscribed to fs-devel, the > rest are looking in here today: > > http://marc.info/?l=linux-fsdevel&w=2&r=1&s=orangefs&q=b > > Walt thinks you deserve an Orangefs Contributor's Jacket... > > -Mike > > On Fri, Jan 22, 2016 at 1:37 PM, Al Viro wrote: >> On Fri, Jan 22, 2016 at 01:17:40PM -0500, Mike Marshall wrote: >>> >> Objections, comments? >>> >>> I have no objections so far to your suggestions, I'm trying to keep >>> my co-workers looking in on this discussion... most other days >>> we're all lined up in adjacent cubes... >> >> email and IRC exist for purpose... BTW, another thing: if you've managed >> to get to orangefs_exit() with anything still in request list or hash, >> you are seriously fscked. Whatever had allocated them is presumably still >> around and it's running in that module's .text...