From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2364B8F7B for ; Wed, 12 Oct 2022 12:11:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665576666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hregpx8t1kAHRsj5KIbt4EVewflLpm3kB0Chk3MbBVo=; b=JI5uOKBACpH6RG+ah8iDP24zeut3SN7JR7HS4wUuSiN1AYNC/1Z0fsJ8j31m/k0Vy/esxb XsVTqObd61z5b8pHMbUSdCRAiq/zGJbyAcBhCeijGqh9lNf5RdiDV64PuvLavHM0nPAQN8 XPRb3EA9tVF634nLB43JO3c4OanqS6M= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-222-ViHo598UN8SLEo5-9UKfIw-1; Wed, 12 Oct 2022 08:11:05 -0400 X-MC-Unique: ViHo598UN8SLEo5-9UKfIw-1 Received: by mail-ua1-f70.google.com with SMTP id q9-20020ab04a09000000b003dfecbdc5cdso4668359uae.15 for ; Wed, 12 Oct 2022 05:11:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hregpx8t1kAHRsj5KIbt4EVewflLpm3kB0Chk3MbBVo=; b=T819Cvuiqg8M9UyfLQ4KV2iFTgc6N9n7u5UJ1X8wMREeuY1Y12kmHnpBV55oTqMCum VjqS1vUgWiqfIEk6JKkr7rMnOz/8zccbxrOyCRa5c0S1qeYcBRo2enhH8BgzAa/TVfYQ mKxCqaJ+q3OxNlo0rM3yKpCRyUVA1ZUE84SEMk5UKEYOgmYMlBzhjt6ZPg42kA897SDN W4fgFU5ywGWJB0/KlEDwq2hXwX/3U21kZK2tCMIjvKRCh+D7n2y3YnE0qW618xYJFFwq yWNYSpZpeOI89lbaSPSQk0cUOC/H5qOcgafjSIme+da7rRAX6bVAIv4iTK7ppegEG/o9 hEbg== X-Gm-Message-State: ACrzQf1U/i53CevMrFbnFwMPnWQDw4bAL0UqTiOp05GMEj2JzC8aSEiF Ru05GBG2T9sRHgR6pJkgXXiYu2PRviDjykhTKSiTZ8Xry0q47JEU1p7JSAX84Te3zRPRzhEHLOb 3q+VWk2TZgouExBQwP6hamyQv90lXQlc= X-Received: by 2002:ab0:7c8f:0:b0:381:c81f:6152 with SMTP id v15-20020ab07c8f000000b00381c81f6152mr14996259uaw.58.1665576663429; Wed, 12 Oct 2022 05:11:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6BcAPMB0fOUebVBZrx75XmrZkHjxCDZuCbZ2MEbg+W3PfuUXuBgiCfdkdxsD5PMXfIc/kiYj+v9aXSxNwUOUI= X-Received: by 2002:ab0:7c8f:0:b0:381:c81f:6152 with SMTP id v15-20020ab07c8f000000b00381c81f6152mr14996248uaw.58.1665576663179; Wed, 12 Oct 2022 05:11:03 -0700 (PDT) Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Eric Curtin Date: Wed, 12 Oct 2022 13:10:47 +0100 Message-ID: Subject: Re: [PATCH] nvme-apple: fix DMA-API warning To: "Russell King (Oracle)" Cc: Sven Peter , Hector Martin , Alyssa Rosenzweig , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" On Wed, 12 Oct 2022 at 12:53, Russell King (Oracle) wrote: > > Fix the following DMA-API warning: > > DMA-API: nvme-apple 27bcc0000.nvme: mapping sg segment longer than device claims to support [len=69632] [max=65536] > WARNING: CPU: 3 PID: 1 at kernel/dma/debug.c:1160 debug_dma_map_sg+0x310/0x3a0 > Modules linked in: tps6598x roles typec rtc_macsmc gpio_macsmc nvme_apple apple_mailbox apple_sart pcie_apple macsmc_rtkit macsmc pinctrl_apple_gpio i2c_apple > CPU: 3 PID: 1 Comm: init Not tainted 6.0.0+ #1081 > Hardware name: Apple Mac mini (M1, 2020) (DT) > pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : debug_dma_map_sg+0x310/0x3a0 > lr : debug_dma_map_sg+0x310/0x3a0 > ... > Call trace: > debug_dma_map_sg+0x310/0x3a0 > __dma_map_sg_attrs+0x98/0xf4 > dma_map_sg_attrs+0xc/0x1c > apple_nvme_queue_rq+0x218/0x67c [nvme_apple] > blk_mq_dispatch_rq_list+0x198/0x81c > blk_mq_do_dispatch_sched+0x2b0/0x340 > __blk_mq_sched_dispatch_requests+0x104/0x154 > blk_mq_sched_dispatch_requests+0x38/0x70 > __blk_mq_run_hw_queue+0x80/0x130 > __blk_mq_delay_run_hw_queue+0x84/0x90 > blk_mq_run_hw_queue+0x134/0x170 > blk_mq_sched_insert_requests+0xec/0x300 > blk_mq_flush_plug_list+0x104/0x430 > __blk_flush_plug+0xe8/0x130 > blk_finish_plug+0x30/0x1f0 > read_pages+0x1ec/0x334 > page_cache_ra_unbounded+0x158/0x1bc > page_cache_ra_order+0x80/0x2c0 > filemap_fault+0x4bc/0x970 > __do_fault+0x38/0x144 > __handle_mm_fault+0x7c4/0xc60 > handle_mm_fault+0x120/0x2a0 > do_page_fault+0x130/0x47c > do_translation_fault+0xa0/0xb0 > do_mem_abort+0x40/0x90 > el0_da+0x2c/0x80 > el0t_64_sync_handler+0x60/0xb4 > el0t_64_sync+0x168/0x16c > ---[ end trace 0000000000000000 ]--- > > Suggested-by: Sven Peter > Signed-off-by: Russell King (Oracle) Seems reasonable, the same as nvme_reset_work, wouldn't be the worst thing in the world if we duplicated the "Don't limit the IOMMU merged segment size" comment from the generic driver for the apple version also if there ends up being a v2. Reviewed-by: Eric Curtin > --- > drivers/nvme/host/apple.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c > index 5fc5ea196b40..ff8b083dc5c6 100644 > --- a/drivers/nvme/host/apple.c > +++ b/drivers/nvme/host/apple.c > @@ -1039,6 +1039,8 @@ static void apple_nvme_reset_work(struct work_struct *work) > dma_max_mapping_size(anv->dev) >> 9); > anv->ctrl.max_segments = NVME_MAX_SEGS; > > + dma_set_max_seg_size(anv->dev, 0xffffffff); > + > /* > * Enable NVMMU and linear submission queues. > * While we could keep those disabled and pretend this is slightly > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C78B5C433FE for ; Wed, 12 Oct 2022 12:12:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=phK3jdUT/xHCxFgt8wFGnIz+mcXgxDJsmS7vl2UJOow=; b=H/a8g0hkD2+SVo OR2AMAM2Z724E/jQFG0saLEfYWjOmJq5Eav7IIOUzznP11rq674NGcGh7ER/5QyiGDKKl/3ds+SYM nG2p0dxnVpFo6n5eGWAnXSf/B99ysFw6yuCscIpWMC6s0i8xLL+qeTxVjeQ7CDlk3Ipi+n5SZSKMj QiAJA0mzTCR9KdD/az6INVeRR3+s2xLMH2QNu2317zyCbeu1nnqy2TL7/jz8tzWeOrBstp3pw+OYQ x2Bs3Zy8YX5mHAsbCJDc4k5e13pR9eUouxiG+HPi9G51PkV2bP+bkI5uNDXkQ9CUSg4Iwl9vmUGPl 0A4Hf9iGEoEe4Vu8w3FQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiaa3-007vzQ-8r; Wed, 12 Oct 2022 12:11:23 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiaZq-007vyO-Jy for linux-arm-kernel@lists.infradead.org; Wed, 12 Oct 2022 12:11:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665576665; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hregpx8t1kAHRsj5KIbt4EVewflLpm3kB0Chk3MbBVo=; b=VTHDK4Wpn36zsDCA1C/bekpG0slGkz73fYr1Ognb+pB/NM3nT0FOLLw5IxJl4YU62/d6a4 wwEKR/nX/XTZpSRFZdsoQLmD8EaNmjCupC2prLSnkpZd2ZhZrfwM7g1IA6tjZtR2Q2xN9M 7dKK/ePRUWWqoUzmWfaHnoIzbJ6+LR4= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-574-xg8NfyFLN5eaHeV8QdY0bg-1; Wed, 12 Oct 2022 08:11:04 -0400 X-MC-Unique: xg8NfyFLN5eaHeV8QdY0bg-1 Received: by mail-ua1-f69.google.com with SMTP id t21-20020ab04ad5000000b003d6a29c1824so6572695uae.13 for ; Wed, 12 Oct 2022 05:11:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hregpx8t1kAHRsj5KIbt4EVewflLpm3kB0Chk3MbBVo=; b=BcMHBNmwkJ8hwAX9vMdk1d6qxPBJIvsttmH9DYfCbzmZ8Eb3K9oYaoqrmS4nkMW5/1 Ew/pi72AjXA+vQpt25/XEyT0yJpcteKymzaivwgJk7ETsJuR/hf5gjd617VbFmOMG1IS ZbDgk3vrh/gMU8rrCvGDOVqWH41lXQp6Ya1kbYagoRug/WuHwasf1Ano9+M7k36XDZTB SblqAAwClsOpWscxK5NkhORHaV/WhCzmZHXHC/PhsaQH75gNy/2lw5CrSE8PwMucFN4x t5AS85YSEuoih//cGSrB2S8vXVVdmhR16b0Em/RQMzEvOts0NzRDPZusUMylQSJBEFhD al8A== X-Gm-Message-State: ACrzQf3Dt9of4snyS4DJqEFn8hLY9jO+M1XfgJjaqrL9HHr6DGTBr9sX +E70OhZ9LA0PtAaFASckR5hLAb+hLoFm63vIfPo3whk3XZWfukpqz5FGCnMFwdkEEJ3cl/+88wz UHH+MjPj0/YUm3/V2jSAxZHTQ80HnJp6l/CP2TGpf679s7JVF7b8= X-Received: by 2002:ab0:7c8f:0:b0:381:c81f:6152 with SMTP id v15-20020ab07c8f000000b00381c81f6152mr14996263uaw.58.1665576663444; Wed, 12 Oct 2022 05:11:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6BcAPMB0fOUebVBZrx75XmrZkHjxCDZuCbZ2MEbg+W3PfuUXuBgiCfdkdxsD5PMXfIc/kiYj+v9aXSxNwUOUI= X-Received: by 2002:ab0:7c8f:0:b0:381:c81f:6152 with SMTP id v15-20020ab07c8f000000b00381c81f6152mr14996248uaw.58.1665576663179; Wed, 12 Oct 2022 05:11:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Curtin Date: Wed, 12 Oct 2022 13:10:47 +0100 Message-ID: Subject: Re: [PATCH] nvme-apple: fix DMA-API warning To: "Russell King (Oracle)" Cc: Sven Peter , Hector Martin , Alyssa Rosenzweig , Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221012_051111_039969_C418C944 X-CRM114-Status: GOOD ( 19.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 12 Oct 2022 at 12:53, Russell King (Oracle) wrote: > > Fix the following DMA-API warning: > > DMA-API: nvme-apple 27bcc0000.nvme: mapping sg segment longer than device claims to support [len=69632] [max=65536] > WARNING: CPU: 3 PID: 1 at kernel/dma/debug.c:1160 debug_dma_map_sg+0x310/0x3a0 > Modules linked in: tps6598x roles typec rtc_macsmc gpio_macsmc nvme_apple apple_mailbox apple_sart pcie_apple macsmc_rtkit macsmc pinctrl_apple_gpio i2c_apple > CPU: 3 PID: 1 Comm: init Not tainted 6.0.0+ #1081 > Hardware name: Apple Mac mini (M1, 2020) (DT) > pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : debug_dma_map_sg+0x310/0x3a0 > lr : debug_dma_map_sg+0x310/0x3a0 > ... > Call trace: > debug_dma_map_sg+0x310/0x3a0 > __dma_map_sg_attrs+0x98/0xf4 > dma_map_sg_attrs+0xc/0x1c > apple_nvme_queue_rq+0x218/0x67c [nvme_apple] > blk_mq_dispatch_rq_list+0x198/0x81c > blk_mq_do_dispatch_sched+0x2b0/0x340 > __blk_mq_sched_dispatch_requests+0x104/0x154 > blk_mq_sched_dispatch_requests+0x38/0x70 > __blk_mq_run_hw_queue+0x80/0x130 > __blk_mq_delay_run_hw_queue+0x84/0x90 > blk_mq_run_hw_queue+0x134/0x170 > blk_mq_sched_insert_requests+0xec/0x300 > blk_mq_flush_plug_list+0x104/0x430 > __blk_flush_plug+0xe8/0x130 > blk_finish_plug+0x30/0x1f0 > read_pages+0x1ec/0x334 > page_cache_ra_unbounded+0x158/0x1bc > page_cache_ra_order+0x80/0x2c0 > filemap_fault+0x4bc/0x970 > __do_fault+0x38/0x144 > __handle_mm_fault+0x7c4/0xc60 > handle_mm_fault+0x120/0x2a0 > do_page_fault+0x130/0x47c > do_translation_fault+0xa0/0xb0 > do_mem_abort+0x40/0x90 > el0_da+0x2c/0x80 > el0t_64_sync_handler+0x60/0xb4 > el0t_64_sync+0x168/0x16c > ---[ end trace 0000000000000000 ]--- > > Suggested-by: Sven Peter > Signed-off-by: Russell King (Oracle) Seems reasonable, the same as nvme_reset_work, wouldn't be the worst thing in the world if we duplicated the "Don't limit the IOMMU merged segment size" comment from the generic driver for the apple version also if there ends up being a v2. Reviewed-by: Eric Curtin > --- > drivers/nvme/host/apple.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/nvme/host/apple.c b/drivers/nvme/host/apple.c > index 5fc5ea196b40..ff8b083dc5c6 100644 > --- a/drivers/nvme/host/apple.c > +++ b/drivers/nvme/host/apple.c > @@ -1039,6 +1039,8 @@ static void apple_nvme_reset_work(struct work_struct *work) > dma_max_mapping_size(anv->dev) >> 9); > anv->ctrl.max_segments = NVME_MAX_SEGS; > > + dma_set_max_seg_size(anv->dev, 0xffffffff); > + > /* > * Enable NVMMU and linear submission queues. > * While we could keep those disabled and pretend this is slightly > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel