From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53079)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <greg.bellows@linaro.org>) id 1WupvL-0000mo-Az
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 17:19:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <greg.bellows@linaro.org>) id 1WupvF-0001Yl-P0
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 17:19:11 -0400
Received: from mail-qc0-f174.google.com ([209.85.216.174]:47240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <greg.bellows@linaro.org>) id 1WupvE-0001YS-QV
	for qemu-devel@nongnu.org; Wed, 11 Jun 2014 17:19:05 -0400
Received: by mail-qc0-f174.google.com with SMTP id x13so572779qcv.5
	for <qemu-devel@nongnu.org>; Wed, 11 Jun 2014 14:19:03 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAFEAcA96xH9HfMZE7q7jtn8a=D2Md20Z+7wmQ7QjqtOEv7RfQA@mail.gmail.com>
References: <1402326269-8573-1-git-send-email-edgar.iglesias@gmail.com>
	<1402326269-8573-14-git-send-email-edgar.iglesias@gmail.com>
	<CAOgzsHVfpFW6OMmyX75KZw-myFKVLvDezFfqBfDqgsbQac8L9Q@mail.gmail.com>
	<CAFEAcA96xH9HfMZE7q7jtn8a=D2Md20Z+7wmQ7QjqtOEv7RfQA@mail.gmail.com>
Date: Wed, 11 Jun 2014 16:19:03 -0500
Message-ID: <CAOgzsHV=RGGk4Vp7GqK5=iLzNQWgsKtzSrmT4EsiA7SouCPGtA@mail.gmail.com>
From: Greg Bellows <greg.bellows@linaro.org>
Content-Type: multipart/alternative; boundary=001a1139bf0c69f46d04fb95fe5d
Subject: Re: [Qemu-devel] [PATCH v2 13/17] target-arm: Use uint16_t in
 syndrome generators with 16bit imms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Fabian Aggeler <aggelerf@ethz.ch>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, John Williams <john.williams@xilinx.com>, Paolo Bonzini <pbonzini@redhat.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, Christoffer Dall <christoffer.dall@linaro.org>, Richard Henderson <rth@twiddle.net>

--001a1139bf0c69f46d04fb95fe5d
Content-Type: text/plain; charset=UTF-8

"not convinced" ... I was just saying that I could not find any benefit for
it.


On 11 June 2014 16:05, Peter Maydell <peter.maydell@linaro.org> wrote:

> On 11 June 2014 20:19, Greg Bellows <greg.bellows@linaro.org> wrote:
> > Called out possibly missing fix below.  Beside it, I'm convinced this
> change
> > is beneficial, other than maybe for readability.
>
> "not convinced" ?
>
> Personally, I don't much care either way, but I would suggest that
> if you're trying to get a big fat patchset through it's usually better
> not to throw in too many not-actually-needed patches :-)
>
> -- PMM
>

--001a1139bf0c69f46d04fb95fe5d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">&quot;not convinced&quot; ... I was just saying that I cou=
ld not find any benefit for it. =C2=A0</div><div class=3D"gmail_extra"><br>=
<br><div class=3D"gmail_quote">On 11 June 2014 16:05, Peter Maydell <span d=
ir=3D"ltr">&lt;<a href=3D"mailto:peter.maydell@linaro.org" target=3D"_blank=
">peter.maydell@linaro.org</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"">On 11 June 2014 20:19, Greg =
Bellows &lt;<a href=3D"mailto:greg.bellows@linaro.org">greg.bellows@linaro.=
org</a>&gt; wrote:<br>

&gt; Called out possibly missing fix below. =C2=A0Beside it, I&#39;m convin=
ced this change<br>
&gt; is beneficial, other than maybe for readability.<br>
<br>
</div>&quot;not convinced&quot; ?<br>
<br>
Personally, I don&#39;t much care either way, but I would suggest that<br>
if you&#39;re trying to get a big fat patchset through it&#39;s usually bet=
ter<br>
not to throw in too many not-actually-needed patches :-)<br>
<br>
-- PMM<br>
</blockquote></div><br></div>

--001a1139bf0c69f46d04fb95fe5d--