From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbdA3E4y (ORCPT ); Sun, 29 Jan 2017 23:56:54 -0500 Received: from mail-yb0-f193.google.com ([209.85.213.193]:34501 "EHLO mail-yb0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751507AbdA3E4q (ORCPT ); Sun, 29 Jan 2017 23:56:46 -0500 MIME-Version: 1.0 In-Reply-To: <1482926828-19746-3-git-send-email-cw00.choi@samsung.com> References: <1482926828-19746-1-git-send-email-cw00.choi@samsung.com> <1482926828-19746-3-git-send-email-cw00.choi@samsung.com> From: Viresh Kumar Date: Mon, 30 Jan 2017 10:20:19 +0530 X-Google-Sender-Auth: A_fW8pj-i1GlCdU2bdx7Wdo8lws Message-ID: Subject: Re: [PATCH v2 2/2] PM / devfreq: Add suspend frequency support To: Chanwoo Choi Cc: MyungJoo Ham , Kyungmin Park , hl@rock-chips.com, tjakobi@math.uni-bielefeld.de, chanwoo@kernel.org, "Rafael J. Wysocki" , Linux PM list , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 28, 2016 at 5:37 PM, Chanwoo Choi wrote: > +++ b/drivers/devfreq/devfreq.c > @@ -620,6 +620,23 @@ struct devfreq *devfreq_add_device(struct device *dev, > goto err_init; > } > > + /* > + * Get the suspend frequency from OPP table. But the devfreq device > + * using passive governor don't need to get the suspend frequency > + * because the passive devfreq device depend on the parent devfreq > + * device. > + */ > + devfreq->suspend_freq = 0L; > + if (strncmp(devfreq->governor_name, "passive", 7)) { > + struct dev_pm_opp *opp; > + > + rcu_read_lock(); > + opp = dev_pm_opp_get_suspend_opp(dev); > + if (opp) > + devfreq->suspend_freq = dev_pm_opp_get_freq(opp); The interface has changed a bit recently. Can you please use below function instead ? dev_pm_opp_get_suspend_opp_freq()