All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hongbo Zhang <hongbo.zhang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
	pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org
Cc: Antonios Motakis
	<a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org>
Subject: Exynos IOMMU driver doesn't work?
Date: Wed, 7 Jan 2015 18:31:42 +0800	[thread overview]
Message-ID: <CAOhR-w2vQbyYrWsvZjs-Pt6tU6m9BmH-T5tuBDSyUXteWgxP0Q@mail.gmail.com> (raw)

Hi Cho KyongHo, Joerg et al,
I found the latest Exynos IOMMU driver doesn't work, the line 481:
BUG_ON(!has_sysmmu(dev));
in function __exynos_sysmmu_enable() in file exynos-iommu.c triggers
kernel panic.

Then I found the dev->archdata.iommu isn't initialized at all, it
should be the root cause.

Am I right? any comment, solution?

Another problem is this driver is added support of device tree, but
there is no device tree nodes in the dts file, so I had to search from
internet and added those nodes manually.

I've found these links of v12 and v13 patches
https://lkml.org/lkml/2014/4/27/171
https://lkml.org/lkml/2014/5/12/34
patch v13 was merged into mainline kernel, but as a part of v12, it
isn't complete and doesn't work alone, eg dts nodes are missing.
(I didn't research much dev->archdata.iommu initialization error is
introduced by which patch, but it seems in very old codes there is no
such problem)

Thanks.

             reply	other threads:[~2015-01-07 10:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 10:31 Hongbo Zhang [this message]
     [not found] ` <CAOhR-w2vQbyYrWsvZjs-Pt6tU6m9BmH-T5tuBDSyUXteWgxP0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-09  7:31   ` Exynos IOMMU driver doesn't work? Hongbo Zhang
     [not found]     ` <CAOhR-w1gH6zzSZcw-0Lo0zc+p1Mt0=4aqWEZ0Agz4xw0uHsq7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-09 15:34       ` Javier Martinez Canillas
     [not found]         ` <CABxcv=n26-A86OmsqviEUz=XSF6QP6K0s=Dfzc43x4+if_qP7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-12 10:51           ` Hongbo Zhang
     [not found]             ` <CAOhR-w0BcdrSLw7fVOTokNrQkcfsRj8skm6fn1UCMGgDeGDNKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-12 11:17               ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOhR-w2vQbyYrWsvZjs-Pt6tU6m9BmH-T5tuBDSyUXteWgxP0Q@mail.gmail.com \
    --to=hongbo.zhang-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=a.motakis-lrHrjnjw1UfHK3s98zE1ajGjJy/sRE9J@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=pullip.cho-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.