All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xin Li <delphij@google.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	Ian Kasprzak <iankaz@google.com>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH v4] fetch: allow adding a filter after initial clone.
Date: Thu, 28 May 2020 23:54:59 -0700	[thread overview]
Message-ID: <CAOhzduh4V4LKgzksTkSdEDrgsv59jTpfYDBTUzZvRxZOaqhhmg@mail.gmail.com> (raw)
In-Reply-To: <20200529010119.GE114915@google.com>

Regarding t/t2404-worktree-config.sh:

On Thu, May 28, 2020 at 6:01 PM Jonathan Nieder <jrnieder@gmail.com> wrote:
> Xin Li wrote:
>
> > diff --git a/t/t2404-worktree-config.sh b/t/t2404-worktree-config.sh
> > index 286121d8de..9536d10919 100755
> > --- a/t/t2404-worktree-config.sh
> > +++ b/t/t2404-worktree-config.sh
> > @@ -23,8 +23,10 @@ test_expect_success 'config --worktree without extension' '
> >  '
> >
> >  test_expect_success 'enable worktreeConfig extension' '
> > +     git config core.repositoryformatversion 1 &&
> >       git config extensions.worktreeConfig true &&
>
> Yes, makes sense.  Does this patch need it, or could this go in a
> separate patch?

Yes, this patch needs setting repositoryformatversion to 1 as we would
no longer recognize extensions.worktreeConfig=true on version 0
repositories.

> > -     test_cmp_config true extensions.worktreeConfig
> > +     test_cmp_config true extensions.worktreeConfig &&
> > +     test_cmp_config 1 core.repositoryformatversion
>
> This (both the existing code and the modified version) is strange: we
> just set the config, so why are we checking it?

The check was mainly to match the existing pattern (which sets
extensions.worktreeConfig and immediately asserts that they were set).
These assertions are not strictly necessary but are harmless, so I
don't feel strongly about keeping or removing them.

  parent reply	other threads:[~2020-05-29  6:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 20:00 [PATCH] fetch: allow adding a filter after initial clone Xin Li
2020-05-13 20:43 ` Junio C Hamano
2020-05-13 21:41   ` Xin Li
2020-05-13 22:07     ` Junio C Hamano
2020-05-13 22:18     ` Junio C Hamano
2020-05-13 23:44 ` brian m. carlson
2020-05-28  2:53   ` [PATCH v2 0/1] " Xin Li
2020-05-28  2:54   ` [PATCH v2 1/1] " Xin Li
2020-05-28  3:28     ` Jonathan Nieder
2020-05-28  4:08       ` [PATCH v3] " Xin Li
2020-05-28 15:04     ` [PATCH v2 1/1] " Junio C Hamano
2020-05-28 17:19       ` Jonathan Nieder
2020-05-28 19:12         ` Xin Li
2020-05-28 19:17           ` Jonathan Nieder
2020-05-29  0:04             ` [PATCH v4] " Xin Li
2020-05-29  0:41               ` Junio C Hamano
2020-05-29 18:00                 ` Junio C Hamano
2020-05-29  1:01               ` Jonathan Nieder
2020-05-29  6:44                 ` [PATCH v5] " Xin Li
2020-05-29  6:54                 ` Xin Li [this message]
2020-05-29 18:06                 ` [PATCH v4] " Junio C Hamano
2020-06-05  9:10                   ` [PATCH v6 0/4] " Xin Li
2020-06-05  9:10                     ` [PATCH v6 1/4] repository: add a helper function to perform repository format upgrade Xin Li
2020-06-05 19:12                       ` Junio C Hamano
2020-06-05  9:10                     ` [PATCH v6 2/4] fetch: allow adding a filter after initial clone Xin Li
2020-06-05 19:15                       ` Junio C Hamano
2020-06-05  9:10                     ` [PATCH v6 3/4] sparse-checkout: upgrade repository to version 1 when enabling extension Xin Li
2020-06-05 19:21                       ` Junio C Hamano
2020-06-05  9:10                     ` [PATCH v6 4/4] check_repository_format_gently(): refuse extensions for old repositories Xin Li
2020-06-08 16:59                       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOhzduh4V4LKgzksTkSdEDrgsv59jTpfYDBTUzZvRxZOaqhhmg@mail.gmail.com \
    --to=delphij@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=iankaz@google.com \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.