From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33AFBC48BCD for ; Wed, 9 Jun 2021 09:37:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 125F061287 for ; Wed, 9 Jun 2021 09:37:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238068AbhFIJjn (ORCPT ); Wed, 9 Jun 2021 05:39:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234748AbhFIJjm (ORCPT ); Wed, 9 Jun 2021 05:39:42 -0400 Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DA42C061574; Wed, 9 Jun 2021 02:37:47 -0700 (PDT) Received: by mail-il1-x12e.google.com with SMTP id b5so24586358ilc.12; Wed, 09 Jun 2021 02:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=11paM/1lp22CavDEEN3A/olA+tOS+m0UgIjuNNPMc5c=; b=AUn30ilbL3NzF5q2BCp0QVXHikpm8Vm6yUAM9SdAhos2m9u8xXGwxlhY7L/mh5ETkk xMDLHdDCnvMj9u5VwkHn37GW+ujRpw2uJn/g/RTKxpbLL7paohPJB9BFTIoD6vBOz0FJ wlEZkhAcmqWn9YlRTm67JdkNWHAiNqs9sQF7kLfjGLtZZjwbbdwYYhZL9eEqO6j8XGwT WGtn6z7Ok1u7/f7AJWVfLsFL4AOnd9bBJ2NKdphWe6mO0Sya+xn+4ljLwykvBX8unsLj qDtDo0A3iPuoyVDOa2dKVu/uzCQIFKij1E9QJ4Rpt6+OuJFeAbsxKLDuKg+JVf9eTdvV qvfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=11paM/1lp22CavDEEN3A/olA+tOS+m0UgIjuNNPMc5c=; b=D+4f2a9eNChSRAA625nVypjPfxAKmgHzYO1PX48Zh64AITQquDEUcgJsuj5a5bt9Pe hom6FP+cbzAgNCSYOESRIYnfS1uG1p5/dEH/Un0rgmryIYpZ+cF2Cfls+nXrjLjil0kX ++Y2rVWNge8GsGQ0wAnyvp6krHA0qhkGyv90uI+kD8OwvMWE61w/X8KIruWRBaVcRbAd 8uurSPMiRqj4Glm73UCXY8RjzBGQwPZ7SYck9AWcu9PwzXFyPDGYrI12bS6b/OJp2rcp E4Yanqjz3qv8QMw4JdZalSq7AHWEvkTHUbn32UKVfAaMj0Zid0ki4ydmZGazXirvIWhH wM7A== X-Gm-Message-State: AOAM5313/mgOhvCJK8cXznROgr0ZWB9nDI6Rrd2UXhB+50CP7KG6CXx8 FkPmpgMQkFRnWwoBUe4/JP3QuYSc9LrmgZKthEs= X-Google-Smtp-Source: ABdhPJy5AROZdbsU+O1Vh/bwrnsq7wRpZEor176YD0iLaHDJhsh5Ad6i076nqZiL2In6oQ6aCiJFsx/mBME7wo4cSUc= X-Received: by 2002:a05:6638:267:: with SMTP id x7mr7028650jaq.51.1623231466755; Wed, 09 Jun 2021 02:37:46 -0700 (PDT) MIME-Version: 1.0 References: <20210608160603.1535935-1-hch@lst.de> <20210608160603.1535935-8-hch@lst.de> In-Reply-To: <20210608160603.1535935-8-hch@lst.de> From: Ilya Dryomov Date: Wed, 9 Jun 2021 11:37:45 +0200 Message-ID: Subject: Re: [PATCH 07/16] rbd: use memzero_bvec To: Christoph Hellwig Cc: Jens Axboe , Thomas Bogendoerfer , Geoff Levand , Dongsheng Yang , Mike Snitzer , Ira Weiny , dm-devel@redhat.com, linux-mips@vger.kernel.org, LKML , linux-block , linuxppc-dev@lists.ozlabs.org, Ceph Development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Tue, Jun 8, 2021 at 6:06 PM Christoph Hellwig wrote: > > Use memzero_bvec instead of reimplementing it. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rbd.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index bbb88eb009e0..eb243fc4d108 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -1219,24 +1219,13 @@ static void rbd_dev_mapping_clear(struct rbd_device *rbd_dev) > rbd_dev->mapping.size = 0; > } > > -static void zero_bvec(struct bio_vec *bv) > -{ > - void *buf; > - unsigned long flags; > - > - buf = bvec_kmap_irq(bv, &flags); > - memset(buf, 0, bv->bv_len); > - flush_dcache_page(bv->bv_page); > - bvec_kunmap_irq(buf, &flags); > -} > - > static void zero_bios(struct ceph_bio_iter *bio_pos, u32 off, u32 bytes) > { > struct ceph_bio_iter it = *bio_pos; > > ceph_bio_iter_advance(&it, off); > ceph_bio_iter_advance_step(&it, bytes, ({ > - zero_bvec(&bv); > + memzero_bvec(&bv); > })); > } > > @@ -1246,7 +1235,7 @@ static void zero_bvecs(struct ceph_bvec_iter *bvec_pos, u32 off, u32 bytes) > > ceph_bvec_iter_advance(&it, off); > ceph_bvec_iter_advance_step(&it, bytes, ({ > - zero_bvec(&bv); > + memzero_bvec(&bv); > })); > } > Ira already brought up the fact that this conversion drops flush_dcache_page() calls throughout. Other than that: Acked-by: Ilya Dryomov Thanks, Ilya From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DD8C48BE0 for ; Wed, 9 Jun 2021 09:38:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9C5E61285 for ; Wed, 9 Jun 2021 09:38:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9C5E61285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4G0MVH63mjz3byD for ; Wed, 9 Jun 2021 19:38:15 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=AUn30ilb; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::136; helo=mail-il1-x136.google.com; envelope-from=idryomov@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=AUn30ilb; dkim-atps=neutral Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4G0MTp6sM7z2yWp for ; Wed, 9 Jun 2021 19:37:50 +1000 (AEST) Received: by mail-il1-x136.google.com with SMTP id x18so24594174ila.10 for ; Wed, 09 Jun 2021 02:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=11paM/1lp22CavDEEN3A/olA+tOS+m0UgIjuNNPMc5c=; b=AUn30ilbL3NzF5q2BCp0QVXHikpm8Vm6yUAM9SdAhos2m9u8xXGwxlhY7L/mh5ETkk xMDLHdDCnvMj9u5VwkHn37GW+ujRpw2uJn/g/RTKxpbLL7paohPJB9BFTIoD6vBOz0FJ wlEZkhAcmqWn9YlRTm67JdkNWHAiNqs9sQF7kLfjGLtZZjwbbdwYYhZL9eEqO6j8XGwT WGtn6z7Ok1u7/f7AJWVfLsFL4AOnd9bBJ2NKdphWe6mO0Sya+xn+4ljLwykvBX8unsLj qDtDo0A3iPuoyVDOa2dKVu/uzCQIFKij1E9QJ4Rpt6+OuJFeAbsxKLDuKg+JVf9eTdvV qvfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=11paM/1lp22CavDEEN3A/olA+tOS+m0UgIjuNNPMc5c=; b=YZQ0qnjao7ZgEqCr2K1kyMe/URb67f6nbc5KPjbyA9hD+giTwaq0DQzmrXm9p/1jeN z/4U6UR719KzO/OjTbSPUYH74mEjRPhpAKfYmTqiTBlyV0i7M9HmJ3zdHho7NJRodkiV mLlHCqHTawvazZY7/GfeBLEiy3TbtLNTWOidw2xOE5bx3+mZtD43K3/9dFk0UWWeYyYl amuOkaIKSjOHI1PL6IQkMz44vQ0a8IotYGHi55kadti4fEVeqenBwcR2iUqPcvuM/FQ/ UvFA+8JQ++f9npt1Bep+wVvAp4t22GY8FZISMwg5W6WYu6OdaM1Jd1Q0PIdUY1rBT9Rq GJNw== X-Gm-Message-State: AOAM531dtzWkYRQYVP4PHIkMxYchN7i8iDk1/9UTmS3wcBlLROhReA0R TkHOW6oUwoQh//eMtsu3eeZlwSvx4dUCWSwLV4g= X-Google-Smtp-Source: ABdhPJy5AROZdbsU+O1Vh/bwrnsq7wRpZEor176YD0iLaHDJhsh5Ad6i076nqZiL2In6oQ6aCiJFsx/mBME7wo4cSUc= X-Received: by 2002:a05:6638:267:: with SMTP id x7mr7028650jaq.51.1623231466755; Wed, 09 Jun 2021 02:37:46 -0700 (PDT) MIME-Version: 1.0 References: <20210608160603.1535935-1-hch@lst.de> <20210608160603.1535935-8-hch@lst.de> In-Reply-To: <20210608160603.1535935-8-hch@lst.de> From: Ilya Dryomov Date: Wed, 9 Jun 2021 11:37:45 +0200 Message-ID: Subject: Re: [PATCH 07/16] rbd: use memzero_bvec To: Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Thomas Bogendoerfer , Mike Snitzer , Geoff Levand , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, Dongsheng Yang , LKML , linux-block , dm-devel@redhat.com, Ceph Development , Ira Weiny Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jun 8, 2021 at 6:06 PM Christoph Hellwig wrote: > > Use memzero_bvec instead of reimplementing it. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rbd.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index bbb88eb009e0..eb243fc4d108 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -1219,24 +1219,13 @@ static void rbd_dev_mapping_clear(struct rbd_device *rbd_dev) > rbd_dev->mapping.size = 0; > } > > -static void zero_bvec(struct bio_vec *bv) > -{ > - void *buf; > - unsigned long flags; > - > - buf = bvec_kmap_irq(bv, &flags); > - memset(buf, 0, bv->bv_len); > - flush_dcache_page(bv->bv_page); > - bvec_kunmap_irq(buf, &flags); > -} > - > static void zero_bios(struct ceph_bio_iter *bio_pos, u32 off, u32 bytes) > { > struct ceph_bio_iter it = *bio_pos; > > ceph_bio_iter_advance(&it, off); > ceph_bio_iter_advance_step(&it, bytes, ({ > - zero_bvec(&bv); > + memzero_bvec(&bv); > })); > } > > @@ -1246,7 +1235,7 @@ static void zero_bvecs(struct ceph_bvec_iter *bvec_pos, u32 off, u32 bytes) > > ceph_bvec_iter_advance(&it, off); > ceph_bvec_iter_advance_step(&it, bytes, ({ > - zero_bvec(&bv); > + memzero_bvec(&bv); > })); > } > Ira already brought up the fact that this conversion drops flush_dcache_page() calls throughout. Other than that: Acked-by: Ilya Dryomov Thanks, Ilya From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 158D0C47095 for ; Wed, 9 Jun 2021 09:41:46 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C6E660FEB for ; Wed, 9 Jun 2021 09:41:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C6E660FEB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-EF9hKraOMKSDu6JWXwBRbw-1; Wed, 09 Jun 2021 05:41:42 -0400 X-MC-Unique: EF9hKraOMKSDu6JWXwBRbw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F380780ED96; Wed, 9 Jun 2021 09:41:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ADB7A1001281; Wed, 9 Jun 2021 09:41:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6BCDF1809CAE; Wed, 9 Jun 2021 09:41:36 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1599bqNk030422 for ; Wed, 9 Jun 2021 05:37:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7687821CAC7C; Wed, 9 Jun 2021 09:37:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7169B21CAC80 for ; Wed, 9 Jun 2021 09:37:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9D7CE1825064 for ; Wed, 9 Jun 2021 09:37:49 +0000 (UTC) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-liXvqAihNRSn9xNWGnNJow-1; Wed, 09 Jun 2021 05:37:47 -0400 X-MC-Unique: liXvqAihNRSn9xNWGnNJow-1 Received: by mail-il1-f175.google.com with SMTP id h16so11916280ila.6; Wed, 09 Jun 2021 02:37:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=11paM/1lp22CavDEEN3A/olA+tOS+m0UgIjuNNPMc5c=; b=m0adVq3vMz3CNOU2t7nW5VOId7u81KJyL3Q8y2vmNh6h1yLt3fm0vs17RzS0EiWTwm DJZ6Njgf0inBRBpq1lXL2F3HpLV8H4jY2yeCfClZ4nkJgbZz22WzBstecHlzA1dxQHUT KXk1KL0qOJREaw5nc7c6a63n+kCXgN29P3kYANSIQ63BhLzJI+HBaI5/93i6aJVrU9P1 u5hRJ+iFsagy1E+Sxp1sChL+PmtE2caDYXWLH210SSHWKqiheopsU0mRJMZroa6eYSse ky7a+G5vKUuQvVfvbhZV6Fn0NLTToqUxYOv4JsOVwk2Birx823jGvYD3BvHavjPjDb/B expA== X-Gm-Message-State: AOAM532SVr21gUoPiY6a42Uu5Yuj6ncuJC/h27RJ2qd6EF6XXtZMdeVW hOFoaY+rng9Lmlj/iea8MsS9sKCMik991NOE8zUIT+YCOQa5s4G0 X-Google-Smtp-Source: ABdhPJy5AROZdbsU+O1Vh/bwrnsq7wRpZEor176YD0iLaHDJhsh5Ad6i076nqZiL2In6oQ6aCiJFsx/mBME7wo4cSUc= X-Received: by 2002:a05:6638:267:: with SMTP id x7mr7028650jaq.51.1623231466755; Wed, 09 Jun 2021 02:37:46 -0700 (PDT) MIME-Version: 1.0 References: <20210608160603.1535935-1-hch@lst.de> <20210608160603.1535935-8-hch@lst.de> In-Reply-To: <20210608160603.1535935-8-hch@lst.de> From: Ilya Dryomov Date: Wed, 9 Jun 2021 11:37:45 +0200 Message-ID: To: Christoph Hellwig X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Thomas Bogendoerfer , Mike Snitzer , Geoff Levand , linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org, Dongsheng Yang , LKML , linux-block , dm-devel@redhat.com, Ceph Development , Ira Weiny Subject: Re: [dm-devel] [PATCH 07/16] rbd: use memzero_bvec X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Jun 8, 2021 at 6:06 PM Christoph Hellwig wrote: > > Use memzero_bvec instead of reimplementing it. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/rbd.c | 15 ++------------- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index bbb88eb009e0..eb243fc4d108 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -1219,24 +1219,13 @@ static void rbd_dev_mapping_clear(struct rbd_device *rbd_dev) > rbd_dev->mapping.size = 0; > } > > -static void zero_bvec(struct bio_vec *bv) > -{ > - void *buf; > - unsigned long flags; > - > - buf = bvec_kmap_irq(bv, &flags); > - memset(buf, 0, bv->bv_len); > - flush_dcache_page(bv->bv_page); > - bvec_kunmap_irq(buf, &flags); > -} > - > static void zero_bios(struct ceph_bio_iter *bio_pos, u32 off, u32 bytes) > { > struct ceph_bio_iter it = *bio_pos; > > ceph_bio_iter_advance(&it, off); > ceph_bio_iter_advance_step(&it, bytes, ({ > - zero_bvec(&bv); > + memzero_bvec(&bv); > })); > } > > @@ -1246,7 +1235,7 @@ static void zero_bvecs(struct ceph_bvec_iter *bvec_pos, u32 off, u32 bytes) > > ceph_bvec_iter_advance(&it, off); > ceph_bvec_iter_advance_step(&it, bytes, ({ > - zero_bvec(&bv); > + memzero_bvec(&bv); > })); > } > Ira already brought up the fact that this conversion drops flush_dcache_page() calls throughout. Other than that: Acked-by: Ilya Dryomov Thanks, Ilya -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel