From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0664C48BE8 for ; Mon, 14 Jun 2021 17:18:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D7B361246 for ; Mon, 14 Jun 2021 17:18:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235555AbhFNRUR (ORCPT ); Mon, 14 Jun 2021 13:20:17 -0400 Received: from mail-il1-f171.google.com ([209.85.166.171]:38416 "EHLO mail-il1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235509AbhFNRUM (ORCPT ); Mon, 14 Jun 2021 13:20:12 -0400 Received: by mail-il1-f171.google.com with SMTP id d1so12832983ils.5; Mon, 14 Jun 2021 10:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qQkiC2Boq1enDbw0Bq2sZY++jJ/micvga8E5sa5r6h8=; b=oaHRSDkeNHn3y88GUfUSl+LoUEKIRn0UkitkMvrlsd0qga4MoiaA592YqccF4da9+R QKW1b+YJSLQCJVdiYSQCpiWWYwf+WVMgl9iOhVL/cgl5wX4hncn7eyNFcYb3+2ZZdsou QSP41fxW6jivabswvcq/rzmls56ys2MZ4CWfNdXRhZwqW2Od9Q30bHZpqwX1Oze65Ww3 FidiC8bJBtYrqPNETHTfwtkIMqgNv6LBF7Mo2ijyO+W1VT35nq2Oe6vb8/7Blr/3NeP7 bjKnTQh13taBxcswZg5RvHo8Att1FPHoonSYx4GoulUkj4GNUwDZ+EKmo62FY0NlAKGW VhMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qQkiC2Boq1enDbw0Bq2sZY++jJ/micvga8E5sa5r6h8=; b=kClqWH+ENVbFTSHldYRG8lkQaGCdC0a1sgI2iHUOs68nZwZ2JWMLOYUUFb+e5n5w0K KwyL70qa3Ex658lTcbXTzD+/acbgL/y0coem9JBkgTEnA5EoE2Ek/E79cmaYX+z+DpYr WXYkb94udtqGxcpJKXClmbnhdHzJuMngcF1lrg0hEY68EvvJ6bgC0/RDrFdEKuqMqzOf AuQfr1/mBnrxrcrEZS1zUYfUzjIdZGJReqerFMSIyksJ+JtnBICTUJWb8uRBKlCCanZu WfqWVt+EH8L4HCAixTjMizYh9HLss5oX6QB4ifLbQmL1hUs1od5uPS2MJ3T8J24+h6XG 4rRQ== X-Gm-Message-State: AOAM5305FEEz/SedTyh9bhr6pugzaXoISbmD4u6gtaKMcCme9zx5F0Qb BUnLeq9Qq8NBqhKjXhlxHDQirQHZomQmtN7zY34= X-Google-Smtp-Source: ABdhPJwnFA+kS2s8Pa5xN5D5dTnI6Fj1l6zO+N6DVsd7aS+/13vpCxr6vmcTpiFdlRMsnD1ubpNYc7CmKGkDRdqEZD8= X-Received: by 2002:a05:6e02:1a03:: with SMTP id s3mr14899111ild.220.1623691029568; Mon, 14 Jun 2021 10:17:09 -0700 (PDT) MIME-Version: 1.0 References: <20210610094505.1341-1-zuoqilin1@163.com> In-Reply-To: <20210610094505.1341-1-zuoqilin1@163.com> From: Ilya Dryomov Date: Mon, 14 Jun 2021 19:17:03 +0200 Message-ID: Subject: Re: [PATCH] net/ceph: Remove unnecessary variables To: zuoqilin1@163.com Cc: Jeff Layton , "David S. Miller" , Jakub Kicinski , Ceph Development , netdev , LKML , zuoqilin Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 10, 2021 at 12:02 PM wrote: > > From: zuoqilin > > There is no necessary to define variable assignment, > just return directly to simplify the steps. > > Signed-off-by: zuoqilin > --- > net/ceph/auth.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/net/ceph/auth.c b/net/ceph/auth.c > index de407e8..b824a48 100644 > --- a/net/ceph/auth.c > +++ b/net/ceph/auth.c > @@ -58,12 +58,10 @@ struct ceph_auth_client *ceph_auth_init(const char *name, > const int *con_modes) > { > struct ceph_auth_client *ac; > - int ret; > > - ret = -ENOMEM; > ac = kzalloc(sizeof(*ac), GFP_NOFS); > if (!ac) > - goto out; > + return ERR_PTR(-ENOMEM); > > mutex_init(&ac->mutex); > ac->negotiating = true; > @@ -78,9 +76,6 @@ struct ceph_auth_client *ceph_auth_init(const char *name, > dout("%s name '%s' preferred_mode %d fallback_mode %d\n", __func__, > ac->name, ac->preferred_mode, ac->fallback_mode); > return ac; > - > -out: > - return ERR_PTR(ret); > } > > void ceph_auth_destroy(struct ceph_auth_client *ac) Applied. Thanks, Ilya