From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA11C48BE6 for ; Wed, 16 Jun 2021 12:36:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D27160249 for ; Wed, 16 Jun 2021 12:36:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D27160249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltUmN-0001G6-K9 for qemu-devel@archiver.kernel.org; Wed, 16 Jun 2021 08:36:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltUkm-0000Kb-BL; Wed, 16 Jun 2021 08:34:44 -0400 Received: from mail-io1-xd2e.google.com ([2607:f8b0:4864:20::d2e]:33463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltUkb-0004Dp-KY; Wed, 16 Jun 2021 08:34:43 -0400 Received: by mail-io1-xd2e.google.com with SMTP id a6so2894992ioe.0; Wed, 16 Jun 2021 05:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UYWISUZZqja988RnrGVa4SCJFCIq9ozVCNTSQp+03Z4=; b=I4JhzrnfdldTtCJDtYByuV3XBeTrmyza4awoz90qa+asPlf8AvOgHMQjS/7K1VeOR5 756szpFHwg2ktxPGi72DJetjPhgSHwqtHOCBS33oyTs56yzWau2oRYSPdhpy/hIJn8JD 5Fypq87GVZZgjcvXdjC9x1BGMNxO7GrJ6yUbK2E19hJydIgX6TO+5VJjm9WH8nfm+DIP uFGgiOMKUlZfIHTWqTO0nNcGCO27pAirnUoK+cGmO+iao0Pw6Nxj23AI45Aygm9e+DON yc5veR5C7w/qnF9SL2SzdivfLvStwhGuSzX5TxedfA906ecjaJ8dYXp4JuVIwQcYhn+y weKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UYWISUZZqja988RnrGVa4SCJFCIq9ozVCNTSQp+03Z4=; b=H/xq8+aZB5GfH5heEu89NyEGhPD+FqpvtjGUX7OI7lJbUMzXIKz+LYXf5Uffmr+/jN DpOCDLXerRJgjpAflYSGrLLNfMmCCfO1W2mNkkyXkVV0JcrOR+LyLShr07rmLbdyTbQk aBoWdyPoqWDgZF0TPCm8vDJHk6G9fzQ6Xo7jooruIA3mDvbV30xHFnp906xkU2E+sJmM xnt3Lecb9uVuZtmi/wsVwCPWHAcaVwIjtCaIqG4/OMF+Is4AeCMZR8AzXogP8LhXyNwY 895QE9TL/FHm67cWhmm9OXExI35ZXlnlPDbiQ/Tz6bt6jQauKJ1P7HE5JXEd3NXm1mN/ h5Pg== X-Gm-Message-State: AOAM533mjb3VF6KW4wC8gVOILa8qQRSpVe6i3KAaoXSt2K5AWV2LtPq1 Wh2cHf/bJ9T8uF15MZq1u8lO/gfFkRc45bS/e1M= X-Google-Smtp-Source: ABdhPJw4nrTUE5k4zfpPG4K4PeaTfrpzze9erOMgP2RANOWpdYxvCHFswgiJcbD/lpYOVeKSD1OkyykKAcIoq6ZZ6jY= X-Received: by 2002:a05:6638:3393:: with SMTP id h19mr263571jav.11.1623846872366; Wed, 16 Jun 2021 05:34:32 -0700 (PDT) MIME-Version: 1.0 References: <20210519142359.23083-1-pl@kamp.de> <20210519142359.23083-6-pl@kamp.de> In-Reply-To: <20210519142359.23083-6-pl@kamp.de> From: Ilya Dryomov Date: Wed, 16 Jun 2021 14:34:25 +0200 Message-ID: Subject: Re: [PATCH V3 5/6] block/rbd: add write zeroes support To: Peter Lieven Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d2e; envelope-from=idryomov@gmail.com; helo=mail-io1-xd2e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, ct@flyingcircus.io, Paolo Bonzini , mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, May 19, 2021 at 4:28 PM Peter Lieven wrote: > > Signed-off-by: Peter Lieven > --- > block/rbd.c | 37 ++++++++++++++++++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/block/rbd.c b/block/rbd.c > index 0d8612a988..ee13f08a74 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -63,7 +63,8 @@ typedef enum { > RBD_AIO_READ, > RBD_AIO_WRITE, > RBD_AIO_DISCARD, > - RBD_AIO_FLUSH > + RBD_AIO_FLUSH, > + RBD_AIO_WRITE_ZEROES > } RBDAIOCmd; > > typedef struct BDRVRBDState { > @@ -705,6 +706,10 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags, > } > } > > +#ifdef LIBRBD_SUPPORTS_WRITE_ZEROES > + bs->supported_zero_flags = BDRV_REQ_MAY_UNMAP; I wonder if we should also set BDRV_REQ_NO_FALLBACK here since librbd does not really have a notion of non-efficient explicit zeroing. Thanks, Ilya