Re: [PATCH 0/2] block: enforce ioctl(BLKROSET) and set_disk_ro()

[Ilya Dryomov <idryomov@gmail.com>]

On Thu, Nov 16, 2017 at 10:02 AM, Ilya Dryomov <idryomov@gmail.com> wrote:
> On Thu, Nov 9, 2017 at 7:44 PM, Ilya Dryomov <idryomov@gmail.com> wrote:
>> Hello,
>>
>> I was doing some cleanup work on rbd BLKROSET handler and discovered
>> that we ignore partition rw/ro setting (hd_struct->policy) for pretty
>> much everything but straight writes.
>>
>> David (CCed) has blktests patches standing by.
>>
>> (Another aspect of this is that we don't enforce open(2) mode.  Tejun
>> took a stab at this a few years ago, but his patch had to be reverted:
>>
>>   75f1dc0d076d ("block: check bdev_read_only() from blkdev_get()")
>>   e51900f7d38c ("block: revert block_dev read-only check")
>>
>> It is a separate issue and refusing writes to read-only devices is
>> obviously more important, but perhaps it's time to revisit that as
>> well?)
>>
>> Thanks,
>>
>>                 Ilya
>>
>>
>> Ilya Dryomov (2):
>>   block: fail op_is_write() requests to read-only partitions
>>   block: add bdev_read_only() checks to common helpers
>>
>>  block/blk-core.c | 23 ++++++++++++++++++++++-
>>  block/blk-lib.c  | 12 ++++++++++++
>>  2 files changed, 34 insertions(+), 1 deletion(-)
>
> Ping...  Christoph, Jens, could one of you please take a look?

Ping?

Thanks,

                Ilya