From: Ilya Dryomov <idryomov@gmail.com>
To: Loic Dachary <loic@dachary.org>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: Standalone libcrush: call for participation
Date: Tue, 24 Jan 2017 11:08:02 +0100 [thread overview]
Message-ID: <CAOi1vP9RNWaiAWfdw-25sWS8YyjYU-b0rAX2HyMCSCYR1qhOjA@mail.gmail.com> (raw)
In-Reply-To: <8256c0b6-a1b4-0c91-8832-35183dfdc9ed@dachary.org>
On Mon, Jan 23, 2017 at 10:59 PM, Loic Dachary <loic@dachary.org> wrote:
>
>
> On 01/23/2017 10:44 PM, Ilya Dryomov wrote:
>> On Mon, Jan 23, 2017 at 9:16 PM, Loic Dachary <loic@dachary.org> wrote:
>>>
>>>> Some documentation will probably need to be added to cover things like
>>>> basic kernel compatibility (no floating point, stubs for asserts, etc)
>>>> and coding style for the C bits.
>>>
>>> I added this
>>>
>>> http://libcrush.org/main/libcrush/blob/wip-2-doxygen/doc/contributing.md#linux-kernel
>>>
>>> Do you have anything else in mind ?
>>
>> No need to try to list all the kernel quirks -- just point to
>> crush_compat.h.
>>
>> These are the files that are shared:
>>
>> - crush.[ch]
>> - crush_ln_table.h
>> - hash.[ch]
>> - mapper.[ch]
>>
>> Everything else is fair game, notably builder.[ch].
>
> Understood :-)
>
> Is this http://libcrush.org/main/libcrush/blob/wip-2-doxygen/doc/mainpage.dox#L47 better ?
Looks good to me.
Thanks,
Ilya
prev parent reply other threads:[~2017-01-24 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 23:16 Standalone libcrush: call for participation Loic Dachary
2017-01-23 16:29 ` Adam C. Emerson
2017-01-23 17:00 ` Loic Dachary
2017-01-23 18:02 ` Adam C. Emerson
2017-01-23 18:43 ` Ilya Dryomov
2017-01-23 20:08 ` Loic Dachary
2017-01-23 21:27 ` Ilya Dryomov
[not found] ` <5d8fcfa6-3bf7-b29e-22a9-4d2864194afd@dachary.org>
2017-01-23 21:44 ` Ilya Dryomov
2017-01-23 21:59 ` Loic Dachary
2017-01-24 10:08 ` Ilya Dryomov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOi1vP9RNWaiAWfdw-25sWS8YyjYU-b0rAX2HyMCSCYR1qhOjA@mail.gmail.com \
--to=idryomov@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=loic@dachary.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.