From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95F9C11F68 for ; Fri, 2 Jul 2021 10:53:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CDD661421 for ; Fri, 2 Jul 2021 10:53:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CDD661421 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzGnX-00022w-Qy for qemu-devel@archiver.kernel.org; Fri, 02 Jul 2021 06:53:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzGg0-0005vC-37; Fri, 02 Jul 2021 06:45:40 -0400 Received: from mail-il1-x134.google.com ([2607:f8b0:4864:20::134]:37461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzGfy-0002PW-Gn; Fri, 02 Jul 2021 06:45:39 -0400 Received: by mail-il1-x134.google.com with SMTP id i13so9304902ilu.4; Fri, 02 Jul 2021 03:45:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jkcbQJ6oHo1Y0xo7BhcVKOg1wrcLVvqq39jfaYD79s0=; b=Sn2uSu/1rYPiJzhcbTG6eRjjUs7b9nHZLAqjO/dI8wVZUj6S3G9lAY015CipeJRVyQ TTU9Sajgf2eYZRCo0ozhREnR41ST/uBGTFKwKRvoKgvz01mww3FnHsfBkuuBvIOg9/yS R4siz0TJSKJqjA1it32nj5bYb8qC7eEAybOqrzGegJEb4hg1F3wfq1F64Cg6gaig5Ri/ /XT7z9axwpOORL8AP+LFXZGaEF3TGgDaBbCaFfJjsib2Me+zp6VLi6hGe0hi9MTQdE+8 kfGJyJNzpaEK0K4HmJ24vvU0cvcxQrlC6iygTu3peIpRUAn2ExHE1ksIEyLxkZjEOfnC P3mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jkcbQJ6oHo1Y0xo7BhcVKOg1wrcLVvqq39jfaYD79s0=; b=BOOkGLWAYigYbcMGQO1B6Z482CSatYFz1nUeEkW29jFpnlBPyIeFuGTgqiGh+/wZbK 2Wn8ZfLsHJAF35mlQt4MyC4UnmKtDt3SeEY0DBs3F41hNQv/tHx6k2VUVhDfnBQdtw44 t+6s6VUsy7dEZ5+tV2h8px9uSBiRyRYdieNPjJGgeEvwsglj/Uxi5bZG9CmhNdj7w/KH WutCioLPhKdBcCnJsWN7pVPFSFPSoj6KF6AWZhWafLmqs8lWwHNu2iNjjkqK+aEJF2lb 8IcN+c4eLtQD9KcsovBq/j9pqGO6TAJ/Waz6Rgsf1/d7pxl+MIcjyjRRaSul/eS751CM FNKw== X-Gm-Message-State: AOAM5306NYNGb4kohxeO+NjxMj0FWH8OMHmS4OcGgPWefjHrXod0hbdL NUmi9aSrLE3YdC05pac8OI1fe+ZPLZXbbMRFRo0= X-Google-Smtp-Source: ABdhPJw5esJI9/j0GC1bMNP40HLgB3C8QyKRoPmFGnjVd62gY2wVMPf3nhAf36jF6KsPrzFuY9kSEBB8PZZ2uQgbVf8= X-Received: by 2002:a05:6e02:50e:: with SMTP id d14mr102713ils.281.1625222736840; Fri, 02 Jul 2021 03:45:36 -0700 (PDT) MIME-Version: 1.0 References: <20210702090935.15300-1-pl@kamp.de> <20210702090935.15300-4-pl@kamp.de> In-Reply-To: <20210702090935.15300-4-pl@kamp.de> From: Ilya Dryomov Date: Fri, 2 Jul 2021 12:45:15 +0200 Message-ID: Subject: Re: [PATCH V4 3/6] block/rbd: update s->image_size in qemu_rbd_getlength To: Peter Lieven Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::134; envelope-from=idryomov@gmail.com; helo=mail-il1-x134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , qemu-block@nongnu.org, ct@flyingcircus.io, qemu-devel@nongnu.org, Paolo Bonzini , mreitz@redhat.com, Jason Dillaman Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Jul 2, 2021 at 11:09 AM Peter Lieven wrote: > > while at it just call rbd_get_size and avoid rbd_stat. > > Signed-off-by: Peter Lieven > --- > block/rbd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/block/rbd.c b/block/rbd.c > index b4caea4f1b..1f8dc84079 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -968,15 +968,14 @@ static int qemu_rbd_getinfo(BlockDriverState *bs, BlockDriverInfo *bdi) > static int64_t qemu_rbd_getlength(BlockDriverState *bs) > { > BDRVRBDState *s = bs->opaque; > - rbd_image_info_t info; > int r; > > - r = rbd_stat(s->image, &info, sizeof(info)); > + r = rbd_get_size(s->image, &s->image_size); > if (r < 0) { > return r; > } > > - return info.size; > + return s->image_size; > } > > static int coroutine_fn qemu_rbd_co_truncate(BlockDriverState *bs, > -- > 2.17.1 > > Reviewed-by: Ilya Dryomov Thanks, Ilya