From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AEFC2B9F4 for ; Sat, 19 Jun 2021 19:58:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3768E6113C for ; Sat, 19 Jun 2021 19:58:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3768E6113C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1luh7J-0005r7-4f for qemu-devel@archiver.kernel.org; Sat, 19 Jun 2021 15:58:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1luh6J-00052B-SC; Sat, 19 Jun 2021 15:57:55 -0400 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]:36638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1luh6I-00010s-Bz; Sat, 19 Jun 2021 15:57:55 -0400 Received: by mail-io1-xd2a.google.com with SMTP id s19so4448640ioc.3; Sat, 19 Jun 2021 12:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V3/jjb4F1LaMx82s9RlzjY49KcNpbM4CdJUAfohmWFg=; b=YzqlvA7ZAfSSQHwg1Q0vy/zEf9M7wwsa5V0SCqtOTEQC31pE1ad6Kp5wpwrMdgtZFr f1Y9tJy004OQMf8q52L1F35cWngiUgOR7w21DseDIRLeW1FNlVX0ak4xP1kz4hNMcrnj eDaNsB7RrCCBVDf5i0NQ0DSzlhI/Xs2hh8OfUcJnsvP38xvfu/vk7+310Qu6J+06rqwa zgqixMAGbiw8+Akcu501X2IauTT+atOJakHYEfW1v5vlsKMjOPNgFf6BB2uBwO4mLqnC QdEWJ5MrNzwTJjZJcgevv3Ar074VOKRRWM6yeK8K4LC9TJSvV4Qed6Tz88/sRNhp/l3J kwnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V3/jjb4F1LaMx82s9RlzjY49KcNpbM4CdJUAfohmWFg=; b=HsPwJArs5m/IjMKZG2xWuAz1irW3u3/pjcsdVOcZdbL2lLMg2powOYXeZVgLRr7nvj 0zixKpKbsm5jBj+Dkrt0YMrJMGYxfZ3jLHH7xkXa4odtaRCDeE2lr7S637OavFrWDvvQ Ogbd7Djg7TdUlRS18d3bvKChQt3m6Qr4PnLrMm4MFhxU47inHSyx8iLH+KBgffe/m8Oc BmjX3pp7cngyRerxkybE9JM1mRJzkf56BJv8gdwzNpUFdgtyS44me8ftq5MmJilPb0Rl pA823hagcM0LnS8+NOA2KfsPzGPp8RIinF198HBm8mFi5jLN9gPdlCL67TzgYnWMDeZM rY1Q== X-Gm-Message-State: AOAM531LIDb8U0h9rnm4qLQEzvXItHqtpGmV/otAFZzqIl2MENeeu3K1 e+5l1aBzFmOlvgVXbcXHREvSYvfg+ipSeEkmvJU= X-Google-Smtp-Source: ABdhPJzgOIqE/NWvaaqGuMVbb4Q7n9g1ymTvl/RKCa+3FV3FLx3wwxLiqqljzqRBdk6Sf773Lva3BC4IZrayJKp7gwg= X-Received: by 2002:a02:7f92:: with SMTP id r140mr5877041jac.51.1624132672922; Sat, 19 Jun 2021 12:57:52 -0700 (PDT) MIME-Version: 1.0 References: <20210519142359.23083-1-pl@kamp.de> <20210519142359.23083-4-pl@kamp.de> In-Reply-To: <20210519142359.23083-4-pl@kamp.de> From: Ilya Dryomov Date: Sat, 19 Jun 2021 21:57:42 +0200 Message-ID: Subject: Re: [PATCH V3 3/6] block/rbd: update s->image_size in qemu_rbd_getlength To: Peter Lieven Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::d2a; envelope-from=idryomov@gmail.com; helo=mail-io1-xd2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, berrange@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, ct@flyingcircus.io, Paolo Bonzini , mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, May 19, 2021 at 4:26 PM Peter Lieven wrote: > > in case the image size changed we should adjust our internally stored size as well. > > Signed-off-by: Peter Lieven > --- > block/rbd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/rbd.c b/block/rbd.c > index b4caea4f1b..97a2ae4c84 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -976,6 +976,7 @@ static int64_t qemu_rbd_getlength(BlockDriverState *bs) > return r; > } > > + s->image_size = info.size; > return info.size; Since you are touching this function might as well switch to rbd_get_size() to put size directly into s->image_size and return s->image_size, skipping rbd_image_info_t. Thanks, Ilya