From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932092AbdGJNR6 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 10 Jul 2017 09:17:58 -0400
Received: from mail-vk0-f47.google.com ([209.85.213.47]:34947 "EHLO
        mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753563AbdGJNR5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 10 Jul 2017 09:17:57 -0400
MIME-Version: 1.0
In-Reply-To: <20170710111734.856154-1-arnd@arndb.de>
References: <20170710111734.856154-1-arnd@arndb.de>
From: Ilya Dryomov <idryomov@gmail.com>
Date: Mon, 10 Jul 2017 15:17:55 +0200
Message-ID: <CAOi1vP_xde-57RUacagm=gr9Q5sXsw44DZPqbyKrKU4wmnoduw@mail.gmail.com>
Subject: Re: [PATCH] libceph: fix old style declaration warnings
To: Arnd Bergmann <arnd@arndb.de>
Cc: "Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
        Ceph Development <ceph-devel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 10, 2017 at 1:17 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The new macros don't follow the usual style for declarations,
> which we get a warning for with 'make W=1':
>
> In file included from fs/ceph/mds_client.c:16:0:
> include/linux/ceph/ceph_features.h:74:1: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
>
> This moves the 'static' keyword to the front of the
> declaration.
>
> Fixes: f179d3ba8cb9 ("libceph: new features macros")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

Thanks,

                Ilya