From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [RESEND PATCH v3 2/2] ARM64: dts: meson-axg: add pinctrl DT info for Meson-AXG SoC Date: Thu, 7 Dec 2017 07:52:52 -0800 Message-ID: References: <20171120102354.5354-1-yixun.lan@amlogic.com> <20171120102354.5354-3-yixun.lan@amlogic.com> <7htvx3r4o7.fsf@baylibre.com> <9d28dcdf-655b-a843-1f21-24ebb1f27be3@amlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <9d28dcdf-655b-a843-1f21-24ebb1f27be3@amlogic.com> Sender: linux-kernel-owner@vger.kernel.org To: Yixun Lan Cc: Rob Herring , Mark Rutland , Linus Walleij , Neil Armstrong , Jerome Brunet , Carlo Caione , Xingyu Chen , devicetree , linux-gpio@vger.kernel.org, linux-amlogic , linux-arm-kernel , lkml List-Id: linux-gpio@vger.kernel.org On Wed, Dec 6, 2017 at 5:44 PM, Yixun Lan wrote: > Hi Kevin > > > On 12/07/17 04:18, Kevin Hilman wrote: >> Yixun Lan writes: >> >>> From: Xingyu Chen >>> >>> Add new pinctrl DT info for the Amlogic's Meson-AXG SoC. >>> >>> Reviewed-by: Neil Armstrong >>> Signed-off-by: Xingyu Chen >>> Signed-off-by: Yixun Lan >>> --- >>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 44 ++++++++++++++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> index 5fc33b76b91c..e0fb860e12c5 100644 >>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> @@ -9,6 +9,7 @@ >>> #include >>> #include >>> #include >> >> This doesn't apply because this aoclkc.h header does not exist in >> mainline. >> >> Kevin >> > > this is due to I create the patch in serial sequence (first clk, then > pinctrl), I probably will fix my work flow next time - to rebase all the > patch separately on the -rc version > > but here, the pinctrl DT part has no dependency on DT clk patch.. > you could drop the above two #include and just apply the reset > > could you amend & apply this? or do you want me to send another updated > version? I prefer that you rebase (either on -rc or my v4.16/dt64 branch[1]) and resend. Thanks, Kevin [1] https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git/log/?h=v4.16/dt64 From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Thu, 7 Dec 2017 07:52:52 -0800 Subject: [RESEND PATCH v3 2/2] ARM64: dts: meson-axg: add pinctrl DT info for Meson-AXG SoC In-Reply-To: <9d28dcdf-655b-a843-1f21-24ebb1f27be3@amlogic.com> References: <20171120102354.5354-1-yixun.lan@amlogic.com> <20171120102354.5354-3-yixun.lan@amlogic.com> <7htvx3r4o7.fsf@baylibre.com> <9d28dcdf-655b-a843-1f21-24ebb1f27be3@amlogic.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 6, 2017 at 5:44 PM, Yixun Lan wrote: > Hi Kevin > > > On 12/07/17 04:18, Kevin Hilman wrote: >> Yixun Lan writes: >> >>> From: Xingyu Chen >>> >>> Add new pinctrl DT info for the Amlogic's Meson-AXG SoC. >>> >>> Reviewed-by: Neil Armstrong >>> Signed-off-by: Xingyu Chen >>> Signed-off-by: Yixun Lan >>> --- >>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 44 ++++++++++++++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> index 5fc33b76b91c..e0fb860e12c5 100644 >>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> @@ -9,6 +9,7 @@ >>> #include >>> #include >>> #include >> >> This doesn't apply because this aoclkc.h header does not exist in >> mainline. >> >> Kevin >> > > this is due to I create the patch in serial sequence (first clk, then > pinctrl), I probably will fix my work flow next time - to rebase all the > patch separately on the -rc version > > but here, the pinctrl DT part has no dependency on DT clk patch.. > you could drop the above two #include and just apply the reset > > could you amend & apply this? or do you want me to send another updated > version? I prefer that you rebase (either on -rc or my v4.16/dt64 branch[1]) and resend. Thanks, Kevin [1] https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git/log/?h=v4.16/dt64 From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@baylibre.com (Kevin Hilman) Date: Thu, 7 Dec 2017 07:52:52 -0800 Subject: [RESEND PATCH v3 2/2] ARM64: dts: meson-axg: add pinctrl DT info for Meson-AXG SoC In-Reply-To: <9d28dcdf-655b-a843-1f21-24ebb1f27be3@amlogic.com> References: <20171120102354.5354-1-yixun.lan@amlogic.com> <20171120102354.5354-3-yixun.lan@amlogic.com> <7htvx3r4o7.fsf@baylibre.com> <9d28dcdf-655b-a843-1f21-24ebb1f27be3@amlogic.com> Message-ID: To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On Wed, Dec 6, 2017 at 5:44 PM, Yixun Lan wrote: > Hi Kevin > > > On 12/07/17 04:18, Kevin Hilman wrote: >> Yixun Lan writes: >> >>> From: Xingyu Chen >>> >>> Add new pinctrl DT info for the Amlogic's Meson-AXG SoC. >>> >>> Reviewed-by: Neil Armstrong >>> Signed-off-by: Xingyu Chen >>> Signed-off-by: Yixun Lan >>> --- >>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 44 ++++++++++++++++++++++++++++++ >>> 1 file changed, 44 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> index 5fc33b76b91c..e0fb860e12c5 100644 >>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi >>> @@ -9,6 +9,7 @@ >>> #include >>> #include >>> #include >> >> This doesn't apply because this aoclkc.h header does not exist in >> mainline. >> >> Kevin >> > > this is due to I create the patch in serial sequence (first clk, then > pinctrl), I probably will fix my work flow next time - to rebase all the > patch separately on the -rc version > > but here, the pinctrl DT part has no dependency on DT clk patch.. > you could drop the above two #include and just apply the reset > > could you amend & apply this? or do you want me to send another updated > version? I prefer that you rebase (either on -rc or my v4.16/dt64 branch[1]) and resend. Thanks, Kevin [1] https://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git/log/?h=v4.16/dt64