From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C886CCCA485 for ; Wed, 20 Jul 2022 14:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236357AbiGTOyZ (ORCPT ); Wed, 20 Jul 2022 10:54:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240821AbiGTOyX (ORCPT ); Wed, 20 Jul 2022 10:54:23 -0400 Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 270431EC75 for ; Wed, 20 Jul 2022 07:54:22 -0700 (PDT) Received: by mail-ua1-x934.google.com with SMTP id y19so8100076ual.12 for ; Wed, 20 Jul 2022 07:54:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=pRW51Zf8RzoluaRIPps/fzsMK5pZhkAW4XFwEonLMvw=; b=WiGwoKDNAEyBaub3ALOhsOfd8V1Tgkza8OJMERydOJCmZ4SPBYWl5LIlQuX7ywfnCU I3Hb1Joyb660f//GWck9lPLxB2cxJ21o5u7Jl9xGBNS2XfCwAnqqk5yeMAvX9zidy+kr aj3zERckGzNiyDk8T86GBc9WFnCJE1J/4gbw5IptkgJxFeD9Om+//q50EwPi79jF/8AV /8YTLcPvpy6CuJBCoOBO633GITuR+2PhDilJCjeSA5oL3fxiAWbc1/9unROkF1IghZis XstU0yK8SK5yTNWfoLE3blCDa7QI4CNQ9AV5Kfi9r6dMcdRqqLfHN33BG6mLpoUN6rLE BJIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=pRW51Zf8RzoluaRIPps/fzsMK5pZhkAW4XFwEonLMvw=; b=tq4zVvzO0t+6ZVaLxZWTJMkjO81aacSXa3ga100iwBz6apQqsrKSEgr0qJ3Q9+cQZB 8OnKTxQceiOvFxOxlBZkc9zL/FiuFYGWWrjaNGg+PS7F8RTQymkq9muCsHnp49s8Jq7b SAtHrjy+mQdJ6Cqvpc21buTluuSYxYm0jVG3HFdHI4foBiGrsJ/tw8UhuY7FK/lIigLa kuxcQHYGrJ2NhXLuPCaJcQvL7nHH7//rCPPCNAcjDEqaNeYElDIz7Yft0bmBEwguvjHy 4nB2p2jaPkN39p/BGRTV4maLwrsEN9rr0tw7+eyHdf1XTz1ad3F0JPGOpgaWzGHeS9Zn Pq/Q== X-Gm-Message-State: AJIora+0SIgMjNrHVdzAVR330x6eaXeAnxt8LIIqfyIg4BGNUdDtLAl9 j6tzJr39BRQXYf5DCvwFHiFYyoqUtRKkIOKoWCRBdg== X-Google-Smtp-Source: AGRyM1tMJIlVh+piYAR1gu3liiD2a2yD06tL01sT5b1NlAk+YutcH6h+FoabXhj/fEmuMGA7cgOG6qNwc9qAH5EJN18= X-Received: by 2002:ab0:215a:0:b0:382:c57:ee13 with SMTP id t26-20020ab0215a000000b003820c57ee13mr14287948ual.68.1658328860989; Wed, 20 Jul 2022 07:54:20 -0700 (PDT) MIME-Version: 1.0 References: <20220607025729.1673212-1-mfaltesek@google.com> In-Reply-To: From: Martin Faltesek Date: Wed, 20 Jul 2022 08:53:44 -0600 Message-ID: Subject: Re: [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3 To: Denis Efremov Cc: Jakub Kicinski , Krzysztof Kozlowski , christophe.ricard@gmail.com, Greg Kroah-Hartman , Guenter Roeck , jordy@pwning.systems, krzk@kernel.org, Martin Faltesek , netdev@vger.kernel.org, linux-nfc@lists.01.org, sameo@linux.intel.com, William K Lin , theflamefire89@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jul 20, 2022 at 1:25 AM Denis Efremov wrote: > > Hi, > > On 6/7/22 06:57, Martin Faltesek wrote: > > > > Martin Faltesek (3): > > nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION > > nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling > > nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION > > > > drivers/nfc/st21nfca/se.c | 53 ++++++++++++++++++++++----------------- > > 1 file changed, 30 insertions(+), 23 deletions(-) > > > It looks like driver st-nci contains the same problems and all 3 fixes are > also applicable to st_nci_hci_connectivity_event_received() function. > At least I can see the memory leak > https://elixir.bootlin.com/linux/v5.19-rc7/source/drivers/nfc/st-nci/se.c#L343 > > Can you please double check the st-nci driver and send the same fixes to it? > Reported-by: Denis Efremov Will do. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FA25CCA480 for ; Wed, 20 Jul 2022 14:54:26 +0000 (UTC) Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 84ADD100EAB7E; Wed, 20 Jul 2022 07:54:25 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::92b; helo=mail-ua1-x92b.google.com; envelope-from=mfaltesek@google.com; receiver= Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0232B100EB349 for ; Wed, 20 Jul 2022 07:54:22 -0700 (PDT) Received: by mail-ua1-x92b.google.com with SMTP id l7so8096925ual.9 for ; Wed, 20 Jul 2022 07:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=pRW51Zf8RzoluaRIPps/fzsMK5pZhkAW4XFwEonLMvw=; b=WiGwoKDNAEyBaub3ALOhsOfd8V1Tgkza8OJMERydOJCmZ4SPBYWl5LIlQuX7ywfnCU I3Hb1Joyb660f//GWck9lPLxB2cxJ21o5u7Jl9xGBNS2XfCwAnqqk5yeMAvX9zidy+kr aj3zERckGzNiyDk8T86GBc9WFnCJE1J/4gbw5IptkgJxFeD9Om+//q50EwPi79jF/8AV /8YTLcPvpy6CuJBCoOBO633GITuR+2PhDilJCjeSA5oL3fxiAWbc1/9unROkF1IghZis XstU0yK8SK5yTNWfoLE3blCDa7QI4CNQ9AV5Kfi9r6dMcdRqqLfHN33BG6mLpoUN6rLE BJIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=pRW51Zf8RzoluaRIPps/fzsMK5pZhkAW4XFwEonLMvw=; b=P+LFkD/8BOkllnmyn7YnazBXM8jQVVNdQ5I1ImCm2DByYMqM6VyIPlqJrKFL5frCde d1oxfpiUiMaeyuDwOYPWtsYEwVuUJFKfjsHTYIwltZqfAlMq6/J9vt9dkpJ1EF/cSu72 YOQGxpII2J2PAXxrKrIiqmYiYeVzYGC1HNuqI0/rBngF+fsWXVReFAFpExWJmTJaHMeF Idr8jrmZC2C8stFHLn5eVAEp0QBXilj7CiY166/9vU20ZGUSX8rxqUqjYvv69Wv+oxk+ robJWAhckatXA8LKKlfl6glV9TMD04ImaEaFNKdLiucjP2SFupQ32H+f9r3D9KtpQO04 BO2g== X-Gm-Message-State: AJIora+XrB7u5lKF4JUeOv39oJICnQLCHrUy8GGFR+4nWT/XRJRcQ64O DueoIcLMouik2m5ckkdC5acnRWWF2YnOPN+90ivYQg== X-Google-Smtp-Source: AGRyM1tMJIlVh+piYAR1gu3liiD2a2yD06tL01sT5b1NlAk+YutcH6h+FoabXhj/fEmuMGA7cgOG6qNwc9qAH5EJN18= X-Received: by 2002:ab0:215a:0:b0:382:c57:ee13 with SMTP id t26-20020ab0215a000000b003820c57ee13mr14287948ual.68.1658328860989; Wed, 20 Jul 2022 07:54:20 -0700 (PDT) MIME-Version: 1.0 References: <20220607025729.1673212-1-mfaltesek@google.com> In-Reply-To: From: Martin Faltesek Date: Wed, 20 Jul 2022 08:53:44 -0600 Message-ID: To: Denis Efremov Message-ID-Hash: LJFMNIBXWKJBVCY7TWB5FYAYFRS3ESKX X-Message-ID-Hash: LJFMNIBXWKJBVCY7TWB5FYAYFRS3ESKX X-MailFrom: mfaltesek@google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Jakub Kicinski , Krzysztof Kozlowski , christophe.ricard@gmail.com, Greg Kroah-Hartman , Guenter Roeck , jordy@pwning.systems, krzk@kernel.org, Martin Faltesek , netdev@vger.kernel.org, linux-nfc@lists.01.org, William K Lin , theflamefire89@gmail.com X-Mailman-Version: 3.1.1 Precedence: list Subject: [linux-nfc] Re: [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3 List-Id: NFC on Linux Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Jul 20, 2022 at 1:25 AM Denis Efremov wrote: > > Hi, > > On 6/7/22 06:57, Martin Faltesek wrote: > > > > Martin Faltesek (3): > > nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION > > nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling > > nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION > > > > drivers/nfc/st21nfca/se.c | 53 ++++++++++++++++++++++----------------- > > 1 file changed, 30 insertions(+), 23 deletions(-) > > > It looks like driver st-nci contains the same problems and all 3 fixes are > also applicable to st_nci_hci_connectivity_event_received() function. > At least I can see the memory leak > https://elixir.bootlin.com/linux/v5.19-rc7/source/drivers/nfc/st-nci/se.c#L343 > > Can you please double check the st-nci driver and send the same fixes to it? > Reported-by: Denis Efremov Will do. _______________________________________________ Linux-nfc mailing list -- linux-nfc@lists.01.org To unsubscribe send an email to linux-nfc-leave@lists.01.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8363238811109889452==" MIME-Version: 1.0 From: Martin Faltesek To: linux-nfc@lists.01.org Subject: Re: [PATCH net v3 0/3] Split "nfc: st21nfca: Refactor EVT_TRANSACTION" into 3 Date: Wed, 20 Jul 2022 08:53:44 -0600 Message-ID: In-Reply-To: List-Id: --===============8363238811109889452== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Jul 20, 2022 at 1:25 AM Denis Efremov wrote: > > Hi, > > On 6/7/22 06:57, Martin Faltesek wrote: > > > > Martin Faltesek (3): > > nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION > > nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling > > nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION > > > > drivers/nfc/st21nfca/se.c | 53 ++++++++++++++++++++++----------------- > > 1 file changed, 30 insertions(+), 23 deletions(-) > > > It looks like driver st-nci contains the same problems and all 3 fixes are > also applicable to st_nci_hci_connectivity_event_received() function. > At least I can see the memory leak > https://elixir.bootlin.com/linux/v5.19-rc7/source/drivers/nfc/st-nci/se.c= #L343 > > Can you please double check the st-nci driver and send the same fixes to = it? > Reported-by: Denis Efremov Will do. --===============8363238811109889452==--