Re: [PATCH 4/5] tests/shell: add tests for handles and comments

[Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>]

> diff --git a/tests/shell/testcases/optionals/comments_handles_monitor_0 b/tests/shell/testcases/optionals/comments_handles_monitor_0
> new file mode 100755
> index 0000000..f1e2004
> --- /dev/null
> +++ b/tests/shell/testcases/optionals/comments_handles_monitor_0
> @@ -0,0 +1,29 @@
> +#!/bin/bash
> +
> +# handles and comments mix well in monitor
> +
> +MKTEMP=$(which mktemp)
> +if [ -x $MKTEMP ] ; then
> +       tmpfile=$(${MKTEMP})
> +else
> +       tmpfile=$(/tmp/${RANDOM})
> +fi
> +
> +if [ ! -w $tmpfile ] ; then
> +       echo "Failed to create tmp file" >&2
> +       exit 0
> +fi
> +
> +trap "rm -rf $tmpfile" EXIT # cleanup if aborted
> +
> +set -e
> +
> +$NFT add table test
> +$NFT add chain test test
> +$NFT monitor -a > $tmpfile &
> +$NFT add rule test test tcp dport 22 counter accept comment test_comment
> +# race :-(
> +sleep 1
> +kill $!
> +grep 'accept comment \"test_comment\" # handle '[[:digit:]]$ $tmpfile >/dev/null
> +rm -rf $tmpfile

This testcase is so bad designed, we should not include it now. Or fix it later.

-- 
Arturo Borrero González
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html