From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Schmitz Subject: Re: [PATCH 1/4] m68k/atari - stram: alloc ST-RAM pool even if kernel not in ST-RAM Date: Mon, 31 Mar 2014 14:58:55 +1300 Message-ID: References: <1396137686-32678-1-git-send-email-schmitz@debian.org> <1396137686-32678-2-git-send-email-schmitz@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-oa0-f45.google.com ([209.85.219.45]:46775 "EHLO mail-oa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbaCaB6z (ORCPT ); Sun, 30 Mar 2014 21:58:55 -0400 Received: by mail-oa0-f45.google.com with SMTP id eb12so8595207oac.18 for ; Sun, 30 Mar 2014 18:58:55 -0700 (PDT) In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org List-Id: linux-m68k@vger.kernel.org To: Geert Uytterhoeven Cc: Linux/m68k , Debian m68k , Michael Schmitz Hi Geert, will do. Likewise for the external framebuffer case. I'm still hung up on the SCSI behaviour with current kernels - may have managed to trash the SCSI disk filesystems or partitions with an earlier version of these patches. Cheers, Michael On Mon, Mar 31, 2014 at 8:11 AM, Geert Uytterhoeven wrote: > Hi Michael, > > On Sun, Mar 30, 2014 at 1:01 AM, Michael Schmitz wrote: >> + pr_debug("atari_stram pool: size = %lu bytes, resource = %pR\n", >> + pool_size, &stram_pool); >> + pr_debug("atari_stram pool: start = %p, end = %p\n", >> + (void *) stram_pool.start, (void *) stram_pool.end); > > Please drop this line, as it prints more or less the same as the %pR in the > line above. Also in the other block. > >> + pr_debug("atari_stram pool: stram_virt_offset = %p\n", >> + (void *) stram_virt_offset); > > Please use "%lx", and drop the cast to "void *". Also in the other block. > > Thanks! > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds