From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Schmitz Subject: Re: [PATCH v3 00/10] New network driver for Amiga X-Surf 100 (m68k) Date: Thu, 19 Apr 2018 09:26:09 +1200 Message-ID: References: <1523930895-6973-1-git-send-email-schmitzmic@gmail.com> <1524025616-3722-1-git-send-email-schmitzmic@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: netdev , Andrew Lunn , Geert Uytterhoeven , Florian Fainelli , "Linux/m68k" , Michael Karcher To: Finn Thain Return-path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:43558 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbeDRV0K (ORCPT ); Wed, 18 Apr 2018 17:26:10 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hi Finn, thanks for the feedback! On Wed, Apr 18, 2018 at 5:45 PM, Finn Thain wrote: >> > 1/9 net: phy: new Asix Electronics PHY driver >> > 2/9 net: ax88796: Fix MAC address reading >> > 3/9 net: ax88796: Attach MII bus only when open >> > 4/9 net: ax88796: Do not free IRQ in ax_remove() (already freed in ax_close()). >> > 5/9 net: ax88796: Add block_input/output hooks to ax_plat_data > > I found that git am rejects this one, though 'patch' applies it with fuzz. Can't remember seeing anything there when rebasing the series, odd. > >> > 6/9 net: ax88796: add interrupt status callback to platform data >> > 7/9 net: ax88796: set IRQF_SHARED flag when IRQ resource is marked as shareable >> > 8/9 net: ax88796: release platform device drvdata on probe error and module remove >> > 9/9 net: New ax88796 platform driver for Amiga X-Surf 100 Zorro board (m68k) > > git am rejected this one and also complained about trailing whitespace. > > I'd rebase on v4.17-rc1 and also run checkpatch over the results. Done that now, thanks. Andrew recommended basing my patches on net-next so I'll do that before resubmitting. Cheers, Michael > -- > >> > >> > drivers/net/ethernet/8390/Kconfig | 17 ++- >> > drivers/net/ethernet/8390/Makefile | 1 + >> > drivers/net/ethernet/8390/ax88796.c | 228 ++++++++++++-------- >> > drivers/net/ethernet/8390/xsurf100.c | 381 ++++++++++++++++++++++++++++++++++ >> > drivers/net/phy/Kconfig | 6 + >> > drivers/net/phy/Makefile | 1 + >> > drivers/net/phy/asix.c | 65 ++++++ >> > drivers/net/phy/phy_device.c | 3 +- >> > include/linux/phy.h | 1 + >> > include/net/ax88796.h | 14 ++ >> > 10 files changed, 621 insertions(+), 96 deletions(-) >> > >> > Cheers, >> > >> > Michael