All of lore.kernel.org
 help / color / mirror / Atom feed
From: Atish Patra <atishp@atishpatra.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
	Alistair Francis <Alistair.Francis@wdc.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
	"linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>,
	Anup Patel <Anup.Patel@wdc.com>,
	"kernel-team@android.com" <kernel-team@android.com>,
	Palmer Dabbelt <palmerdabbelt@google.com>
Subject: Re: [PATCH] RISC-V: Resurrect the MMIO timer implementation for M-mode systems
Date: Mon, 26 Oct 2020 21:12:25 -0700	[thread overview]
Message-ID: <CAOnJCUK5C9gGUu0UEtu5Q7dzus1kwr1bCMFxQPF67kcyCk3tnw@mail.gmail.com> (raw)
In-Reply-To: <CY4PR04MB37514B8FF89DEFDF2A7622C0E7200@CY4PR04MB3751.namprd04.prod.outlook.com>

On Tue, Sep 15, 2020 at 12:02 AM Damien Le Moal <Damien.LeMoal@wdc.com> wrote:
>
> On 2020/09/15 15:51, hch@infradead.org wrote:
> > On Tue, Sep 15, 2020 at 06:50:24AM +0000, Damien Le Moal wrote:
> >> On 2020/09/15 14:47, Christoph Hellwig wrote:
> >>> I won't have time to set up the K210, but this fixes the timer issues
> >>> on older Qemu versions that don't implement the time CSR.  Although I
> >>> also need to revert the binfmt_flat patch to actually get to userspace.
> >>
> >> So revert is needed ? Digging in the flatbin format, I do not see why the offset
> >> you removed would be needed, and it does not seem to affect other arch anyway.
> >> So I am really suspecting a problem with riscv uclibcb or elf2flt, but can't
> >> quite yet figure out what may be wrong there.
> >
> > I did not have time to find out if what we did in RISC-V nommu was
> > correct or wrong.  But to get my existing userspace to work I had to
> > revert the revert.  I'll try to find some time to dig into the binfmt
> > flat issue and elf2flt soon.
>
> OK. Thanks. I will keep digging too when I have time.
>

Is there a solution to this ? As Christoph pointed out, we need to
revert the revert to get into user space for nommu kernel (v5.9 or
v5.10-rc1).
This commit was introduced between 5.9-rc2 & 5.9-rc3.

The concerned commit here is:
2217b982624680d19a80ebb4600d05c8586c4f96: binfmt_flat: revert
"binfmt_flat: don't offset the data start"

>
>
> --
> Damien Le Moal
> Western Digital Research
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv



-- 
Regards,
Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2020-10-27  4:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 16:56 [PATCH] RISC-V: Resurrect the MMIO timer implementation for M-mode systems Palmer Dabbelt
2020-09-14 17:22 ` Mohammed Billoo
2020-09-15  3:06   ` Palmer Dabbelt
2020-09-15  5:10   ` Damien Le Moal
2020-09-15  2:11 ` Anup Patel
2020-09-19  2:54   ` Palmer Dabbelt
2020-09-19  3:32     ` Anup Patel
2020-09-19  4:36       ` Palmer Dabbelt
2020-09-19  4:54         ` Anup Patel
2020-09-15  5:08 ` Damien Le Moal
2020-09-15  5:46 ` Christoph Hellwig
2020-09-15  6:50   ` Damien Le Moal
2020-09-15  6:51     ` hch
2020-09-15  7:01       ` Damien Le Moal
2020-10-27  4:12         ` Atish Patra [this message]
2020-10-27  4:25           ` Damien Le Moal
2020-09-15  8:25 ` Damien Le Moal
2020-09-15  8:39   ` Damien Le Moal
2020-09-15 12:56 ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOnJCUK5C9gGUu0UEtu5Q7dzus1kwr1bCMFxQPF67kcyCk3tnw@mail.gmail.com \
    --to=atishp@atishpatra.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=Anup.Patel@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=hch@infradead.org \
    --cc=kernel-team@android.com \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmerdabbelt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.