From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3EFBC49EA5 for ; Fri, 25 Jun 2021 01:13:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3D736137D for ; Fri, 25 Jun 2021 01:13:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232952AbhFYBQB (ORCPT ); Thu, 24 Jun 2021 21:16:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhFYBQA (ORCPT ); Thu, 24 Jun 2021 21:16:00 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EF63C061574 for ; Thu, 24 Jun 2021 18:13:39 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id b13so2184159ybk.4 for ; Thu, 24 Jun 2021 18:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atishpatra.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0qxPupN9xX/MROlm0ElwGrjb5EkmD1HQYEar67dhfI=; b=hwkuEQ2r8MR2kHEr6g1h2AShp6uH/l/GCyQbl49/Gewht8ybadsKlpismJSo/PWUnB TaNHucid+KA7ArBKvpXzshBRDuNCDpoEan4pE4q9e/6FsBHRAdRjs/KULZUQI1xTEmmO 6IoQ6crJ2WFxWajWoRZ/1X17b0Va0/s9oyeqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0qxPupN9xX/MROlm0ElwGrjb5EkmD1HQYEar67dhfI=; b=sKuy1QSjtcGBU2YYQbf7mIpx5io1Yyv5r23V9G0O6tkJcbqyGb/zx/QY8XaAVwXuHy TZYpM8qFvhf8rlmJSs/nhz0v9mu+4IDQBK69IQ3FH9wE13Lnx8oyDFXJa492D2N2fRXF w3jH1Xm4LLyN/zUt/iUmZd7ixPja1i19FR3v7n4SrEV+FSyTOwOivV6CKbA5AXAt6g72 XYGk1S5QG6clKw4hnZXRBn32txGhi2cffQM7DCCFbDb3/0AvcsvWYYiIAY3CuX2/ObhY xocRwePQNXmCChWwR5bGSJJ2LONH/SYORJwaERz7KLljJKJJyQ5GvZR1MDUtJqvqAwt6 sHMw== X-Gm-Message-State: AOAM5304Di+vDW/pUbz4vHDoA31XQ5dNA0XdtWUd4WITfhEqA3aTs2xW bknzjRG9EXL0HHRxXJi5rh7acwikm5L4uQrqRm7l X-Google-Smtp-Source: ABdhPJzoBF4yGGMmhwSDKtModRaqahZE7MGrEAmJq3wCwKyrjPsk2UTSEtdsH614PTd6ptQ4SfJ/oZ3iXkBzsnxKchs= X-Received: by 2002:a25:3bcb:: with SMTP id i194mr8486526yba.442.1624583618557; Thu, 24 Jun 2021 18:13:38 -0700 (PDT) MIME-Version: 1.0 References: <20210624120041.2786419-1-alex@ghiti.fr> <20210624120041.2786419-2-alex@ghiti.fr> In-Reply-To: <20210624120041.2786419-2-alex@ghiti.fr> From: Atish Patra Date: Thu, 24 Jun 2021 18:13:27 -0700 Message-ID: Subject: Re: [PATCH v8 1/2] riscv: Introduce set_kernel_memory helper To: Alexandre Ghiti Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Christoph Hellwig , Zong Li , Anup Patel , linux-riscv , "linux-kernel@vger.kernel.org List" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 5:02 AM Alexandre Ghiti wrote: > > This helper should be used for setting permissions to the kernel > mapping as it takes pointers as arguments and then avoids explicit cast > to unsigned long needed for the set_memory_* API. > > Suggested-by: Christoph Hellwig > Signed-off-by: Alexandre Ghiti > Reviewed-by: Anup Patel > --- > arch/riscv/include/asm/set_memory.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/riscv/include/asm/set_memory.h b/arch/riscv/include/asm/set_memory.h > index 9d4d455726d4..96e317dcab13 100644 > --- a/arch/riscv/include/asm/set_memory.h > +++ b/arch/riscv/include/asm/set_memory.h > @@ -17,6 +17,16 @@ int set_memory_x(unsigned long addr, int numpages); > int set_memory_nx(unsigned long addr, int numpages); > int set_memory_rw_nx(unsigned long addr, int numpages); > void protect_kernel_text_data(void); > +static __always_inline int set_kernel_memory(char *startp, char *endp, > + int (*set_memory)(unsigned long start, > + int num_pages)) > +{ > + unsigned long start = (unsigned long)startp; > + unsigned long end = (unsigned long)endp; > + int num_pages = PAGE_ALIGN(end - start) >> PAGE_SHIFT; > + > + return set_memory(start, num_pages); > +} > #else > static inline int set_memory_ro(unsigned long addr, int numpages) { return 0; } > static inline int set_memory_rw(unsigned long addr, int numpages) { return 0; } > @@ -24,6 +34,12 @@ static inline int set_memory_x(unsigned long addr, int numpages) { return 0; } > static inline int set_memory_nx(unsigned long addr, int numpages) { return 0; } > static inline void protect_kernel_text_data(void) {} > static inline int set_memory_rw_nx(unsigned long addr, int numpages) { return 0; } > +static inline int set_kernel_memory(char *startp, char *endp, > + int (*set_memory)(unsigned long start, > + int num_pages)) > +{ > + return 0; > +} > #endif > > #if defined(CONFIG_64BIT) && defined(CONFIG_STRICT_KERNEL_RWX) > -- > 2.30.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv Reviewed-by: Atish Patra -- Regards, Atish From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C054C49EA6 for ; Fri, 25 Jun 2021 01:13:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07C3A6137D for ; Fri, 25 Jun 2021 01:13:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07C3A6137D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atishpatra.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VjDpCGOAT6UxkRD2r4LtAWvyFSfUsAMuxFQfVFYUaRA=; b=mnsXv3m6ErhiT0 PdHkxHG9mQK4o/z2rpxEDjh5o0HIQhfBjKaDb4khmPq7hr58vbMmZsFbgJpZcriq9cxnRemNrQ7uj F1M3DtTOhmWD6SeG25jEhvNagcYdnFiJUUQkmP/VB+U7cXKdw6bnA90iIRFhLvDloFUleKI1k4Ezd 4EjuZJKdB2FvJqJbOrNrE8dnXlwWjpKWn1N7OEZ+EA5QFjfn2BVnBs+5ywIYuPbPzFouXo+MRint2 8G4JGoJyB9iZI1cCBtZ2xsvmMUq7QdHXgoZgLBBZWCpUAd/F8JQY8fOhdQDYeTgvniYWmeYY+y/qP UHn55lW7w/YEyPINAn1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwaPf-00Gz19-S4; Fri, 25 Jun 2021 01:13:43 +0000 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwaPc-00Gyzp-AJ for linux-riscv@lists.infradead.org; Fri, 25 Jun 2021 01:13:42 +0000 Received: by mail-yb1-xb2e.google.com with SMTP id m9so2173743ybo.5 for ; Thu, 24 Jun 2021 18:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atishpatra.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0qxPupN9xX/MROlm0ElwGrjb5EkmD1HQYEar67dhfI=; b=hwkuEQ2r8MR2kHEr6g1h2AShp6uH/l/GCyQbl49/Gewht8ybadsKlpismJSo/PWUnB TaNHucid+KA7ArBKvpXzshBRDuNCDpoEan4pE4q9e/6FsBHRAdRjs/KULZUQI1xTEmmO 6IoQ6crJ2WFxWajWoRZ/1X17b0Va0/s9oyeqg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0qxPupN9xX/MROlm0ElwGrjb5EkmD1HQYEar67dhfI=; b=fhDdG15zFmsiRQexO+tFBxgwkOkonTqTptIgq+bZdiNzTPfc7jjhqMiTVVI/xb8T+6 hrcygto5TLHXL2StcpPBMVDhunLCRz1FRYCfgfEUBj4rOsTVRZ699FVhx5mlVblqT25H 9rsKSmYQNGrpN8Zf73cImRDpLxzm9lY9SAXnQh2Wl9Alz/raZlezOeG2xMNtww1kYhXk k2vwDWgmjLZltBAdytXloY1KB4c2ryh/M9uj4MwhgSt8nVXRcQLPdarTKxTmoEFaImCP HcCTY7ITWKyR4w9SH8NUjjbSI/UC4Zn4foTLxowaRhuN485kYEItxKIXNNsCjot5XBF7 BKzA== X-Gm-Message-State: AOAM532G7pkzNNfVdbskEtRVx+8B9QFfHYxImSfOg0xx1lM301zqENy2 kUChcExfDqqYg0rv4pESfcbvZIOAyb1MmjbFoBul X-Google-Smtp-Source: ABdhPJzoBF4yGGMmhwSDKtModRaqahZE7MGrEAmJq3wCwKyrjPsk2UTSEtdsH614PTd6ptQ4SfJ/oZ3iXkBzsnxKchs= X-Received: by 2002:a25:3bcb:: with SMTP id i194mr8486526yba.442.1624583618557; Thu, 24 Jun 2021 18:13:38 -0700 (PDT) MIME-Version: 1.0 References: <20210624120041.2786419-1-alex@ghiti.fr> <20210624120041.2786419-2-alex@ghiti.fr> In-Reply-To: <20210624120041.2786419-2-alex@ghiti.fr> From: Atish Patra Date: Thu, 24 Jun 2021 18:13:27 -0700 Message-ID: Subject: Re: [PATCH v8 1/2] riscv: Introduce set_kernel_memory helper To: Alexandre Ghiti Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Jisheng Zhang , Christoph Hellwig , Zong Li , Anup Patel , linux-riscv , "linux-kernel@vger.kernel.org List" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_181340_462208_A87C24B5 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, Jun 24, 2021 at 5:02 AM Alexandre Ghiti wrote: > > This helper should be used for setting permissions to the kernel > mapping as it takes pointers as arguments and then avoids explicit cast > to unsigned long needed for the set_memory_* API. > > Suggested-by: Christoph Hellwig > Signed-off-by: Alexandre Ghiti > Reviewed-by: Anup Patel > --- > arch/riscv/include/asm/set_memory.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/riscv/include/asm/set_memory.h b/arch/riscv/include/asm/set_memory.h > index 9d4d455726d4..96e317dcab13 100644 > --- a/arch/riscv/include/asm/set_memory.h > +++ b/arch/riscv/include/asm/set_memory.h > @@ -17,6 +17,16 @@ int set_memory_x(unsigned long addr, int numpages); > int set_memory_nx(unsigned long addr, int numpages); > int set_memory_rw_nx(unsigned long addr, int numpages); > void protect_kernel_text_data(void); > +static __always_inline int set_kernel_memory(char *startp, char *endp, > + int (*set_memory)(unsigned long start, > + int num_pages)) > +{ > + unsigned long start = (unsigned long)startp; > + unsigned long end = (unsigned long)endp; > + int num_pages = PAGE_ALIGN(end - start) >> PAGE_SHIFT; > + > + return set_memory(start, num_pages); > +} > #else > static inline int set_memory_ro(unsigned long addr, int numpages) { return 0; } > static inline int set_memory_rw(unsigned long addr, int numpages) { return 0; } > @@ -24,6 +34,12 @@ static inline int set_memory_x(unsigned long addr, int numpages) { return 0; } > static inline int set_memory_nx(unsigned long addr, int numpages) { return 0; } > static inline void protect_kernel_text_data(void) {} > static inline int set_memory_rw_nx(unsigned long addr, int numpages) { return 0; } > +static inline int set_kernel_memory(char *startp, char *endp, > + int (*set_memory)(unsigned long start, > + int num_pages)) > +{ > + return 0; > +} > #endif > > #if defined(CONFIG_64BIT) && defined(CONFIG_STRICT_KERNEL_RWX) > -- > 2.30.2 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv Reviewed-by: Atish Patra -- Regards, Atish _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv