From: Andrew Zaborowski <andrew.zaborowski@intel.com>
To: ell@lists.01.org
Subject: Re: [PATCH 6/8] tls: Validate peer certificate's DNSNames against mask
Date: Sat, 24 Aug 2019 01:50:39 +0200 [thread overview]
Message-ID: <CAOq732+cuHcfxDGOKQ=zT-BPXgOU=BgJpYxhUiNUYxAWiQEiaw@mail.gmail.com> (raw)
In-Reply-To: <7c7c5ed7-d5b4-ca16-641e-4d8b05659f7d@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]
Hi Denis,
On Fri, 23 Aug 2019 at 23:54, Denis Kenzior <denkenz@gmail.com> wrote:
> On 8/23/19 12:51 PM, Andrew Zaborowski wrote:
> > On Fri, 23 Aug 2019 at 18:00, Denis Kenzior <denkenz@gmail.com> wrote:
> >> On 8/22/19 7:41 PM, Andrew Zaborowski wrote:
> >>> - if (!cn)
> >>> + if (cn)
> >>> + for (i = mask; *i; i++)
> >>> + if (tls_domain_match_mask(cn, cn_len, *i, strlen(*i)))
> >>> + return true;
> >>> +
> >>> + /*
> >>> + * Locate SubjectAltName (RFC5280 Section 4.2.1.6) and descend into
> >>> + * the sole SEQUENCE element, check if any DNSName matches.
> >>> + */
> >>
> >> So I think the recommended approach is to check all SubjectAltName
> >> dNSName tags first. And only then try to match the CN, no?
> >
> > Maybe more optimal, so I can switch this around, although as far as
> > I've seen in HTTPS certificates the server name is usually right in
> > the CN. The return value is going to be the same independent of the
> > order in which we do the checks.
>
> Yes, I think you're right that the check order doesn't really matter in
> the end. I'm just thinking the code would be more readable doing it in
> the order that the the spec wants. You can quote the Hotspot spec if
> need-be.
Ok, will do.
Best regards
next prev parent reply other threads:[~2019-08-23 23:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 0:41 [PATCH 1/8] tls: Implement l_tls_set_domain_mask Andrew Zaborowski
2019-08-23 0:41 ` [PATCH 2/8] unit: Add l_tls_set_domain_mask tests Andrew Zaborowski
2019-08-23 0:41 ` [PATCH 3/8] asn1-private: Handle Context-specific tag class Andrew Zaborowski
2019-08-23 0:41 ` [PATCH 4/8] cert: Implement l_cert_get_extension Andrew Zaborowski
2019-08-23 0:41 ` [PATCH 5/8] strv: Implement l_strv_copy Andrew Zaborowski
2019-08-23 14:16 ` Denis Kenzior
2019-08-23 0:41 ` [PATCH 6/8] tls: Validate peer certificate's DNSNames against mask Andrew Zaborowski
2019-08-23 14:27 ` Denis Kenzior
2019-08-23 17:51 ` Andrew Zaborowski
2019-08-23 20:21 ` Denis Kenzior
2019-08-23 23:50 ` Andrew Zaborowski [this message]
2019-08-23 0:41 ` [PATCH 7/8] build: Add DNSNames to the test server cert Andrew Zaborowski
2019-08-23 14:29 ` Denis Kenzior
2019-08-23 0:41 ` [PATCH 8/8] unit: Add TLS tests for cert's DNSName matching Andrew Zaborowski
2019-08-23 14:28 ` [PATCH 1/8] tls: Implement l_tls_set_domain_mask Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOq732+cuHcfxDGOKQ=zT-BPXgOU=BgJpYxhUiNUYxAWiQEiaw@mail.gmail.com' \
--to=andrew.zaborowski@intel.com \
--cc=ell@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.