All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrzej Zaborowski <andrew.zaborowski@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH v3 3/4] crypto: akcipher: add akcipher declarations useful for templates.
Date: Tue, 24 Nov 2015 21:54:57 +0100	[thread overview]
Message-ID: <CAOq732LT4JoBzHv3Jd=ZXzWkU+LMc1Zmqv4WvM4K4X5LRps3ow@mail.gmail.com> (raw)
In-Reply-To: <20151124095408.GA315@gondor.apana.org.au>

On 24 November 2015 at 10:54, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Andrew Zaborowski <andrew.zaborowski@intel.com> wrote:
>> Expose crypto_akcipher_type like other crypto types are exposed to be
>> used from outside akcipher.c.  Add a struct akcipher_instance similar to
>> aead_instance with just the right size for an akcipher template
>> instance, and two macros for converting to/from crypto_instance.
>
> You're still doing some things in the old way.  With new templates,
> you shouldn't need to export the crypto type at all.  Please look
> at how AEAD does it.

It doesn't need to export crypto_aead_type but instead needs to export
crypto_aead_grab and aead_register_instance.  I'll add those for
akcipher and resend then.  Would there be any point defining a
crypto_akcipher_spawn following the AEAD pattern?

Best regards

  reply	other threads:[~2015-11-24 20:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20  3:13 [PATCH v3 1/4] lib/mpi: only require buffers as big as needed for the integer Andrew Zaborowski
2015-11-20  3:13 ` [PATCH v3 2/4] crypto: rsa: only require output buffers as big as needed Andrew Zaborowski
2015-11-20  3:13 ` [PATCH v3 3/4] crypto: akcipher: add akcipher declarations useful for templates Andrew Zaborowski
2015-11-24  9:54   ` Herbert Xu
2015-11-24 20:54     ` Andrzej Zaborowski [this message]
2015-11-25  1:18       ` Herbert Xu
2015-11-20  3:13 ` [PATCH 4/4] crypto: RSA padding algorithm Andrew Zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOq732LT4JoBzHv3Jd=ZXzWkU+LMc1Zmqv4WvM4K4X5LRps3ow@mail.gmail.com' \
    --to=andrew.zaborowski@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.