From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pravin Shelar <pshelar@ovn.org>
Subject: Re: [PATCHv6 net-next 1/3] net: erspan: use bitfield instead of mask
 and offset
Date: Thu, 25 Jan 2018 18:35:50 -0800
Message-ID: <CAOrHB_A=9Z=7_mUubQqDu-FVbN+aRd=3zC7wEPLnkFmoHAK0Wg@mail.gmail.com>
References: <1516915211-5869-1-git-send-email-u9012063@gmail.com> <1516915211-5869-2-git-send-email-u9012063@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
To: William Tu <u9012063@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48252 "EHLO
        relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751552AbeAZCfw (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 25 Jan 2018 21:35:52 -0500
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
        (Authenticated sender: pshelar@ovn.org)
        by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id B1E6D17209D
        for <netdev@vger.kernel.org>; Fri, 26 Jan 2018 03:35:51 +0100 (CET)
Received: by mail-wm0-f42.google.com with SMTP id v71so18489060wmv.2
        for <netdev@vger.kernel.org>; Thu, 25 Jan 2018 18:35:51 -0800 (PST)
In-Reply-To: <1516915211-5869-2-git-send-email-u9012063@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jan 25, 2018 at 1:20 PM, William Tu <u9012063@gmail.com> wrote:
> Originally the erspan fields are defined as a group into a __be16 field,
> and use mask and offset to access each field.  This is more costly due to
> calling ntohs/htons.  The patch changes it to use bitfields.
>
> Signed-off-by: William Tu <u9012063@gmail.com>

Acked-by: Pravin B Shelar <pshelar@ovn.org>

Thanks.