From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pravin Shelar Subject: Re: [PATCH net-next] openvswitch: correctly fragment packet with mpls headers Date: Tue, 4 Oct 2016 09:53:25 -0700 Message-ID: References: <20161004102458.1241605f@griffin> <20161004112804.04f25140@griffin> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Linux Kernel Network Developers , David Ahern To: Jiri Benc Return-path: Received: from relay3-d.mail.gandi.net ([217.70.183.195]:49703 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752027AbcJDQxb (ORCPT ); Tue, 4 Oct 2016 12:53:31 -0400 Received: from mfilter49-d.gandi.net (mfilter49-d.gandi.net [217.70.178.180]) by relay3-d.mail.gandi.net (Postfix) with ESMTP id BF6E3A80E5 for ; Tue, 4 Oct 2016 18:53:28 +0200 (CEST) Received: from relay3-d.mail.gandi.net ([IPv6:::ffff:217.70.183.195]) by mfilter49-d.gandi.net (mfilter49-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id oog2BaNOKaPU for ; Tue, 4 Oct 2016 18:53:27 +0200 (CEST) Received: from mail-io0-f175.google.com (mail-io0-f175.google.com [209.85.223.175]) (Authenticated sender: pshelar@ovn.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3A80FA80C0 for ; Tue, 4 Oct 2016 18:53:27 +0200 (CEST) Received: by mail-io0-f175.google.com with SMTP id i202so78641295ioi.2 for ; Tue, 04 Oct 2016 09:53:27 -0700 (PDT) In-Reply-To: <20161004112804.04f25140@griffin> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 4, 2016 at 2:28 AM, Jiri Benc wrote: > On Tue, 4 Oct 2016 10:24:58 +0200, Jiri Benc wrote: >> On Mon, 3 Oct 2016 11:04:46 -0700, Pravin Shelar wrote: >> > This is not correct way to detect MPLS packet. inner_protocol can be >> > set by any tunnel device for using tunnel offloads. So this would >> > break the fragmentation for encapsulated packets. >> >> You're right, stupid me. > > Actually, too little caffeine in the morning. I actually did consider > this and I believe my patch is correct. It doesn't matter what the > encapsulation is, we want to fragment the *inner* packet. And this is > exactly what this patch does. > > Besides, the only case is MPLS anyway. I'm not aware of any code path > that could lead us to here, set inner protocol and not be MPLS. But > even if it is, it should work, provided the encapsulation header is > identical for all fragments and smaller than MAX_L2_LEN. > This code can be executed on encapsulated geneve or vxlan packets. So in that case encapsulation header would not be same for all fragments.