From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C75DC433ED for ; Tue, 20 Apr 2021 04:22:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3101611B0 for ; Tue, 20 Apr 2021 04:22:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3101611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5CEC63E; Tue, 20 Apr 2021 06:21:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5CEC63E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1618892530; bh=mT1P/0V1Kk7Ha+oRfnhOKkK5dIIkfFW7uxOgrol6ItI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JXejKg588aoWNika4DlzBA2UvEg8GIAV5cTL+uC0E6MjCx7qjjaXqgrTSK4LzEO7i //tMhAY/PokfFVuZC3OB5F2w8yDr+V7sUPio9jZoSygaPYGLO6z3CktuIfC4tMjbUv gLsSRJ24s2zUUCSusiEbN+DlU53MWVVNxSR94qb4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A645BF80164; Tue, 20 Apr 2021 06:21:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 08E9DF80253; Tue, 20 Apr 2021 06:21:17 +0200 (CEST) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 44483F80164 for ; Tue, 20 Apr 2021 06:21:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 44483F80164 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tYBKjmRD" Received: by mail-ed1-x532.google.com with SMTP id g17so42649967edm.6 for ; Mon, 19 Apr 2021 21:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dhORXXZw6vekyF5rkC7bo+EF81jvGX9SqWkbSqZ6Q7A=; b=tYBKjmRD4tR98rZzVQSbZI8HmElVSTX4zk4+xCl8x5XQ7pn0aH/K6HZbGmiT9poIPy 17Qydqla9egDucm4QcZjh85IystTbuojBLXG0w1p3pVI0+r1lIH0/XJr7PymeKmx/Pxv Iz9cnP+1s8lBUQrrE8I4jBkbquRQUS+LioT7D8+ehqI+vYS0MUI5zF8BkDYFU2amTqLN 6lFv+sJ46jCq2k6UTDaRj82lX7ssq/cKoaTDAzaAAb5JPSstnyUpakdEspyU3fO3PQdy wZ43XBPnh6yZiFwtCObbaJ0OqieB72v31ARx5JEAeL3qIa4g/10GZ/+32C8Te3vZm+a2 OtZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dhORXXZw6vekyF5rkC7bo+EF81jvGX9SqWkbSqZ6Q7A=; b=clMJJ1ECuCAdz4G/objBDmO11MzZ1dYWZaE6NCMsltxmcfrn7CZXuuv3GOY3EFA8KW /vI9jvhGWmiztx6DzgdtDxs2hMJbCRoaToDp9rF0200m2dkF+gpLqSFyuvevekn73dCf b5Rq17DVhvMhiAL9TYHNkk8oOUxJOEE3RzmXFlnfZPNXu23oeCVCLdoiKVvxK5AQw/Nk DvWoqLlJ1/yR1x6YDgLMSvxa46p9noTsheXcyUurEaaVKUjqqdurD1ii7y5J4X9JGzWq XMCTsTw5Piv5TqPWPABFwYtbHdecd+akA9yGJGXqVPhs9/NWtZ/9kzAY0Ljr1RqFKEGN LSqA== X-Gm-Message-State: AOAM531Xvm2+pPoF6AwbYyxW8VIbhcXopvYSYuWCeIIJXKjPNOHlxVFV 3Eg9LzC1l868gEr/5x/mc53mQazgv5e2H81qRa/tMm9CkhY= X-Google-Smtp-Source: ABdhPJyRS3BRLvFvwgOkRNA1lWbeKM3IVdIa8mx9KbSkxneiGEssQgFuVl2VlYVgfjkbdyqBvoBijx1R/CB+9GI70Ds= X-Received: by 2002:a05:6402:1cb9:: with SMTP id cz25mr17505791edb.163.1618892469007; Mon, 19 Apr 2021 21:21:09 -0700 (PDT) MIME-Version: 1.0 References: <20210414083255.9527-1-tiwai@suse.de> <5949663.lOV4Wx5bFT@kam-desktop> In-Reply-To: <5949663.lOV4Wx5bFT@kam-desktop> From: Lucas Date: Mon, 19 Apr 2021 23:20:57 -0500 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: Apply implicit feedback mode for BOSS devices To: "Keith A. Milner" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Keith, if it's anything like the Roland devices I've tested with this long-awaited patch, could you show the JS-8's "lsusb -v"? For me, silence due to the wrong line takes the form of unheard output playback, while still working for input capture, so I'm not sure this has any bearing on your issue. Takashi Iwai has indicated a likely connection between needing the IMPLICIT_FB_BOTH_DEVICE line if there's "Asynchronous" "Synch Type" for both input and output endpoints. Otherwise, possibly, it should be reverted to IMPLICIT_FB_FIXED_DEVICE for the JS-8. I did check my Roland devices with jack, but only after they were all working with standard arecord and aplay. Thanks, Lucas On Mon, Apr 19, 2021 at 9:13 AM Keith A. Milner wrote: > On Wednesday, 14 April 2021 16:08:54 BST Mike Oliphant wrote: > > Thanks for your help with this, Takashi. > > > > I have tested this patch on BOSS GT-1 and BOSS Katana, so we have a > fairly > > high degree of confidence that it will work on the other BOSS devices. > > > > It may well help with other similar Roland devices. If your device has > > playback working, but with occasional pops/clicks in the audio stream, it > > is worth trying to add the IMPLICIT_FB_BOTH_DEV quirk for the device. > > > > I have confirmed that it works with the GT-1 and Boss Katana as well. > > I have also tested with the Boss BR-80 and GT-001 and this still seems to > work > well for me, so no obvious issues have arisen from making this change. > > I did also try the Boss JS-8. This works in Ardour, but capture from > command > line using arecord results in a file of silence. I'll do some more digging > into > this one. > > Regards, > > Keith > > > > >