From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01ED0C433B4 for ; Fri, 9 Apr 2021 19:10:18 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A52861028 for ; Fri, 9 Apr 2021 19:10:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A52861028 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 799511683; Fri, 9 Apr 2021 21:09:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 799511683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1617995415; bh=ggqZ5kySUiZoYvGtCly43yWqXySBndp+6qAQlFZPKZw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=m9aYabujCV0jS1FEqWjUipIvFeAzLarG77N1yjpAJVFY7jcSHMrTAtNRSIzO02llv 696mUHFw9V/mhI1lOrCBcuMBZiCSKrUuBJG/65uGLPeFzAQRZqhltMDYnQlmwxanyr yq6UKG70mBdfRTvZCU5D6boJpFE7P4//w8Rpn61Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7A127F80168; Fri, 9 Apr 2021 21:09:24 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2C785F8016A; Fri, 9 Apr 2021 21:09:20 +0200 (CEST) Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F1EABF800EE for ; Fri, 9 Apr 2021 21:09:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F1EABF800EE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eecHIB9M" Received: by mail-ej1-x62a.google.com with SMTP id n2so10276632ejy.7 for ; Fri, 09 Apr 2021 12:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pIF0jIppNhaigCYUffRniAiSSvrvuNPK80wMIKkORuY=; b=eecHIB9M0XYmzXGTadzjCfGHXDfKOVE9mCBIQRIISJ6MzQVROLvwk8M16ngLCLbatU IJjYcXSefriH+xU8N6pAlh6B8D9dm8aNuLLtieCad84gW8Tx2BkPrygkQ6j2o6s+AZso hE+chZUTycsunu5T2NK8OflbFuXim6viYbqeTEaPgoNFw8SIb6uJViec0tZHe4mOEXN6 JqfUD3qGX0//EXe+GN+fM/PfPEje1AL65xDzjn+7G3V+nSC69icAq1inKaHiarV83Tlh +GXLPsaaizQr1yti6+WVuaZZ2Hi12/WMCxbwU+gZwrzLl31NtmoCXVNoN9P7s+h8lB8o glbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pIF0jIppNhaigCYUffRniAiSSvrvuNPK80wMIKkORuY=; b=Tj7vORk9N2R3nkK9KEl+Avujcpf7XuN4+TtM6gCtMVupLH3FDSmc/URZ2E7Lt+HxqW qnpQR8K3XqiPdXLOGTP6WrqORXe4XphDD0AZz5g66UqIhqF739Zlitanj6kjjnZAf1Wm HrC1buNgFuILDrcQUe7udsfN5foVvcZ7xh5c1TInUcJ1rzKvfQ5B4gNibWf3bFKxFNMB LmS5yt/j5c/PuWXbW+f1yKBhPGcZ6rQHuRQSUmVjPa12CpeSLXV8Qn9YuKPEFK0SsWXN s8q+wEKdGcLz2XyntT7ngdacYc5OBH4iLFtiQKM2RXDlKgwHwqlrFKp9ELY+T1xS8Quf Sttg== X-Gm-Message-State: AOAM530UudUheX6oixNiOSCWNvIBOj+SlRH/DF51woxW6WcwffsxAGhg aGm07mKhKlflqqFFD7l0f8ZyQEl2CeVzPjKFghs= X-Google-Smtp-Source: ABdhPJy0fsATiSv4E5gUZXb8zNX/7gBAggNte19o4M487SZMz8QzeeOzr5us6MKImjcyzb74KhutGTUE+Nt8/35jOPY= X-Received: by 2002:a17:907:20f0:: with SMTP id rh16mr6009050ejb.320.1617995352035; Fri, 09 Apr 2021 12:09:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Lucas Date: Fri, 9 Apr 2021 14:09:00 -0500 Message-ID: Subject: Re: Implicit feedback on BOSS GT-1, the saga continues... To: Mike Oliphant Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: alsa-devel@alsa-project.org, Geraldo Nascimento X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" I wholeheartedly agree with everything you wrote, Mike. Takashi is the person who knows best how to implement these changes, and is definitely the most capable. I will get back to you about retesting my other Roland devices with this trick, although I only have a few of the many devices I'd ultimately like this solution implemented for. Also, I haven't noticed the sync-related clicking with the other devices I own, but I'm confident they won't be hurt by the change. I'll let you both know, though, when I get around to testing them. Thanks as ever, Lucas On Fri, Apr 9, 2021 at 11:47 AM Mike Oliphant wrote: > Hi Lucas, > > Your observation that the Roland D-05 still needs the capture feedback > made me try some more testing, and I think the GT-1 actually is the same. > > I use my device with jackd running for both capture/playback at the same > time. This works for me without capture feedback enabled. But, it turns out > that just doing an "arecord" without playback fails. Enabling the capture > feedback makes capture also work without playback (and everything else > still works perfectly). > > Given this, I agree that it seems likely that most, if not all, of these > Roland devices work the same way. It would be great to get more devices > tested, though. > > As to an actual patch, I think it is probably best left to Takashi to > decide if he is comfortable with making a change to > snd_usb_endpoint_start() in endpoint.c, and if so, how he wants to make it > conditional for devices - whether an ID check in endpoint.c, or a flag on > feedback setup, or some other way. > > Mike >