From: Gilad Ben-Yossef <gilad@benyossef.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
David Miller <davem@davemloft.net>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Yael Chemla <yael.chemla@foss.arm.com>
Subject: Re: [PATCH 2/7] crypto: ccrree: no need to check return value of debugfs_create functions
Date: Thu, 24 Jan 2019 09:58:20 +0200 [thread overview]
Message-ID: <CAOtvUMdTC46+dNt9m5eU_JrRDKpKPTv74A6cDCC2yXM=-YkFEA@mail.gmail.com> (raw)
In-Reply-To: <20190123133734.GA24700@kroah.com>
On Wed, Jan 23, 2019 at 3:37 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Jan 23, 2019 at 02:58:22PM +0200, Gilad Ben-Yossef wrote:
> > Hi,
> >
> > On Tue, Jan 22, 2019 at 5:14 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > When calling debugfs functions, there is no need to ever check the
> > > return value. The function can work or not, but the code logic should
> > > never do something different based on this.
> >
> >
> >
> > I get the part about not failing loading the driver just because some
> > debugs entry isn't available, but wont it be weird if
> > debugfs_create_dir() fails but debugfs_create_regset32() succeeds and
> > we suddenly have weird files in the debugfs root dir?
> > Not the end of the world of course but maybe it's better to avoid
> > trying to create the files if the directory is not available?
>
> See this patch to handle that theoretical issue:
>
> https://lore.kernel.org/lkml/20190123130917.GZ4087@dhcp22.suse.cz/T/#me91cc3d16185be13d64f85c8477c543cbda9baf6
>
Ah, sorry. I've missed that.
Acked-By: Gilad Ben-Yossef <gilad@benyossef.com>
Thanks!
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
values of β will give rise to dom!
next prev parent reply other threads:[~2019-01-24 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:14 [PATCH 0/7] crypto: cleanup debugfs usage Greg Kroah-Hartman
2019-01-22 15:14 ` [PATCH 1/7] crypto: qat: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-22 15:14 ` [PATCH 2/7] crypto: ccrree: " Greg Kroah-Hartman
2019-01-23 12:58 ` Gilad Ben-Yossef
2019-01-23 13:37 ` Greg Kroah-Hartman
2019-01-24 7:58 ` Gilad Ben-Yossef [this message]
2019-01-22 15:14 ` [PATCH 3/7] crypto: axis: " Greg Kroah-Hartman
2019-01-23 7:37 ` Lars Persson
2019-01-22 15:14 ` [PATCH 4/7] crypto: cavium: zip: " Greg Kroah-Hartman
2019-01-23 13:30 ` Jan Glauber
2019-01-22 15:14 ` [PATCH 5/7] crypto: cavium: nitrox: " Greg Kroah-Hartman
2019-01-22 15:14 ` [PATCH 6/7] crypto: ccp: " Greg Kroah-Hartman
2019-01-22 22:06 ` Gary R Hook
2019-01-23 6:55 ` Greg Kroah-Hartman
2019-01-22 15:14 ` [PATCH 7/7] crypto: caam: " Greg Kroah-Hartman
2019-01-22 15:29 ` Horia Geanta
2019-02-01 6:48 ` [PATCH 0/7] crypto: cleanup debugfs usage Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOtvUMdTC46+dNt9m5eU_JrRDKpKPTv74A6cDCC2yXM=-YkFEA@mail.gmail.com' \
--to=gilad@benyossef.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yael.chemla@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.