From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756811Ab2BIIJS (ORCPT ); Thu, 9 Feb 2012 03:09:18 -0500 Received: from mail-vx0-f174.google.com ([209.85.220.174]:51702 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426Ab2BIIJR convert rfc822-to-8bit (ORCPT ); Thu, 9 Feb 2012 03:09:17 -0500 MIME-Version: 1.0 X-Originating-IP: [109.64.24.177] In-Reply-To: References: <1328448800-15794-1-git-send-email-gilad@benyossef.com> <1328449722-15959-6-git-send-email-gilad@benyossef.com> Date: Thu, 9 Feb 2012 10:09:15 +0200 Message-ID: Subject: Re: [PATCH v8 7/8] mm: only IPI CPUs to drain local pages if they exist From: Gilad Ben-Yossef To: Michal Nazarewicz Cc: linux-kernel@vger.kernel.org, KOSAKI Motohiro , Chris Metcalf , Frederic Weisbecker , Russell King , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Sasha Levin , Rik van Riel , Andi Kleen , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, Avi Kivity , Milton Miller Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2012/2/8 Michal Nazarewicz : > On Sun, 05 Feb 2012 14:48:41 +0100, Gilad Ben-Yossef > wrote: >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index d2186ec..3ff5aff 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -1161,11 +1161,46 @@ void drain_local_pages(void *arg) ... >> + >> +       /* Allocate in the BSS so we wont require allocation in >> +        * direct reclaim path for CONFIG_CPUMASK_OFFSTACK=y >> +        */ > > > If you are going to send next iteration, this comment should have > “/*” on its own line just like comment below. Right, thanks. Gilad -- Gilad Ben-Yossef Chief Coffee Drinker gilad@benyossef.com Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?"  -- Jean-Baptiste Queru From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gilad Ben-Yossef Subject: Re: [PATCH v8 7/8] mm: only IPI CPUs to drain local pages if they exist Date: Thu, 9 Feb 2012 10:09:15 +0200 Message-ID: References: <1328448800-15794-1-git-send-email-gilad@benyossef.com> <1328449722-15959-6-git-send-email-gilad@benyossef.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Cc: linux-kernel@vger.kernel.org, KOSAKI Motohiro , Chris Metcalf , Frederic Weisbecker , Russell King , linux-mm@kvack.org, Pekka Enberg , Matt Mackall , Sasha Levin , Rik van Riel , Andi Kleen , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, Avi Kivity , Milton Miller To: Michal Nazarewicz Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org 2012/2/8 Michal Nazarewicz : > On Sun, 05 Feb 2012 14:48:41 +0100, Gilad Ben-Yossef > wrote: >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index d2186ec..3ff5aff 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -1161,11 +1161,46 @@ void drain_local_pages(void *arg) ... >> + >> + =A0 =A0 =A0 /* Allocate in the BSS so we wont require allocation in >> + =A0 =A0 =A0 =A0* direct reclaim path for CONFIG_CPUMASK_OFFSTACK=3Dy >> + =A0 =A0 =A0 =A0*/ > > > If you are going to send next iteration, this comment should have > =93/*=94 on its own line just like comment below. Right, thanks. Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker gilad@benyossef.com Israel Cell: +972-52-8260388 US Cell: +1-973-8260388 http://benyossef.com "If you take a class in large-scale robotics, can you end up in a situation where the homework eats your dog?" =A0-- Jean-Baptiste Queru -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org