From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13D2AECE588 for ; Wed, 16 Oct 2019 09:02:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEECB2168B for ; Wed, 16 Oct 2019 09:02:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="zEoEoRFB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732045AbfJPJCu (ORCPT ); Wed, 16 Oct 2019 05:02:50 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:39767 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732312AbfJPJCu (ORCPT ); Wed, 16 Oct 2019 05:02:50 -0400 Received: by mail-vs1-f66.google.com with SMTP id y129so15095088vsc.6 for ; Wed, 16 Oct 2019 02:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6jUvM81mCFEJrPhVj3ktuFKsOAYFM0PHI7JF/RGSugc=; b=zEoEoRFBpMGeuWqMXV1f2QHg2y48MKzrSWjmPr6/mDYgWWxOZbJL7d/8fWf/SG7HHV kKLadN9y/vYBRZU7Sk3mpCHh239xyDlA7O3DHiOTMowI8qPx+xDNM0BA1r1+/mQQ9gHC y79iDmELliQ/ijHblynfsz49H0zzWPN3L5FHCVA+IQF7NBLHXmvVS9v596wyzYHH3kjw WvaZpcpFC7slJ6G8fu0NP7l9UfJ2hAs5TeZGV6CG3EVqponasYr2bLW+OwCcvxbgb52V UXdJWUpaoOiGgxuhyl91XkUBnYFM533hNRijW+GUGt3bw/a7hRzZSH5Y3gDKWA4k6eAb OW/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6jUvM81mCFEJrPhVj3ktuFKsOAYFM0PHI7JF/RGSugc=; b=ZU2JTdj/F/md95JY/z7b3WdPSlj1O1lInEoe40SU9RMSi6FI4Qv3gie7+2gAAJfCZD Jmc6CIMA8ViEGk08pw7Iz1nOyuA0v3PCCU2qYlw3+CRlVLB7P+GHvC2GzxNFYqn7ERYQ OKbrO+BhNRXQfHx7kbuMs5quOHN6WbySz1sg2fKva1mS6Y79tfEfnUmkzsQNhVXVWnFy mABj/PjvNB47Xu/D/QcRkEvjvpf8pnQ4l58bnDdvUiDz5oK3QqGtbyWiR89uGucTC0Va oQwzaDvPIEnOes71WRvcMXKYVORIpam0OLDBYaLZ5JM/6bf2SwTdvQ1Xnb7JiHUmqCT3 P15g== X-Gm-Message-State: APjAAAXqpknuApPHkGIoXKB1zJBQMO0cXGO6OGGRdQNceMDpNdrpwlzh B0stBSs5uDeOvbtW76CkoPyx0w3XGguaYfdfBUUv5w== X-Google-Smtp-Source: APXvYqxQSyLvxpBp3m1mo/VCOsScsg3NUDkJh1pU5DAlAz/K+hgV+5JWlOgAPzmr5rIaoiRfaKo5DuPpU5vDVQv8UK4= X-Received: by 2002:a67:b20d:: with SMTP id b13mr522223vsf.164.1571216569773; Wed, 16 Oct 2019 02:02:49 -0700 (PDT) MIME-Version: 1.0 References: <20191012201809.160500-1-ebiggers@kernel.org> In-Reply-To: <20191012201809.160500-1-ebiggers@kernel.org> From: Gilad Ben-Yossef Date: Wed, 16 Oct 2019 12:02:38 +0300 Message-ID: Subject: Re: [RFT PATCH 0/3] crypto: s390 - convert to skcipher API To: Eric Biggers Cc: Linux Crypto Mailing List , Herbert Xu , linux-s390@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Harald Freudenberger Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Oct 12, 2019 at 11:20 PM Eric Biggers wrote: > > This series converts the glue code for the S390 CPACF implementations of > AES, DES, and 3DES modes from the deprecated "blkcipher" API to the > "skcipher" API. This is needed in order for the blkcipher API to be > removed. > > I've compiled this patchset, and the conversion is very similar to that > which has been done for many other crypto drivers. But I don't have the > hardware to test it, nor is S390 CPACF supported by QEMU. So I really > need someone with the hardware to test it. You can do so by setting: > > CONFIG_CRYPTO_HW=3Dy > CONFIG_ZCRYPT=3Dy > CONFIG_PKEY=3Dy > CONFIG_CRYPTO_AES_S390=3Dy > CONFIG_CRYPTO_PAES_S390=3Dy > CONFIG_CRYPTO_DES_S390=3Dy > # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set > CONFIG_DEBUG_KERNEL=3Dy > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=3Dy > CONFIG_CRYPTO_AES=3Dy > CONFIG_CRYPTO_DES=3Dy > CONFIG_CRYPTO_CBC=3Dy > CONFIG_CRYPTO_CTR=3Dy > CONFIG_CRYPTO_ECB=3Dy > CONFIG_CRYPTO_XTS=3Dy > > Then boot and check for crypto self-test failures by running > 'dmesg | grep alg'. > > If there are test failures, please also check whether they were already > failing prior to this patchset. > > This won't cover the "paes" ("protected key AES") algorithms, however, > since those don't have self-tests. If anyone has any way to test those, > please do so. It is probably impracticable to test paes algorithms since they rely on keys which are not accessible to the kernel and are typically tied to the specific machine you run on. Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker values of =CE=B2 will give rise to dom!