From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 872CDC64E7A for ; Thu, 19 Nov 2020 11:45:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DCB9246F0 for ; Thu, 19 Nov 2020 11:45:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=benyossef-com.20150623.gappssmtp.com header.i=@benyossef-com.20150623.gappssmtp.com header.b="gh6maHtJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727715AbgKSLol (ORCPT ); Thu, 19 Nov 2020 06:44:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727709AbgKSLoj (ORCPT ); Thu, 19 Nov 2020 06:44:39 -0500 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90ACCC0613CF for ; Thu, 19 Nov 2020 03:44:37 -0800 (PST) Received: by mail-yb1-xb42.google.com with SMTP id x17so4890570ybr.8 for ; Thu, 19 Nov 2020 03:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=benyossef-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=c8Qo3iMTLDXZDQ8LhsVrB4GbG7ddhsHuA42Wrhb4+h0=; b=gh6maHtJeErJOD6UDW2c3CCbf+6ZoSfGn3H+8ciJk7tdtGTboUKsUQLcJZHMyBl7ZA b1+/DztKMtFKcSEblfJ9XDZL12+fIyTo4p6R6PD15BN/1bNpZnFdAHoVGCu9OB+Q4x/H xzMZ6S1ODsNOBBQkv+EZGsTt2pEFMRANM7HfnH9X85lyyCVItmSSRNIQdRgV9bQWTK0/ gIVlRReIhZCA6kK2DYrdKwgUL0BSDlybyDUAgb60bjZNKj0eNV+uhmq/XtksTPeKpRoY pLX/H1qNeFsSB33WIvjrV2zkRLfo6Wiz07rd0rfwfY6Wattimo7gNt73V5Hjd/ZGtBK9 +DtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c8Qo3iMTLDXZDQ8LhsVrB4GbG7ddhsHuA42Wrhb4+h0=; b=eR+Bm8INTlZ9AoEPoq/Imo1tqopk1d9VAWs/7uK4a/8JKQfbE78M0+v7z+Ch1cz6Y4 daFmdqOHJWqgqRh8geyl9XHe7CMCqD5JxLQ1hxkqfgmnQy9G+8ngwZpTfljuY2DtZsbI jfLcESqXdDgcYED/uPu8Hk7csOn355dR0pajFNCg2+s5wb2GazjzqKmnZ2+A5TeDWiyx w39ITXY7MJ5J3zBN3mT/LEOhjAxoI8LtglZK5e1c/ZxsShsyRp7MQmskDurMllZy0s+V 8Q4Gs1KKiuRAvh0dAK+McY0HhsqI5VIIbMbZNaorDxWD7FeEPZ3sEspLA6rb8dYq9ivV T5Sw== X-Gm-Message-State: AOAM532cwrGmFfXtp6vet92q6ItsqtAQixDcUcvRi11gyXck5rF3zm/O 3H3i31X78rlTN3W6MnSZ3gbD2IERkaMzreojGe3MvQ== X-Google-Smtp-Source: ABdhPJzEoiEVIDDG7CVsykDj/QZuLByOFuhSa5yFAPYsb/SMTp5op2dwar3PQWhrmEUaPh6JNJoGIhPp4adf8SrbWlw= X-Received: by 2002:a25:9b44:: with SMTP id u4mr14103602ybo.426.1605786276902; Thu, 19 Nov 2020 03:44:36 -0800 (PST) MIME-Version: 1.0 References: <20200916071950.1493-1-gilad@benyossef.com> <20200916071950.1493-2-gilad@benyossef.com> <20200923015702.GA3676455@bogus> <1450044c-5150-1da2-11e0-2ae48d8b4d0c@arm.com> In-Reply-To: <1450044c-5150-1da2-11e0-2ae48d8b4d0c@arm.com> From: Gilad Ben-Yossef Date: Thu, 19 Nov 2020 13:44:21 +0200 Message-ID: Subject: Re: [PATCH 1/2] dt-bindings: crypto: update ccree optional params To: Robin Murphy Cc: Rob Herring , Herbert Xu , "David S. Miller" , Ofir Drang , Linux Crypto Mailing List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux kernel mailing list , Steven Price Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi, On Tue, Nov 17, 2020 at 4:07 PM Robin Murphy wrote: > > On 2020-11-16 18:54, Rob Herring wrote: > > On Thu, Oct 22, 2020 at 1:18 AM Gilad Ben-Yossef = wrote: > >> ... > > IMO if this is like PL330 where you just stick some raw AXI attributes > in a register and that's what goes out on transactions then it's not > really part of the platform description anyway, it's just driver policy. > If folks want to tweak the driver's behaviour for secret SoC-specific > performance optimisation, then give them some module parameters or a > sysfs interface. I'm assuming this has to be purely a performance thing, > because I can't see how two different integrations could reasonably > depend on different baseline attributes for correctness, and even if > they did then you'd be able to determine that from the compatible > strings, because they would be different, because those integrations > would be fundamentally *not* compatible with each other. > So, I checked internally where we get this requirement and it seems you are right. I'm dropping the Dt bindings and in fact the ability to customize those attributes beyond the basic coherent/non coherent configuration which we already support and will just update the setting to what we think is best. Thanks for clearing this up. Gilad --=20 Gilad Ben-Yossef Chief Coffee Drinker values of =CE=B2 will give rise to dom!