From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbcF2N6k (ORCPT ); Wed, 29 Jun 2016 09:58:40 -0400 Received: from mail-vk0-f53.google.com ([209.85.213.53]:34471 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbcF2N6E (ORCPT ); Wed, 29 Jun 2016 09:58:04 -0400 MIME-Version: 1.0 In-Reply-To: <1467191739-17394-1-git-send-email-ykk@rock-chips.com> References: <1467191657-16941-1-git-send-email-ykk@rock-chips.com> <1467191739-17394-1-git-send-email-ykk@rock-chips.com> From: Sean Paul Date: Wed, 29 Jun 2016 09:57:39 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 07/11] drm/rockchip: analogix_dp: correct the connector display color format and bpc To: Yakir Yang Cc: Mark Yao , Inki Dae , Jingoo Han , Heiko Stuebner , Javier Martinez Canillas , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , Tomasz Figa , David Airlie , Daniel Vetter , Thierry Reding , Douglas Anderson , Krzysztof Kozlowski , Emil Velikov , Dan Carpenter , Linux Kernel Mailing List , dri-devel , linux-samsung-soc , linux-rockchip@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2016 at 5:15 AM, Yakir Yang wrote: > Rockchip VOP couldn't output YUV video format for eDP controller, so > when driver detect connector support YUV video format, we need to hack > it down to RGB888. > > Signed-off-by: Yakir Yang > Acked-by: Mark Yao > Reviewed-by: Tomasz Figa Reviewed-by: Sean Paul > --- > Changes in v4: > - Using mask variable to collect the YUV video format. (Sean) > - Add reviewed flag from Tomasz. > > Changes in v3: > - Hook the connector's color_formats in .get_modes directly. (Tomasz, reviewed at Google Gerrit) > [https://chromium-review.googlesource.com/#/c/346317/15] > - Add the acked flag from Mark. > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 0755573..0a0fb3a 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -110,6 +110,23 @@ static int rockchip_dp_powerdown(struct analogix_dp_plat_data *plat_data) > return 0; > } > > +static int rockchip_dp_get_modes(struct analogix_dp_plat_data *plat_data, > + struct drm_connector *connector) > +{ > + struct drm_display_info *di = &connector->display_info; > + /* VOP couldn't output YUV video format for eDP rightly */ > + u32 mask = DRM_COLOR_FORMAT_YCRCB444 | DRM_COLOR_FORMAT_YCRCB422; > + > + if ((di->color_formats & mask)) { > + DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n"); > + di->color_formats &= ~mask; > + di->color_formats |= DRM_COLOR_FORMAT_RGB444; > + di->bpc = 8; > + } > + > + return 0; > +} > + > static bool > rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder, > const struct drm_display_mode *mode, > @@ -310,6 +327,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, > dp->plat_data.dev_type = dp->data->chip_type; > dp->plat_data.power_on = rockchip_dp_poweron; > dp->plat_data.power_off = rockchip_dp_powerdown; > + dp->plat_data.get_modes = rockchip_dp_get_modes; > > return analogix_dp_bind(dev, dp->drm_dev, &dp->plat_data); > } > -- > 1.9.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v4 07/11] drm/rockchip: analogix_dp: correct the connector display color format and bpc Date: Wed, 29 Jun 2016 09:57:39 -0400 Message-ID: References: <1467191657-16941-1-git-send-email-ykk@rock-chips.com> <1467191739-17394-1-git-send-email-ykk@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467191739-17394-1-git-send-email-ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Yakir Yang Cc: Krzysztof Kozlowski , linux-samsung-soc , Linux Kernel Mailing List , Heiko Stuebner , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Yao , Jingoo Han , David Airlie , Emil Velikov , Douglas Anderson , dri-devel , Tomasz Figa , Inki Dae , Javier Martinez Canillas , Daniel Vetter , =?UTF-8?Q?St=C3=A9phane_Marchesin?= , Thierry Reding , Dan Carpenter List-Id: linux-samsung-soc@vger.kernel.org On Wed, Jun 29, 2016 at 5:15 AM, Yakir Yang wrote: > Rockchip VOP couldn't output YUV video format for eDP controller, so > when driver detect connector support YUV video format, we need to hack > it down to RGB888. > > Signed-off-by: Yakir Yang > Acked-by: Mark Yao > Reviewed-by: Tomasz Figa Reviewed-by: Sean Paul > --- > Changes in v4: > - Using mask variable to collect the YUV video format. (Sean) > - Add reviewed flag from Tomasz. > > Changes in v3: > - Hook the connector's color_formats in .get_modes directly. (Tomasz, reviewed at Google Gerrit) > [https://chromium-review.googlesource.com/#/c/346317/15] > - Add the acked flag from Mark. > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > index 0755573..0a0fb3a 100644 > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > @@ -110,6 +110,23 @@ static int rockchip_dp_powerdown(struct analogix_dp_plat_data *plat_data) > return 0; > } > > +static int rockchip_dp_get_modes(struct analogix_dp_plat_data *plat_data, > + struct drm_connector *connector) > +{ > + struct drm_display_info *di = &connector->display_info; > + /* VOP couldn't output YUV video format for eDP rightly */ > + u32 mask = DRM_COLOR_FORMAT_YCRCB444 | DRM_COLOR_FORMAT_YCRCB422; > + > + if ((di->color_formats & mask)) { > + DRM_DEBUG_KMS("Swapping display color format from YUV to RGB\n"); > + di->color_formats &= ~mask; > + di->color_formats |= DRM_COLOR_FORMAT_RGB444; > + di->bpc = 8; > + } > + > + return 0; > +} > + > static bool > rockchip_dp_drm_encoder_mode_fixup(struct drm_encoder *encoder, > const struct drm_display_mode *mode, > @@ -310,6 +327,7 @@ static int rockchip_dp_bind(struct device *dev, struct device *master, > dp->plat_data.dev_type = dp->data->chip_type; > dp->plat_data.power_on = rockchip_dp_poweron; > dp->plat_data.power_off = rockchip_dp_powerdown; > + dp->plat_data.get_modes = rockchip_dp_get_modes; > > return analogix_dp_bind(dev, dp->drm_dev, &dp->plat_data); > } > -- > 1.9.1 > >