From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932404AbdDFVDg (ORCPT ); Thu, 6 Apr 2017 17:03:36 -0400 Received: from mail-yw0-f173.google.com ([209.85.161.173]:35851 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbdDFVDa (ORCPT ); Thu, 6 Apr 2017 17:03:30 -0400 MIME-Version: 1.0 In-Reply-To: <20170322132608.17353-1-robh@kernel.org> References: <20170322132608.17353-1-robh@kernel.org> From: Sean Paul Date: Thu, 6 Apr 2017 17:03:06 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 0/5] DRM OF graph clean-up To: Rob Herring Cc: David Airlie , Daniel Vetter , dri-devel , Linux Kernel Mailing List , Boris Brezillon , Archit Taneja , Jingoo Han , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Stefan Agner , Alison Wang , Xinliang Liu , Rongrong Zou , Xinwei Kong , Chen Feng , Philipp Zabel , CK Hu , Matthias Brugger , Marek Vasut , Mark Yao , Heiko Stuebner , Maxime Ripard , Chen-Yu Tsai , Liviu Dudau , Mali DP Maintainers , Neil Armstrong , Carlo Caione , Kevin Hilman , Rob Clark , Jyri Sarha , Tomi Valkeinen , Eric Anholt , Russell King Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 22, 2017 at 9:26 AM, Rob Herring wrote: > I've been unhappy with the OF graph API for some time and decided to > do something about it. The problem is drivers have to do too much of the > graph parsing and walking themselves. This has led to the same pattern > duplicated over and over. This series adapts DRM drivers to use a new OF > graph helper and added DRM helper. > > The DT dependency went into 4.11, so this series can be applied to the DRM > tree without any cross tree dependencies. > > I've done some build testing only, so testing appreciated. A git branch is > here[1]. > > Rob > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git of-graph-helpers > > > Rob Herring (5): > drm: make of_drm_find_panel also depend on CONFIG_DRM_PANEL > drm: of: introduce drm_of_find_panel_or_bridge > drm: convert drivers to use of_graph_get_remote_node > drm: convert drivers to use drm_of_find_panel_or_bridge > drm: omap: use common OF graph helpers > Hi Rob, Thank you for the series, and sorry for the delay. I've fixed the 2 conflicts and applied to -misc-next. Sean > drivers/gpu/drm/arm/hdlcd_drv.c | 22 +---- > drivers/gpu/drm/arm/malidp_drv.c | 28 +------ > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 73 +++++----------- > drivers/gpu/drm/bridge/adv7511/adv7533.c | 12 +-- > drivers/gpu/drm/bridge/dumb-vga-dac.c | 15 +--- > drivers/gpu/drm/bridge/nxp-ptn3460.c | 16 +--- > drivers/gpu/drm/bridge/parade-ps8622.c | 16 +--- > drivers/gpu/drm/bridge/tc358767.c | 27 +----- > drivers/gpu/drm/bridge/ti-tfp410.c | 15 ++-- > drivers/gpu/drm/drm_of.c | 52 ++++++++++++ > drivers/gpu/drm/exynos/exynos_dp.c | 35 +++----- > drivers/gpu/drm/exynos/exynos_drm_dpi.c | 16 +--- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 +-- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 25 +----- > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 39 ++------- > drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 27 +----- > drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 30 +------ > drivers/gpu/drm/imx/imx-ldb.c | 27 ++---- > drivers/gpu/drm/imx/parallel-display.c | 36 +------- > drivers/gpu/drm/mediatek/mtk_dpi.c | 12 +-- > drivers/gpu/drm/mediatek/mtk_dsi.c | 23 ++--- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 26 +----- > drivers/gpu/drm/meson/meson_venc_cvbs.c | 19 +---- > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 28 +------ > drivers/gpu/drm/mxsfb/mxsfb_out.c | 40 ++------- > drivers/gpu/drm/omapdrm/dss/dpi.c | 2 +- > drivers/gpu/drm/omapdrm/dss/dsi.c | 3 +- > drivers/gpu/drm/omapdrm/dss/dss-of.c | 102 +---------------------- > drivers/gpu/drm/omapdrm/dss/dss.c | 61 +++----------- > drivers/gpu/drm/omapdrm/dss/hdmi4.c | 3 +- > drivers/gpu/drm/omapdrm/dss/hdmi5.c | 3 +- > drivers/gpu/drm/omapdrm/dss/omapdss.h | 11 --- > drivers/gpu/drm/omapdrm/dss/sdi.c | 2 +- > drivers/gpu/drm/omapdrm/dss/venc.c | 3 +- > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 26 +----- > drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 18 ++-- > drivers/gpu/drm/sun4i/sun4i_rgb.c | 11 +-- > drivers/gpu/drm/sun4i/sun4i_tcon.c | 90 ++------------------ > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 12 +-- > drivers/gpu/drm/tilcdc/tilcdc_external.c | 68 ++------------- > drivers/gpu/drm/vc4/vc4_dpi.c | 15 +--- > include/drm/drm_of.h | 13 +++ > include/drm/drm_panel.h | 2 +- > 44 files changed, 238 insertions(+), 881 deletions(-) > > -- > 2.10.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 0/5] DRM OF graph clean-up Date: Thu, 6 Apr 2017 17:03:06 -0400 Message-ID: References: <20170322132608.17353-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yb0-x22f.google.com (mail-yb0-x22f.google.com [IPv6:2607:f8b0:4002:c09::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 748DE6E1A1 for ; Thu, 6 Apr 2017 21:03:30 +0000 (UTC) Received: by mail-yb0-x22f.google.com with SMTP id f204so13163512ybc.2 for ; Thu, 06 Apr 2017 14:03:30 -0700 (PDT) Received: from mail-yw0-f169.google.com (mail-yw0-f169.google.com. [209.85.161.169]) by smtp.gmail.com with ESMTPSA id i78sm1080753ywc.50.2017.04.06.14.03.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 14:03:27 -0700 (PDT) Received: by mail-yw0-f169.google.com with SMTP id d191so26396259ywe.2 for ; Thu, 06 Apr 2017 14:03:27 -0700 (PDT) In-Reply-To: <20170322132608.17353-1-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Neil Armstrong , Liviu Dudau , dri-devel , Tomi Valkeinen , Daniel Vetter , Marek Vasut , Kevin Hilman , Chen-Yu Tsai , Krzysztof Kozlowski , Xinliang Liu , Javier Martinez Canillas , Xinwei Kong , Kukjin Kim , Mali DP Maintainers , Chen Feng , Jyri Sarha , Carlo Caione , Russell King , Matthias Brugger , Alison Wang , Jingoo Han , Seung-Woo Kim Linux Kernel Mailing List
  • List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXIgMjIsIDIwMTcgYXQgOToyNiBBTSwgUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVs Lm9yZz4gd3JvdGU6Cj4gSSd2ZSBiZWVuIHVuaGFwcHkgd2l0aCB0aGUgT0YgZ3JhcGggQVBJIGZv ciBzb21lIHRpbWUgYW5kIGRlY2lkZWQgdG8KPiBkbyBzb21ldGhpbmcgYWJvdXQgaXQuIFRoZSBw cm9ibGVtIGlzIGRyaXZlcnMgaGF2ZSB0byBkbyB0b28gbXVjaCBvZiB0aGUKPiBncmFwaCBwYXJz aW5nIGFuZCB3YWxraW5nIHRoZW1zZWx2ZXMuIFRoaXMgaGFzIGxlZCB0byB0aGUgc2FtZSBwYXR0 ZXJuCj4gZHVwbGljYXRlZCBvdmVyIGFuZCBvdmVyLiBUaGlzIHNlcmllcyBhZGFwdHMgRFJNIGRy aXZlcnMgdG8gdXNlIGEgbmV3IE9GCj4gZ3JhcGggaGVscGVyIGFuZCBhZGRlZCBEUk0gaGVscGVy Lgo+Cj4gVGhlIERUIGRlcGVuZGVuY3kgd2VudCBpbnRvIDQuMTEsIHNvIHRoaXMgc2VyaWVzIGNh biBiZSBhcHBsaWVkIHRvIHRoZSBEUk0KPiB0cmVlIHdpdGhvdXQgYW55IGNyb3NzIHRyZWUgZGVw ZW5kZW5jaWVzLgo+Cj4gSSd2ZSBkb25lIHNvbWUgYnVpbGQgdGVzdGluZyBvbmx5LCBzbyB0ZXN0 aW5nIGFwcHJlY2lhdGVkLiBBIGdpdCBicmFuY2ggaXMKPiBoZXJlWzFdLgo+Cj4gUm9iCj4KPiBb MV0gZ2l0Oi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3JvYmgvbGlu dXguZ2l0IG9mLWdyYXBoLWhlbHBlcnMKPgo+Cj4gUm9iIEhlcnJpbmcgKDUpOgo+ICAgZHJtOiBt YWtlIG9mX2RybV9maW5kX3BhbmVsIGFsc28gZGVwZW5kIG9uIENPTkZJR19EUk1fUEFORUwKPiAg IGRybTogb2Y6IGludHJvZHVjZSBkcm1fb2ZfZmluZF9wYW5lbF9vcl9icmlkZ2UKPiAgIGRybTog Y29udmVydCBkcml2ZXJzIHRvIHVzZSBvZl9ncmFwaF9nZXRfcmVtb3RlX25vZGUKPiAgIGRybTog Y29udmVydCBkcml2ZXJzIHRvIHVzZSBkcm1fb2ZfZmluZF9wYW5lbF9vcl9icmlkZ2UKPiAgIGRy bTogb21hcDogdXNlIGNvbW1vbiBPRiBncmFwaCBoZWxwZXJzCj4KCkhpIFJvYiwKVGhhbmsgeW91 IGZvciB0aGUgc2VyaWVzLCBhbmQgc29ycnkgZm9yIHRoZSBkZWxheS4gSSd2ZSBmaXhlZCB0aGUg Mgpjb25mbGljdHMgYW5kIGFwcGxpZWQgdG8gLW1pc2MtbmV4dC4KClNlYW4KCgo+ICBkcml2ZXJz L2dwdS9kcm0vYXJtL2hkbGNkX2Rydi5jICAgICAgICAgICAgICAgICAgfCAgMjIgKy0tLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfZHJ2LmMgICAgICAgICAgICAgICAgIHwgIDI4ICst LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2F0bWVsLWhsY2RjL2F0bWVsX2hsY2RjX291dHB1dC5j IHwgIDczICsrKysrLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTEx L2Fkdjc1MzMuYyAgICAgICAgIHwgIDEyICstLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R1 bWItdmdhLWRhYy5jICAgICAgICAgICAgfCAgMTUgKy0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJp ZGdlL254cC1wdG4zNDYwLmMgICAgICAgICAgICAgfCAgMTYgKy0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vYnJpZGdlL3BhcmFkZS1wczg2MjIuYyAgICAgICAgICAgfCAgMTYgKy0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vYnJpZGdlL3RjMzU4NzY3LmMgICAgICAgICAgICAgICAgfCAgMjcgKy0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGktdGZwNDEwLmMgICAgICAgICAgICAgICB8ICAxNSAr Ky0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fb2YuYyAgICAgICAgICAgICAgICAgICAgICAgICB8 ICA1MiArKysrKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHAuYyAg ICAgICAgICAgICAgIHwgIDM1ICsrKy0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5 bm9zX2RybV9kcGkuYyAgICAgICAgICB8ICAxNiArLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9leHlu b3MvZXh5bm9zX2RybV9kc2kuYyAgICAgICAgICB8ICAxMyArLS0KPiAgZHJpdmVycy9ncHUvZHJt L2V4eW5vcy9leHlub3NfZHJtX21pYy5jICAgICAgICAgIHwgIDI1ICstLS0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vZnNsLWRjdS9mc2xfZGN1X2RybV9yZ2IuYyAgICAgICAgfCAgMzkgKystLS0tLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24va2lyaW4vZHdfZHJtX2RzaS5jICAgICB8ICAy NyArLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2hpc2lsaWNvbi9raXJpbi9raXJpbl9kcm1fZHJ2 LmMgIHwgIDMwICstLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2lteC9pbXgtbGRiLmMgICAgICAg ICAgICAgICAgICAgIHwgIDI3ICsrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaW14L3BhcmFsbGVs LWRpc3BsYXkuYyAgICAgICAgICAgfCAgMzYgKy0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcGkuYyAgICAgICAgICAgICAgIHwgIDEyICstLQo+ICBkcml2ZXJzL2dwdS9k cm0vbWVkaWF0ZWsvbXRrX2RzaS5jICAgICAgICAgICAgICAgfCAgMjMgKystLS0KPiAgZHJpdmVy cy9ncHUvZHJtL21lZGlhdGVrL210a19oZG1pLmMgICAgICAgICAgICAgIHwgIDI2ICstLS0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fdmVuY19jdmJzLmMgICAgICAgICAgfCAgMTkg Ky0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL21zbS9kc2kvZHNpX2hvc3QuYyAgICAgICAgICAgICAg IHwgICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDQvbWRwNF9rbXMuYyAgICAg ICAgICB8ICAyOCArLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9teHNmYi9teHNmYl9vdXQuYyAg ICAgICAgICAgICAgICB8ICA0MCArKy0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v ZHNzL2RwaS5jICAgICAgICAgICAgICAgIHwgICAyICstCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFw ZHJtL2Rzcy9kc2kuYyAgICAgICAgICAgICAgICB8ICAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0v b21hcGRybS9kc3MvZHNzLW9mLmMgICAgICAgICAgICAgfCAxMDIgKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZHNzL2Rzcy5jICAgICAgICAgICAgICAg IHwgIDYxICsrKy0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL2Rzcy9oZG1p NC5jICAgICAgICAgICAgICB8ICAgMyArLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9kc3Mv aGRtaTUuYyAgICAgICAgICAgICAgfCAgIDMgKy0KPiAgZHJpdmVycy9ncHUvZHJtL29tYXBkcm0v ZHNzL29tYXBkc3MuaCAgICAgICAgICAgIHwgIDExIC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21h cGRybS9kc3Mvc2RpLmMgICAgICAgICAgICAgICAgfCAgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJt L29tYXBkcm0vZHNzL3ZlbmMuYyAgICAgICAgICAgICAgIHwgICAzICstCj4gIGRyaXZlcnMvZ3B1 L2RybS9yb2NrY2hpcC9hbmFsb2dpeF9kcC1yb2NrY2hpcC5jICB8ICAyNiArLS0tLS0KPiAgZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9kcnYuYyAgICAgIHwgIDE4ICsrLS0K PiAgZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX3JnYi5jICAgICAgICAgICAgICAgIHwgIDEx ICstLQo+ICBkcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfdGNvbi5jICAgICAgICAgICAgICAg fCAgOTAgKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL3RpbGNkYy90aWxj ZGNfY3J0Yy5jICAgICAgICAgICAgIHwgIDEyICstLQo+ICBkcml2ZXJzL2dwdS9kcm0vdGlsY2Rj L3RpbGNkY19leHRlcm5hbC5jICAgICAgICAgfCAgNjggKystLS0tLS0tLS0tLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS92YzQvdmM0X2RwaS5jICAgICAgICAgICAgICAgICAgICB8ICAxNSArLS0tCj4g IGluY2x1ZGUvZHJtL2RybV9vZi5oICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAxMyAr KysKPiAgaW5jbHVkZS9kcm0vZHJtX3BhbmVsLmggICAgICAgICAgICAgICAgICAgICAgICAgIHwg ICAyICstCj4gIDQ0IGZpbGVzIGNoYW5nZWQsIDIzOCBpbnNlcnRpb25zKCspLCA4ODEgZGVsZXRp b25zKC0pCj4KPiAtLQo+IDIuMTAuMQo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=