From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbeA2OoH (ORCPT ); Mon, 29 Jan 2018 09:44:07 -0500 Received: from mail-it0-f52.google.com ([209.85.214.52]:50513 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbeA2OoF (ORCPT ); Mon, 29 Jan 2018 09:44:05 -0500 X-Google-Smtp-Source: AH8x224cTkh3mwSHT7sqrAYZNtSmH8sJwXXkycZOTFgH59VjYrjyrV2HACHNDP6ZhsVIr6lEilEu4g== MIME-Version: 1.0 In-Reply-To: <20180129091120.xs74nu75fype2amq@dell> References: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com> <20180126094839.iksjiw4xj2n62yzn@dell> <20180129091120.xs74nu75fype2amq@dell> From: Sean Paul Date: Mon, 29 Jan 2018 09:43:42 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c To: Lee Jones Cc: Randy Dunlap , Meghana Madhyastha , Daniel Thompson , Jingoo Han , Thierry Reding , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Tomi Valkeinen , Daniel Vetter , dri-devel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w0TEiD2k006800 On Mon, Jan 29, 2018 at 4:11 AM, Lee Jones wrote: > On Fri, 26 Jan 2018, Randy Dunlap wrote: > >> On 01/26/2018 01:48 AM, Lee Jones wrote: >> > On Wed, 24 Jan 2018, Meghana Madhyastha wrote: >> > >> >> Add of_find_backlight, a helper function which is a generic version >> >> of tinydrm_of_find_backlight that can be used by other drivers to avoid >> >> repetition of code and simplify things. >> >> >> >> Acked-by: Daniel Thompson >> >> Reviewed-by: Noralf Trønnes >> >> Reviewed-by: Sean Paul >> >> Signed-off-by: Meghana Madhyastha >> > >> > Nit: These should be in chronological order. >> >> Where does that tidbit of information come from? >> I have never heard or read that. > > Not sure it is documented anywhere. It appeared to be the widely > used, most sensible approach, so I adopted it a few years ago. > > This method provides us with information which would otherwise be > absent; including description of the patch submission/acceptance path > and an idea of who did what, when. > > For example: > > Original Author sign-off > Original Co-author sign-off > [Additional contributions: rebase, API changes, fix-ups] > Re-worker's sign-off > Tester's tested-by > Reviewer's acked-by/reviewed-by > Level-2 Maintainer sign-off > Level-1 Maintainer sign-off > > Are you aware of a more functional/practical/useful method? Hi Lee, Our tooling adds a Link: tag to the commit message pointing back to mailing list archives. This provides more detailed patch provenance in addition to reducing the burden on contributors to order tags correctly (I had never heard of this as a requirement either). Check out [1] if you're interested. Sean [1]- https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html > > -- > Lee Jones > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c Date: Mon, 29 Jan 2018 09:43:42 -0500 Message-ID: References: <116d160ba78be2e6dcbdcb6855622bce67da9472.1516810725.git.meghana.madhyastha@gmail.com> <20180126094839.iksjiw4xj2n62yzn@dell> <20180129091120.xs74nu75fype2amq@dell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id F00D66E536 for ; Mon, 29 Jan 2018 14:44:06 +0000 (UTC) Received: by mail-it0-x231.google.com with SMTP id u62so8561505ita.2 for ; Mon, 29 Jan 2018 06:44:06 -0800 (PST) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com. [209.85.223.180]) by smtp.gmail.com with ESMTPSA id 20sm3950448iof.43.2018.01.29.06.44.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jan 2018 06:44:04 -0800 (PST) Received: by mail-io0-f180.google.com with SMTP id f89so7847026ioj.4 for ; Mon, 29 Jan 2018 06:44:03 -0800 (PST) In-Reply-To: <20180129091120.xs74nu75fype2amq@dell> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lee Jones Cc: Daniel Thompson , Jingoo Han , Tomi Valkeinen , Randy Dunlap , Linux Kernel Mailing List , dri-devel , Thierry Reding , Meghana Madhyastha , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKYW4gMjksIDIwMTggYXQgNDoxMSBBTSwgTGVlIEpvbmVzIDxsZWUuam9uZXNAbGlu YXJvLm9yZz4gd3JvdGU6Cj4gT24gRnJpLCAyNiBKYW4gMjAxOCwgUmFuZHkgRHVubGFwIHdyb3Rl Ogo+Cj4+IE9uIDAxLzI2LzIwMTggMDE6NDggQU0sIExlZSBKb25lcyB3cm90ZToKPj4gPiBPbiBX ZWQsIDI0IEphbiAyMDE4LCBNZWdoYW5hIE1hZGh5YXN0aGEgd3JvdGU6Cj4+ID4KPj4gPj4gQWRk IG9mX2ZpbmRfYmFja2xpZ2h0LCBhIGhlbHBlciBmdW5jdGlvbiB3aGljaCBpcyBhIGdlbmVyaWMg dmVyc2lvbgo+PiA+PiBvZiB0aW55ZHJtX29mX2ZpbmRfYmFja2xpZ2h0IHRoYXQgY2FuIGJlIHVz ZWQgYnkgb3RoZXIgZHJpdmVycyB0byBhdm9pZAo+PiA+PiByZXBldGl0aW9uIG9mIGNvZGUgYW5k IHNpbXBsaWZ5IHRoaW5ncy4KPj4gPj4KPj4gPj4gQWNrZWQtYnk6IERhbmllbCBUaG9tcHNvbiA8 ZGFuaWVsLnRob21wc29uQGxpbmFyby5vcmc+Cj4+ID4+IFJldmlld2VkLWJ5OiBOb3JhbGYgVHLD uG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPj4gPj4gUmV2aWV3ZWQtYnk6IFNlYW4gUGF1bDxz ZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4+ID4+IFNpZ25lZC1vZmYtYnk6IE1lZ2hhbmEgTWFkaHlh c3RoYSA8bWVnaGFuYS5tYWRoeWFzdGhhQGdtYWlsLmNvbT4KPj4gPgo+PiA+IE5pdDogVGhlc2Ug c2hvdWxkIGJlIGluIGNocm9ub2xvZ2ljYWwgb3JkZXIuCj4+Cj4+IFdoZXJlIGRvZXMgdGhhdCB0 aWRiaXQgb2YgaW5mb3JtYXRpb24gY29tZSBmcm9tPwo+PiBJIGhhdmUgbmV2ZXIgaGVhcmQgb3Ig cmVhZCB0aGF0Lgo+Cj4gTm90IHN1cmUgaXQgaXMgZG9jdW1lbnRlZCBhbnl3aGVyZS4gIEl0IGFw cGVhcmVkIHRvIGJlIHRoZSB3aWRlbHkKPiB1c2VkLCBtb3N0IHNlbnNpYmxlIGFwcHJvYWNoLCBz byBJIGFkb3B0ZWQgaXQgYSBmZXcgeWVhcnMgYWdvLgo+Cj4gVGhpcyBtZXRob2QgcHJvdmlkZXMg dXMgd2l0aCBpbmZvcm1hdGlvbiB3aGljaCB3b3VsZCBvdGhlcndpc2UgYmUKPiBhYnNlbnQ7IGlu Y2x1ZGluZyBkZXNjcmlwdGlvbiBvZiB0aGUgcGF0Y2ggc3VibWlzc2lvbi9hY2NlcHRhbmNlIHBh dGgKPiBhbmQgYW4gaWRlYSBvZiB3aG8gZGlkIHdoYXQsIHdoZW4uCj4KPiBGb3IgZXhhbXBsZToK Pgo+IE9yaWdpbmFsIEF1dGhvciBzaWduLW9mZgo+IE9yaWdpbmFsIENvLWF1dGhvciBzaWduLW9m Zgo+IFtBZGRpdGlvbmFsIGNvbnRyaWJ1dGlvbnM6IHJlYmFzZSwgQVBJIGNoYW5nZXMsIGZpeC11 cHNdCj4gUmUtd29ya2VyJ3Mgc2lnbi1vZmYKPiBUZXN0ZXIncyB0ZXN0ZWQtYnkKPiBSZXZpZXdl cidzIGFja2VkLWJ5L3Jldmlld2VkLWJ5Cj4gTGV2ZWwtMiBNYWludGFpbmVyIHNpZ24tb2ZmCj4g TGV2ZWwtMSBNYWludGFpbmVyIHNpZ24tb2ZmCj4KPiBBcmUgeW91IGF3YXJlIG9mIGEgbW9yZSBm dW5jdGlvbmFsL3ByYWN0aWNhbC91c2VmdWwgbWV0aG9kPwoKCkhpIExlZSwKT3VyIHRvb2xpbmcg YWRkcyBhIExpbms6IHRhZyB0byB0aGUgY29tbWl0IG1lc3NhZ2UgcG9pbnRpbmcgYmFjayB0bwpt YWlsaW5nIGxpc3QgYXJjaGl2ZXMuIFRoaXMgcHJvdmlkZXMgbW9yZSBkZXRhaWxlZCBwYXRjaCBw cm92ZW5hbmNlIGluCmFkZGl0aW9uIHRvIHJlZHVjaW5nIHRoZSBidXJkZW4gb24gY29udHJpYnV0 b3JzIHRvIG9yZGVyIHRhZ3MKY29ycmVjdGx5IChJIGhhZCBuZXZlciBoZWFyZCBvZiB0aGlzIGFz IGEgcmVxdWlyZW1lbnQgZWl0aGVyKS4gQ2hlY2sKb3V0IFsxXSAgaWYgeW91J3JlIGludGVyZXN0 ZWQuCgpTZWFuCgpbMV0tIGh0dHBzOi8vMDEub3JnL2xpbnV4Z3JhcGhpY3MvZ2Z4LWRvY3MvbWFp bnRhaW5lci10b29scy9kaW0uaHRtbAoKPgo+IC0tCj4gTGVlIEpvbmVzCj4gTGluYXJvIFNlcnZp Y2VzIFRlY2huaWNhbCBMZWFkCj4gTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUg Zm9yIEFSTSBTb0NzCj4gRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK