From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sean Paul <seanpaul@chromium.org>
Subject: Re: [PATCH 08/13] drm: prevent double-(un)registration
	for connectors
Date: Fri, 16 Dec 2016 10:03:26 -0500
Message-ID: <CAOw6vbKv3JkQ=K2S6f-z_uH-G+hT_VLG2MAdBdRkqDLfwrKG9w@mail.gmail.com>
References: <20161213230814.19598-1-daniel.vetter@ffwll.ch>
 <20161213230814.19598-9-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20161213230814.19598-9-daniel.vetter@ffwll.ch>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

T24gVHVlLCBEZWMgMTMsIDIwMTYgYXQgNjowOCBQTSwgRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl
dHRlckBmZndsbC5jaD4gd3JvdGU6Cj4gSWYgd2UncmUgdW5sdWNreSB0aGVuIHRoZSByZWdpc3Ry
YXRpb24gZnJvbSBhIGhvdHBsdWdnZWQgY29ubmVjdG9yCj4gbWlnaHQgcmFjZSB3aXRoIHRoZSBm
aW5hbCByZWdpc3RyYXRpb24gc3RlcCBvbiBkcml2ZXIgbG9hZC4gQW5kIHNpbmNlCj4gTVNUIHRv
cG9sb2d5IGRpc2NvdmVyIGlzIGFzeW5jaHJvbm91cyB0aGF0J3MgZXZlbiBzb21ld2hhdCBsaWtl
bHkuCj4KPiB2MjogQWxzbyB1cGRhdGUgdGhlIGtlcm5lbGRvYyBmb3IgQHJlZ2lzdGVyZWQhCj4K
PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gUmVwb3J0ZWQt
Ynk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgoKCldpdGggQ2hyaXMn
IHN1Z2dlc3RlZCBpbXByb3ZlbWVudHMKClJldmlld2VkLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVs
QGNocm9taXVtLm9yZz4KCj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZl
dHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMg
fCAxOCArKysrKysrKysrKysrLS0tLS0KPiAgaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oICAg
ICB8IDEyICsrKysrKysrKysrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyks
IDYgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jb25u
ZWN0b3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMKPiBpbmRleCBiMzMzMzRl
MDliMDAuLjBkNDcyODcwNDA5OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nv
bm5lY3Rvci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYwo+IEBAIC0y
MjMsNiArMjIzLDcgQEAgaW50IGRybV9jb25uZWN0b3JfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAq
ZGV2LAo+Cj4gICAgICAgICBJTklUX0xJU1RfSEVBRCgmY29ubmVjdG9yLT5wcm9iZWRfbW9kZXMp
Owo+ICAgICAgICAgSU5JVF9MSVNUX0hFQUQoJmNvbm5lY3Rvci0+bW9kZXMpOwo+ICsgICAgICAg
bXV0ZXhfaW5pdCgmY29ubmVjdG9yLT5tdXRleCk7Cj4gICAgICAgICBjb25uZWN0b3ItPmVkaWRf
YmxvYl9wdHIgPSBOVUxMOwo+ICAgICAgICAgY29ubmVjdG9yLT5zdGF0dXMgPSBjb25uZWN0b3Jf
c3RhdHVzX3Vua25vd247Cj4KPiBAQCAtMzczLDE0ICszNzQsMTUgQEAgRVhQT1JUX1NZTUJPTChk
cm1fY29ubmVjdG9yX2NsZWFudXApOwo+ICAgKi8KPiAgaW50IGRybV9jb25uZWN0b3JfcmVnaXN0
ZXIoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgewo+IC0gICAgICAgaW50IHJl
dDsKPiArICAgICAgIGludCByZXQgPSAwOwo+Cj4gKyAgICAgICBtdXRleF9sb2NrKCZjb25uZWN0
b3ItPm11dGV4KTsKPiAgICAgICAgIGlmIChjb25uZWN0b3ItPnJlZ2lzdGVyZWQpCj4gLSAgICAg
ICAgICAgICAgIHJldHVybiAwOwo+ICsgICAgICAgICAgICAgICBnb3RvIHVubG9jazsKPgo+ICAg
ICAgICAgcmV0ID0gZHJtX3N5c2ZzX2Nvbm5lY3Rvcl9hZGQoY29ubmVjdG9yKTsKPiAgICAgICAg
IGlmIChyZXQpCj4gLSAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gKyAgICAgICAgICAgICAg
IGdvdG8gdW5sb2NrOwo+Cj4gICAgICAgICByZXQgPSBkcm1fZGVidWdmc19jb25uZWN0b3JfYWRk
KGNvbm5lY3Rvcik7Cj4gICAgICAgICBpZiAocmV0KSB7Cj4gQEAgLTM5NiwxMiArMzk4LDE0IEBA
IGludCBkcm1fY29ubmVjdG9yX3JlZ2lzdGVyKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0
b3IpCj4gICAgICAgICBkcm1fbW9kZV9vYmplY3RfcmVnaXN0ZXIoY29ubmVjdG9yLT5kZXYsICZj
b25uZWN0b3ItPmJhc2UpOwo+Cj4gICAgICAgICBjb25uZWN0b3ItPnJlZ2lzdGVyZWQgPSB0cnVl
Owo+IC0gICAgICAgcmV0dXJuIDA7Cj4gKyAgICAgICBnb3RvIHVubG9jazsKPgo+ICBlcnJfZGVi
dWdmczoKPiAgICAgICAgIGRybV9kZWJ1Z2ZzX2Nvbm5lY3Rvcl9yZW1vdmUoY29ubmVjdG9yKTsK
PiAgZXJyX3N5c2ZzOgo+ICAgICAgICAgZHJtX3N5c2ZzX2Nvbm5lY3Rvcl9yZW1vdmUoY29ubmVj
dG9yKTsKPiArdW5sb2NrOgo+ICsgICAgICAgbXV0ZXhfdW5sb2NrKCZjb25uZWN0b3ItPm11dGV4
KTsKPiAgICAgICAgIHJldHVybiByZXQ7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fY29ubmVj
dG9yX3JlZ2lzdGVyKTsKPiBAQCAtNDE0LDggKzQxOCwxMSBAQCBFWFBPUlRfU1lNQk9MKGRybV9j
b25uZWN0b3JfcmVnaXN0ZXIpOwo+ICAgKi8KPiAgdm9pZCBkcm1fY29ubmVjdG9yX3VucmVnaXN0
ZXIoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgewo+IC0gICAgICAgaWYgKCFj
b25uZWN0b3ItPnJlZ2lzdGVyZWQpCj4gKyAgICAgICBtdXRleF9sb2NrKCZjb25uZWN0b3ItPm11
dGV4KTsKPiArICAgICAgIGlmICghY29ubmVjdG9yLT5yZWdpc3RlcmVkKSB7Cj4gKyAgICAgICAg
ICAgICAgIG11dGV4X3VubG9jaygmY29ubmVjdG9yLT5tdXRleCk7Cj4gICAgICAgICAgICAgICAg
IHJldHVybjsKPiArICAgICAgIH0KPgo+ICAgICAgICAgaWYgKGNvbm5lY3Rvci0+ZnVuY3MtPmVh
cmx5X3VucmVnaXN0ZXIpCj4gICAgICAgICAgICAgICAgIGNvbm5lY3Rvci0+ZnVuY3MtPmVhcmx5
X3VucmVnaXN0ZXIoY29ubmVjdG9yKTsKPiBAQCAtNDI0LDYgKzQzMSw3IEBAIHZvaWQgZHJtX2Nv
bm5lY3Rvcl91bnJlZ2lzdGVyKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gICAg
ICAgICBkcm1fZGVidWdmc19jb25uZWN0b3JfcmVtb3ZlKGNvbm5lY3Rvcik7Cj4KPiAgICAgICAg
IGNvbm5lY3Rvci0+cmVnaXN0ZXJlZCA9IGZhbHNlOwo+ICsgICAgICAgbXV0ZXhfdW5sb2NrKCZj
b25uZWN0b3ItPm11dGV4KTsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9jb25uZWN0b3JfdW5y
ZWdpc3Rlcik7Cj4KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oIGIv
aW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gaW5kZXggMGU0MWEyZTE4NGE5Li5hMjQ1NTll
ZjhiYjcgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gKysrIGIv
aW5jbHVkZS9kcm0vZHJtX2Nvbm5lY3Rvci5oCj4gQEAgLTU1OSw3ICs1NTksNiBAQCBzdHJ1Y3Qg
ZHJtX2NtZGxpbmVfbW9kZSB7Cj4gICAqIEBpbnRlcmxhY2VfYWxsb3dlZDogY2FuIHRoaXMgY29u
bmVjdG9yIGhhbmRsZSBpbnRlcmxhY2VkIG1vZGVzPwo+ICAgKiBAZG91Ymxlc2Nhbl9hbGxvd2Vk
OiBjYW4gdGhpcyBjb25uZWN0b3IgaGFuZGxlIGRvdWJsZXNjYW4/Cj4gICAqIEBzdGVyZW9fYWxs
b3dlZDogY2FuIHRoaXMgY29ubmVjdG9yIGhhbmRsZSBzdGVyZW8gbW9kZXM/Cj4gLSAqIEByZWdp
c3RlcmVkOiBpcyB0aGlzIGNvbm5lY3RvciBleHBvc2VkIChyZWdpc3RlcmVkKSB3aXRoIHVzZXJz
cGFjZT8KPiAgICogQG1vZGVzOiBtb2RlcyBhdmFpbGFibGUgb24gdGhpcyBjb25uZWN0b3IgKGZy
b20gZmlsbF9tb2RlcygpICsgdXNlcikKPiAgICogQHN0YXR1czogb25lIG9mIHRoZSBkcm1fY29u
bmVjdG9yX3N0YXR1cyBlbnVtcyAoY29ubmVjdGVkLCBub3QsIG9yIHVua25vd24pCj4gICAqIEBw
cm9iZWRfbW9kZXM6IGxpc3Qgb2YgbW9kZXMgZGVyaXZlZCBkaXJlY3RseSBmcm9tIHRoZSBkaXNw
bGF5Cj4gQEAgLTYwOCw2ICs2MDcsMTMgQEAgc3RydWN0IGRybV9jb25uZWN0b3Igewo+ICAgICAg
ICAgY2hhciAqbmFtZTsKPgo+ICAgICAgICAgLyoqCj4gKyAgICAgICAgKiBAbXV0ZXg6IExvY2sg
Zm9yIGdlbmVyYWwgY29ubmVjdG9yIHN0YXRlLCBidXQgY3VycmVudGx5IG9ubHkgcHJvdGVjdHMK
PiArICAgICAgICAqIEByZWdpc3RlcmVkLiBNb3N0IG9mIHRoZSBjb25uZWN0b3Igc3RhdGUgaXMg
c3RpbGwgcHJvdGVjdGVkIGJ5IHRoZQo+ICsgICAgICAgICogbXV0ZXggaW4gJmRybV9tb2RlX2Nv
bmZpZy4KPiArICAgICAgICAqLwo+ICsgICAgICAgc3RydWN0IG11dGV4IG11dGV4Owo+ICsKPiAr
ICAgICAgIC8qKgo+ICAgICAgICAgICogQGluZGV4OiBDb21wYWN0ZWQgY29ubmVjdG9yIGluZGV4
LCB3aGljaCBtYXRjaGVzIHRoZSBwb3NpdGlvbiBpbnNpZGUKPiAgICAgICAgICAqIHRoZSBtb2Rl
X2NvbmZpZy5saXN0IGZvciBkcml2ZXJzIG5vdCBzdXBwb3J0aW5nIGhvdC1hZGQvcmVtb3Zpbmcu
IENhbgo+ICAgICAgICAgICogYmUgdXNlZCBhcyBhbiBhcnJheSBpbmRleC4gSXQgaXMgaW52YXJp
YW50IG92ZXIgdGhlIGxpZmV0aW1lIG9mIHRoZQo+IEBAIC02MjAsNiArNjI2LDEwIEBAIHN0cnVj
dCBkcm1fY29ubmVjdG9yIHsKPiAgICAgICAgIGJvb2wgaW50ZXJsYWNlX2FsbG93ZWQ7Cj4gICAg
ICAgICBib29sIGRvdWJsZXNjYW5fYWxsb3dlZDsKPiAgICAgICAgIGJvb2wgc3RlcmVvX2FsbG93
ZWQ7Cj4gKyAgICAgICAvKioKPiArICAgICAgICAqIEByZWdpc3RlcmVkOiBJcyB0aGlzIGNvbm5l
Y3RvciBleHBvc2VkIChyZWdpc3RlcmVkKSB3aXRoIHVzZXJzcGFjZT8KPiArICAgICAgICAqIFBy
b3RlY3RlZCBieSBAbXV0ZXguCj4gKyAgICAgICAgKi8KPiAgICAgICAgIGJvb2wgcmVnaXN0ZXJl
ZDsKPiAgICAgICAgIHN0cnVjdCBsaXN0X2hlYWQgbW9kZXM7IC8qIGxpc3Qgb2YgbW9kZXMgb24g
dGhpcyBjb25uZWN0b3IgKi8KPgo+IC0tCj4gMi4xMS4wCj4KPiBfX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBk
cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv
cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCgoKLS0gClNlYW4gUGF1bCwgU29mdHdh
cmUgRW5naW5lZXIsIEdvb2dsZSAvIENocm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=