From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabien Parent Subject: Re: [PATCH 09/24] mmc: mtk-sd: check for valid optional memory resource Date: Sun, 24 Mar 2019 16:18:45 +0100 Message-ID: References: <20190323211612.860-1-fparent@baylibre.com> <20190323211612.860-10-fparent@baylibre.com> <1553398466.26628.0.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1553398466.26628.0.camel@mtksdaap41> Sender: linux-kernel-owner@vger.kernel.org To: Yingjoe Chen Cc: Matthias Brugger , robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, ryder.lee@mediatek.com, linux-watchdog@vger.kernel.org, jjian.zhou@mediatek.com, wenzhen.yu@mediatek.com, Stephane Le Provost , sean.wang@kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, yong.mao@mediatek.com, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, hsin-hsiung.wang@mediatek.com, linux-serial@vger.kernel.org, linux-clk@vger.kernel.org, Chaotian Jing , linux-i2c@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On Sun, Mar 24, 2019 at 4:34 AM Yingjoe Chen wrote: > > On Sat, 2019-03-23 at 22:15 +0100, Fabien Parent wrote: > > 'top_base' memory region is optional. Check that the resource is valid > > before using it. This avoid getting a "invalid resource" error message > > printed by the kernel. > > > > Signed-off-by: Fabien Parent > > --- > > drivers/mmc/host/mtk-sd.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > > index 833ef0590af8..573aa127d00b 100644 > > --- a/drivers/mmc/host/mtk-sd.c > > +++ b/drivers/mmc/host/mtk-sd.c > > @@ -2123,9 +2123,11 @@ static int msdc_drv_probe(struct platform_device *pdev) > > } > > > > res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > - host->top_base = devm_ioremap_resource(&pdev->dev, res); > > - if (IS_ERR(host->top_base)) > > - host->top_base = NULL; > > + if (ret) { > > This should be res? Indeed. Thanks, I will fix it in v2. > > + host->top_base = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(host->top_base)) > > + host->top_base = NULL; > > + } > > > > ret = mmc_regulator_get_supply(mmc); > > if (ret) > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 087A2C43381 for ; Sun, 24 Mar 2019 15:19:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98A962075C for ; Sun, 24 Mar 2019 15:19:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jKi3ggM5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="mQUHe/2T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98A962075C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Rmjy29prYIS/NEl4rOwWTt/azsGTRgO9OfD8/Sip2WM=; b=jKi3ggM52jhUQf XNTmcqL2WvSMlZkR7VnPl+ayoOlXLTQcKlO7uukB6wVGREJjjEVxhkl2fuABREdK5JDv1WCkQ9Sxs H5jCX916XGYlMbxlhBKt/g2vbDPaFr37Ca38TrKbuIejjXXPDsQobDmXLtweGhkb2NSYgr1D54fly azpyBFpC0YYWMjjnrDv2v14p9NCR/Gw9sz3CxcmG72GAKx5bngOMobSiBV2WdYOvLf8rbA1M+ViPf duEJIGoEBMgkn9lVg8OBkfuczRMZlDbGg30ft57xlK6jEl0dKb4qLbZAkKR06Q0G+t6th/RDRFtwd mX932XCPgV9jspv+LO4Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h84tt-0007ee-0P; Sun, 24 Mar 2019 15:19:05 +0000 Received: from mail-it1-x144.google.com ([2607:f8b0:4864:20::144]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h84tm-0007cK-2O for linux-arm-kernel@lists.infradead.org; Sun, 24 Mar 2019 15:19:02 +0000 Received: by mail-it1-x144.google.com with SMTP id v8so9411332itf.0 for ; Sun, 24 Mar 2019 08:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LA6GXUCgoW4lEEmR/LMufysHJYXyTKx9RuJsaqKLxUA=; b=mQUHe/2T27VeYzPtkFZWO1opnsxSqurAU0juAhv8EYg793y8UFMp/YczASj+Er6Z3r e85zNaO4H+71QAWIfcCYz9gh+g0W9X1kULySVZDNKRZaI1YDpVgkgR8dXUxaqWkBbwCA b35aoGlfuXQBqmOsZNDNvK4+SjOE6mzMHAA8iFANLLbsDkfFqmPmQFJNuAcYbqcHVxKW xglcSytksG3tFjvpVEh/g05uCObI7wJhkJasPFgnE2sKeGtJKZ+jBe78z3xlUTRDKpX3 P8ubfmY3jOhP2iixXc7eyPmcN+N1D0dq2Jge/QydJky8x8i4g52kQPlD7baUo7XgyeAx FCIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LA6GXUCgoW4lEEmR/LMufysHJYXyTKx9RuJsaqKLxUA=; b=ra8jfI5cb7CgoNCSsLS6EHT7x7RGtu5bceSI4dksepZ2yvR0GzBVUOYrlBqvkFO6VI TEQ0nTyhjeARn777AsdEqKmxbdp7ZwU7MfBgh69CgZqbdjcgmZezXpw+IEj+CpacuYPx +yA7fxOpIzgq65/vRuHhhtIMaYO9MDzSsXMNurDxW+D6ybJOonsPlJlvyP9mNIGNHK54 zWzd7OmLOO+JhHgL9SCJ8w6VWApDlDdxUIhiWTozbGHnojwPEmZcII8Xm53kJye37uRd PxCWV6C71FN79ZJN1Z1Ns8JGMPe3cgZwOjadXJgo+KJ8TJ00t1FlwbKeX/OEHYX9Wk9h toKg== X-Gm-Message-State: APjAAAXJBsW4zYksBv97xgL5diEs3y3S+AQOqCUnOYlMNhWc1q+W7qAq oIyoSpFZ59fo3m2O6LiBihghO7c+oc33MLnDj4H7iw== X-Google-Smtp-Source: APXvYqw8WMiyqKB6zM8rvKiZfNagZNLvEHPd2d2+gxclGYL+TMCJXc47XLd0mHezierdMyacId2wPEUkNlQ/mF1nTnc= X-Received: by 2002:a24:3c4c:: with SMTP id m73mr8815805ita.23.1553440736289; Sun, 24 Mar 2019 08:18:56 -0700 (PDT) MIME-Version: 1.0 References: <20190323211612.860-1-fparent@baylibre.com> <20190323211612.860-10-fparent@baylibre.com> <1553398466.26628.0.camel@mtksdaap41> In-Reply-To: <1553398466.26628.0.camel@mtksdaap41> From: Fabien Parent Date: Sun, 24 Mar 2019 16:18:45 +0100 Message-ID: Subject: Re: [PATCH 09/24] mmc: mtk-sd: check for valid optional memory resource To: Yingjoe Chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190324_081858_257544_3F61BDAE X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, wenzhen.yu@mediatek.com, linux-i2c@vger.kernel.org, linux-clk@vger.kernel.org, hsin-hsiung.wang@mediatek.com, ryder.lee@mediatek.com, jjian.zhou@mediatek.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, Stephane Le Provost , linux-gpio@vger.kernel.org, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Chaotian Jing , linux-arm-kernel@lists.infradead.org, sean.wang@kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, yong.mao@mediatek.com, linux-spi@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 24, 2019 at 4:34 AM Yingjoe Chen wrote: > > On Sat, 2019-03-23 at 22:15 +0100, Fabien Parent wrote: > > 'top_base' memory region is optional. Check that the resource is valid > > before using it. This avoid getting a "invalid resource" error message > > printed by the kernel. > > > > Signed-off-by: Fabien Parent > > --- > > drivers/mmc/host/mtk-sd.c | 8 +++++--- > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > > index 833ef0590af8..573aa127d00b 100644 > > --- a/drivers/mmc/host/mtk-sd.c > > +++ b/drivers/mmc/host/mtk-sd.c > > @@ -2123,9 +2123,11 @@ static int msdc_drv_probe(struct platform_device *pdev) > > } > > > > res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > > - host->top_base = devm_ioremap_resource(&pdev->dev, res); > > - if (IS_ERR(host->top_base)) > > - host->top_base = NULL; > > + if (ret) { > > This should be res? Indeed. Thanks, I will fix it in v2. > > + host->top_base = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(host->top_base)) > > + host->top_base = NULL; > > + } > > > > ret = mmc_regulator_get_supply(mmc); > > if (ret) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel