From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751281AbdDCENw (ORCPT ); Mon, 3 Apr 2017 00:13:52 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:34424 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbdDCENv (ORCPT ); Mon, 3 Apr 2017 00:13:51 -0400 MIME-Version: 1.0 In-Reply-To: <1490812390-27905-1-git-send-email-prasant.jalan@gmail.com> References: <1490812390-27905-1-git-send-email-prasant.jalan@gmail.com> From: Prasant Jalan Date: Mon, 3 Apr 2017 09:43:50 +0530 Message-ID: Subject: Re: [PATCH] staging: rtl8712: fixed multiple line derefence issue To: Larry.Finger@lwfinger.net Cc: Florian Schilhabel , Greg KH , geliangtang@163.com, raphael.beamonte@gmail.com, vijaikumar.kanagarajan@gmail.com, Souptick Joarder , driverdevel , LKML , Prasant Jalan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 30, 2017 at 12:03 AM, Prasant Jalan wrote: > Checkpatch emits WARNING: Avoid multiple line dereference. > > Trivial indentation improvement helps fix the checkpatch warning. > > Signed-off-by: Prasant Jalan > --- > drivers/staging/rtl8712/rtl871x_xmit.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > index de88819..10edf00 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > @@ -213,8 +213,9 @@ sint r8712_update_attrib(struct _adapter *padapter, _pkt *pkt, > if (padapter->pwrctrlpriv.pwr_mode != > padapter->registrypriv.power_mgnt) { > del_timer_sync(&pmlmepriv->dhcp_timer); > - r8712_set_ps_mode(padapter, padapter->registrypriv. > - power_mgnt, padapter->registrypriv.smart_ps); > + r8712_set_ps_mode(padapter, > + padapter->registrypriv.power_mgnt, > + padapter->registrypriv.smart_ps); > } > } > } > @@ -416,15 +417,14 @@ static sint xmitframe_addmic(struct _adapter *padapter, > &pframe[10], 6); > } > if (pqospriv->qos_option == 1) > - priority[0] = (u8)pxmitframe-> > - attrib.priority; > + priority[0] = (u8)pxmitframe->attrib.priority; > r8712_secmicappend(&micdata, &priority[0], 4); > payload = pframe; > for (curfragnum = 0; curfragnum < pattrib->nr_frags; > curfragnum++) { > payload = (u8 *)RND4((addr_t)(payload)); > - payload = payload + pattrib-> > - hdrlen + pattrib->iv_len; > + payload = payload + pattrib->hdrlen + > + pattrib->iv_len; > if ((curfragnum + 1) == pattrib->nr_frags) { > length = pattrib->last_txcmdsz - > pattrib->hdrlen - > -- > 2.7.4 > Hi all, A gentle reminder for my small patch. Some comments will be most helpful. Regards, Prasant Jalan