From: James Carter <jwcart2@gmail.com>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH 3/6] libsepol/cil: remove stray printf
Date: Mon, 15 Mar 2021 17:03:45 -0400 [thread overview]
Message-ID: <CAP+JOzRd=zVaEnE1vTfjqen-rRYwDUUWyO=K=FYhe+TzHc+KhQ@mail.gmail.com> (raw)
In-Reply-To: <20210314201651.474432-3-nicolas.iooss@m4x.org>
On Sun, Mar 14, 2021 at 4:22 PM Nicolas Iooss <nicolas.iooss@m4x.org> wrote:
>
> printf("%i\n", node->flavor); looks very much like a statement which was
> added for debugging purpose and was unintentionally left.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss@m4x.org>
Acked-by: James Carter <jwcart2@gmail.com>
> ---
> libsepol/cil/src/cil_resolve_ast.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libsepol/cil/src/cil_resolve_ast.c b/libsepol/cil/src/cil_resolve_ast.c
> index 0e07856133e5..47cdf0e7c0b9 100644
> --- a/libsepol/cil/src/cil_resolve_ast.c
> +++ b/libsepol/cil/src/cil_resolve_ast.c
> @@ -1088,7 +1088,6 @@ int cil_resolve_roletransition(struct cil_tree_node *current, void *extra_args)
> node = NODE(result_datum);
> if (node->flavor != CIL_ROLE) {
> rc = SEPOL_ERR;
> - printf("%i\n", node->flavor);
> cil_log(CIL_ERR, "roletransition must result in a role, but %s is a %s\n", roletrans->result_str, cil_node_to_string(node));
> goto exit;
> }
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-03-15 21:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-14 20:16 [PATCH 1/6] libsepol/cil: fix out-of-bound read of a file context pattern ending with "\" Nicolas Iooss
2021-03-14 20:16 ` [PATCH 2/6] libsepol/cil: make cil_post_fc_fill_data static Nicolas Iooss
2021-03-15 21:03 ` James Carter
2021-03-17 8:39 ` Nicolas Iooss
2021-03-14 20:16 ` [PATCH 3/6] libsepol/cil: remove stray printf Nicolas Iooss
2021-03-15 21:03 ` James Carter [this message]
2021-03-14 20:16 ` [PATCH 4/6] libsepol/cil: replace printf with proper cil_tree_log Nicolas Iooss
2021-03-15 21:04 ` James Carter
2021-03-14 20:16 ` [PATCH 5/6] libsepol/cil: fix NULL pointer dereference in __cil_insert_name Nicolas Iooss
2021-03-15 21:05 ` James Carter
2021-03-14 20:16 ` [PATCH 6/6] libsepol/cil: do not leak avrulex_ioctl_table memory when an error occurs Nicolas Iooss
2021-03-15 21:05 ` James Carter
2021-03-15 21:02 ` [PATCH 1/6] libsepol/cil: fix out-of-bound read of a file context pattern ending with "\" James Carter
2021-03-15 21:34 ` Nicolas Iooss
2021-03-16 13:34 ` James Carter
2021-03-17 7:45 ` Nicolas Iooss
2021-03-17 14:35 ` James Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP+JOzRd=zVaEnE1vTfjqen-rRYwDUUWyO=K=FYhe+TzHc+KhQ@mail.gmail.com' \
--to=jwcart2@gmail.com \
--cc=nicolas.iooss@m4x.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.