From: James Carter <jwcart2@gmail.com>
To: "Christian Göttsche" <cgzones@googlemail.com>
Cc: SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH 00/23] libsepol: miscellaneous cleanup
Date: Thu, 24 Jun 2021 10:29:37 -0400 [thread overview]
Message-ID: <CAP+JOzRk_uDaap97b22qxOba08K-0VVBCH7nQaKBXcVa+k=GfQ@mail.gmail.com> (raw)
In-Reply-To: <20210608155912.32047-1-cgzones@googlemail.com>
On Tue, Jun 8, 2021 at 12:00 PM Christian Göttsche
<cgzones@googlemail.com> wrote:
>
> Clean up several code smells, compiler warnings, static analyzer issues
> and UBSAN findings in libsepol.
>
> Also declare local functions and variables static and some interface
> parameters const to improve maintainability.
>
> Christian Göttsche (23):
> libsepol: fix typos
> libsepol: resolve missing prototypes
> libsepol: remove unused functions
> libsepol: ignore UBSAN false-positives
> libsepol: avoid implicit conversions
> libsepol: avoid unsigned integer overflow
> libsepol: follow declaration-after-statement
> libsepol/cil: follow declaration-after-statement
> libsepol: remove dead stores
> libsepol: mark read-only parameters of ebitmap interfaces const
> libsepol: mark read-only parameters of type_set_ interfaces const
> libsepol: do not allocate memory of size 0
> libsepol: assure string NUL-termination
> libsepol: remove dead stores
> libsepol/cil: silence cast warning
> libsepol/cil: drop extra semicolon
> libsepol/cil: drop dead store
> libsepol/cil: drop unnecessary casts
> libsepol/cil: avoid using maybe uninitialized variables
> libsepol: drop repeated semicolons
> libsepol: drop unnecessary casts
> libsepol: declare file local variable static
> libsepol: declare read-only arrays const
>
> libsepol/cil/src/cil_binary.c | 19 +--
> libsepol/cil/src/cil_build_ast.c | 9 +-
> libsepol/cil/src/cil_fqn.c | 3 +-
> libsepol/cil/src/cil_list.c | 7 +-
> libsepol/cil/src/cil_post.c | 2 +-
> libsepol/cil/src/cil_resolve_ast.c | 8 +-
> libsepol/cil/src/cil_strpool.c | 16 +--
> libsepol/cil/src/cil_write_ast.c | 4 +-
> libsepol/include/sepol/policydb/conditional.h | 2 +-
> libsepol/include/sepol/policydb/ebitmap.h | 16 +--
> libsepol/include/sepol/policydb/policydb.h | 6 +-
> libsepol/src/assertion.c | 2 +-
> libsepol/src/avrule_block.c | 2 +-
> libsepol/src/avtab.c | 8 +-
> libsepol/src/booleans.c | 6 +-
> libsepol/src/conditional.c | 3 -
> libsepol/src/context_internal.h | 1 +
> libsepol/src/debug.c | 2 +-
> libsepol/src/ebitmap.c | 29 +++--
> libsepol/src/expand.c | 8 +-
> libsepol/src/ibendport_record.c | 4 +-
> libsepol/src/kernel_to_cil.c | 7 +-
> libsepol/src/kernel_to_conf.c | 5 +-
> libsepol/src/link.c | 2 +-
> libsepol/src/module.c | 2 +-
> libsepol/src/module_to_cil.c | 14 +-
> libsepol/src/nodes.c | 6 +-
> libsepol/src/polcaps.c | 2 +-
> libsepol/src/policydb.c | 70 +++++-----
> libsepol/src/policydb_internal.h | 2 +-
> libsepol/src/policydb_validate.c | 2 +-
> libsepol/src/private.h | 6 +-
> libsepol/src/services.c | 120 ++++++------------
> libsepol/src/sidtab.c | 31 -----
> libsepol/src/symtab.c | 6 +
> libsepol/src/util.c | 2 +-
> libsepol/src/write.c | 8 +-
> 37 files changed, 187 insertions(+), 255 deletions(-)
>
> --
> 2.32.0
>
Merged all the patches except for 0004, 0005, and 0013 which still
have outstanding comments.
Thanks,
Jim
prev parent reply other threads:[~2021-06-24 14:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 15:58 [PATCH 00/23] libsepol: miscellaneous cleanup Christian Göttsche
2021-06-08 15:58 ` [PATCH 01/23] libsepol: fix typos Christian Göttsche
2021-06-21 20:54 ` James Carter
2021-06-08 15:58 ` [PATCH 02/23] libsepol: resolve missing prototypes Christian Göttsche
2021-06-21 20:55 ` James Carter
2021-06-08 15:58 ` [PATCH 03/23] libsepol: remove unused functions Christian Göttsche
2021-06-21 20:54 ` James Carter
2021-06-08 15:58 ` [PATCH 04/23] libsepol: ignore UBSAN false-positives Christian Göttsche
2021-06-09 13:44 ` Ondrej Mosnacek
2021-06-09 14:05 ` James Carter
2021-07-01 18:06 ` [PATCH v2 1/3] " Christian Göttsche
2021-07-12 7:34 ` Nicolas Iooss
2021-07-13 19:59 ` Nicolas Iooss
2021-06-08 15:58 ` [PATCH 05/23] libsepol: avoid implicit conversions Christian Göttsche
2021-06-09 13:47 ` Ondrej Mosnacek
2021-07-01 18:06 ` [PATCH v2 2/3] " Christian Göttsche
2021-07-12 7:36 ` Nicolas Iooss
2021-07-13 20:01 ` Nicolas Iooss
2021-06-08 15:58 ` [PATCH 06/23] libsepol: avoid unsigned integer overflow Christian Göttsche
2021-06-21 20:58 ` James Carter
2021-06-08 15:58 ` [PATCH 07/23] libsepol: follow declaration-after-statement Christian Göttsche
2021-06-21 20:57 ` James Carter
2021-06-08 15:58 ` [PATCH 08/23] libsepol/cil: " Christian Göttsche
2021-06-21 20:56 ` James Carter
2021-06-08 15:58 ` [PATCH 09/23] libsepol: remove dead stores Christian Göttsche
2021-06-08 15:58 ` [PATCH 10/23] libsepol: mark read-only parameters of ebitmap interfaces const Christian Göttsche
2021-06-21 20:55 ` James Carter
2021-06-08 15:59 ` [PATCH 11/23] libsepol: mark read-only parameters of type_set_ " Christian Göttsche
2021-06-21 20:58 ` James Carter
2021-06-08 15:59 ` [PATCH 12/23] libsepol: do not allocate memory of size 0 Christian Göttsche
2021-06-21 20:59 ` James Carter
2021-06-08 15:59 ` [PATCH 13/23] libsepol: assure string NUL-termination Christian Göttsche
2021-06-09 14:38 ` James Carter
2021-07-01 18:07 ` [PATCH v2 3/3] libsepol: assure string NUL-termination of ibdev_name Christian Göttsche
2021-07-12 7:35 ` Nicolas Iooss
2021-07-13 19:59 ` Nicolas Iooss
2021-06-08 15:59 ` [PATCH 14/23] libsepol: remove dead stores Christian Göttsche
2021-06-08 15:59 ` [PATCH 15/23] libsepol/cil: silence cast warning Christian Göttsche
2021-06-21 20:58 ` James Carter
2021-06-08 15:59 ` [PATCH 16/23] libsepol/cil: drop extra semicolon Christian Göttsche
2021-06-21 20:57 ` James Carter
2021-06-08 15:59 ` [PATCH 17/23] libsepol/cil: drop dead store Christian Göttsche
2021-06-21 20:56 ` James Carter
2021-06-08 15:59 ` [PATCH 18/23] libsepol/cil: drop unnecessary casts Christian Göttsche
2021-06-21 20:55 ` James Carter
2021-06-08 15:59 ` [PATCH 19/23] libsepol/cil: avoid using maybe uninitialized variables Christian Göttsche
2021-06-21 21:00 ` James Carter
2021-06-08 15:59 ` [PATCH 20/23] libsepol: drop repeated semicolons Christian Göttsche
2021-06-21 20:54 ` James Carter
2021-06-08 15:59 ` [PATCH 21/23] libsepol: drop unnecessary casts Christian Göttsche
2021-06-21 20:57 ` James Carter
2021-06-08 15:59 ` [PATCH 22/23] libsepol: declare file local variable static Christian Göttsche
2021-06-21 21:00 ` James Carter
2021-06-08 15:59 ` [PATCH 23/23] libsepol: declare read-only arrays const Christian Göttsche
2021-06-21 20:59 ` James Carter
2021-06-24 14:29 ` James Carter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP+JOzRk_uDaap97b22qxOba08K-0VVBCH7nQaKBXcVa+k=GfQ@mail.gmail.com' \
--to=jwcart2@gmail.com \
--cc=cgzones@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.