From: James Carter <jwcart2@gmail.com>
To: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: Ondrej Mosnacek <omosnace@redhat.com>,
SElinux list <selinux@vger.kernel.org>,
Stephen Smalley <sds@tycho.nsa.gov>,
James Carter <jwcart2@tycho.nsa.gov>
Subject: Re: [PATCH 3/3] libsepol: speed up policy optimization
Date: Thu, 19 Mar 2020 15:39:52 -0400 [thread overview]
Message-ID: <CAP+JOzSMxYurya=KPeDUh5SCF+KZzcTDgUs8pDyFHmnnxAROJg@mail.gmail.com> (raw)
In-Reply-To: <CAEjxPJ6BnBoBGi+Dv=MQkH0-+JPAQE3ewHGykERYw_yEJ92CJQ@mail.gmail.com>
On Tue, Mar 17, 2020 at 2:25 PM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Thu, Feb 27, 2020 at 11:03 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
> >
> > The iteration over the set ebitmap bits is not implemented very
> > efficiently in libsepol. It is slowing down the policy optimization
> > quite significantly, so convert the type_map from an array of ebitmaps
> > to an array of simple ordered vectors, which can be traveresed more
> > easily. The worse space efficiency of the vectors is less important than
> > the speed in this case.
> >
> > After this change the duration of semodule -BN decreased from 6.4s to
> > 5.5s on Fedora Rawhide x86_64 (and from 6.1s to 5.6s with the unconfined
> > module disabled).
> >
> > Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
>
> Sidebar: Wondering whether you would have gotten similar results by taking some
> of the ebitmap optimization done in the kernel into libsepol. Regardless,
>
> Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Applied.
Thanks,
Jim
next prev parent reply other threads:[~2020-03-19 19:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 16:02 [PATCH 0/3] libsepol: Speed up policy optimization Ondrej Mosnacek
2020-02-27 16:02 ` [PATCH 1/3] libsepol: skip unnecessary check in build_type_map() Ondrej Mosnacek
2020-03-17 18:19 ` Stephen Smalley
2020-03-19 19:39 ` James Carter
2020-02-27 16:02 ` [PATCH 2/3] libsepol: optimize inner loop " Ondrej Mosnacek
2020-03-02 15:24 ` James Carter
2020-03-02 16:31 ` James Carter
2020-03-17 18:22 ` Stephen Smalley
2020-03-19 19:39 ` James Carter
2020-02-27 16:02 ` [PATCH 3/3] libsepol: speed up policy optimization Ondrej Mosnacek
2020-03-17 18:24 ` Stephen Smalley
2020-03-19 19:39 ` James Carter [this message]
2020-02-28 18:08 ` [PATCH 0/3] libsepol: Speed " Stephen Smalley
2020-03-02 14:50 ` Stephen Smalley
2020-03-02 14:58 ` Stephen Smalley
2020-03-02 15:46 ` Ondrej Mosnacek
2020-03-02 18:45 ` Stephen Smalley
2020-03-02 20:24 ` Stephen Smalley
2020-03-02 21:08 ` Ondrej Mosnacek
2020-03-04 9:07 ` Ondrej Mosnacek
2020-03-04 14:26 ` Stephen Smalley
2020-03-04 15:33 ` James Carter
2020-03-05 13:45 ` Ondrej Mosnacek
2020-03-02 20:12 ` Stephen Smalley
2020-03-13 11:53 ` Ondrej Mosnacek
2020-03-13 19:07 ` Stephen Smalley
2020-03-13 19:57 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP+JOzSMxYurya=KPeDUh5SCF+KZzcTDgUs8pDyFHmnnxAROJg@mail.gmail.com' \
--to=jwcart2@gmail.com \
--cc=jwcart2@tycho.nsa.gov \
--cc=omosnace@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.