From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4908CC433F5 for ; Mon, 28 Mar 2022 20:51:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D1vFXCOwwbt27p5MxLHhb5tTBCYSOoMYhYgiy8VVS40=; b=TEU7ojzmDE0lsv fNKZ1M+mbl5RAFdbFyBK5nHLdO1iGu/MyLFulrBsQuGf9hnmAdsm2YU8DgBVaWu4+2hFfZ85lmKCM NMde7qedlR5YkGIHORWOklm8+oy/tzc5cVUvWTVQsFcUfTuPv3G9Ibca0xvuw9gRadiwGPDyc6GW4 yEGvOeBi6VvxnCDeVD2UURqk9DWWGDmKQz5BLxi8nbeSaLZpj8kVciURQaUP1Br8uhuQfq9Rf34DI DjV9iqGwF70ViJcD6t6mJ+raSgWXrG/pb/wzuvGhQj+kwDdV93kZ1gRaySpzWXQbai1MCS5P5KsM3 +PO6zStBCgpNA+V81VUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYwJy-00A9tz-Qs; Mon, 28 Mar 2022 20:50:39 +0000 Received: from mail-ua1-x931.google.com ([2607:f8b0:4864:20::931]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nYwJu-00A9sV-D8 for linux-arm-kernel@lists.infradead.org; Mon, 28 Mar 2022 20:50:35 +0000 Received: by mail-ua1-x931.google.com with SMTP id t40so6816168uad.2 for ; Mon, 28 Mar 2022 13:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZW+N1z8CEv3LE1wD1qgx9rdQlxwgYO+dOMzOsexKCX0=; b=EZ4Pn1hyGJfqkjtJMJ5UzhBpoI2gcU/TfKZi1ib8vKfGTY6MjwmFDxB1vzUajMDh6r TUBWBheCGn0f953AUiliYyBkukL317XB7i0HxGCaXfHXW3FVatPgyA7FJ40NV6qQdcp+ faVNa1Jrr4qqUs5Qi0iaqmtnaUVY84FzVvfk1d+DXnTm0Y30yvhZTJ0oViRoDkrJZZs+ VuI0NwN55nl+a2fNtokkTecoZHXLSYLwoawshrcSRxsVd65zReJmVmEkg3ZuyGBaBpcU qGUzMf35+zwL3Z0AGLehyaFskCPlj8m2JZIBoZvRfXKM2ADgDaFTI/Ef8hS6tVGQUY6E SzDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZW+N1z8CEv3LE1wD1qgx9rdQlxwgYO+dOMzOsexKCX0=; b=mSquHOXh0A1B9t+d/ODY+WEPgo3zeoMLeIrKxjrBaq5ISCgLQJsBGV9qPi6ebWUDl5 NJ36Jy8Gqoa4ro3DPupVIam3Sev3p3skQS4PrzpsTuv0VfsPnijSPh2qj2cradOMzBio En98Jup6z0rDTgEljQtiLwqmvsNpG+LG+Yw2FSpcEYIbqvfaU+/ta1aIoTFwlzfe72QO lR8fpENXuJtuuob5pAT6s7JYyEnLaTMUSvZu69Ln5UAh1saqxdeSpO6oxu8V8zl2mSi8 HmdHo/ndBYteSA8WR2IqR49G99V3uSODeGutnI6DXkQFKa3+BnkmRhCLWseLJxByCLtQ V9tg== X-Gm-Message-State: AOAM532zXpvnBGE3FLAnHps8YmuFVweanu5fymqY7ZjSQkVtpezVQGMt 9kNiAF67NumEqrWEVbl8X18CbDlHA0qhkOcKCq5KCQ== X-Google-Smtp-Source: ABdhPJxMT9lEACJwR6BGk5c3GR+mHlu2ceSmYd943xCDVaeRhZbnPX80uw9WgTMMk3TRehrA/j1015qLMdmvbyuQwtY= X-Received: by 2002:a9f:2048:0:b0:352:9b4f:ac98 with SMTP id 66-20020a9f2048000000b003529b4fac98mr12932950uam.12.1648500632715; Mon, 28 Mar 2022 13:50:32 -0700 (PDT) MIME-Version: 1.0 References: <20220328062414.1893550-1-irogers@google.com> <20220328062414.1893550-3-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Mon, 28 Mar 2022 13:50:21 -0700 Message-ID: Subject: Re: [PATCH 2/5] perf cpumap: More cpu map reuse by merge. To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220328_135034_470895_40570587 X-CRM114-Status: GOOD ( 33.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMjgsIDIwMjIgYXQgMToyNiBQTSBBcm5hbGRvIENhcnZhbGhvIGRlIE1lbG8K PGFjbWVAa2VybmVsLm9yZz4gd3JvdGU6Cj4KPiBFbSBTdW4sIE1hciAyNywgMjAyMiBhdCAxMToy NDoxMVBNIC0wNzAwLCBJYW4gUm9nZXJzIGVzY3JldmV1Ogo+ID4gcGVyZl9jcHVfbWFwX19tZXJn ZSB3aWxsIHJldXNlIG9uZSBvZiBpdHMgYXJndW1lbnRzIGlmIHRoZXkgYXJlIGVxdWFsIG9yCj4g PiB0aGUgb3RoZXIgYXJndW1lbnQgaXMgTlVMTC4gVGhlIGFyZ3VtZW50cyBjb3VsZCBiZSByZXVz ZWQgaWYgaXQgaXMga25vd24KPiA+IG9uZSBzZXQgb2YgdmFsdWVzIGlzIGEgc3Vic2V0IG9mIHRo ZSBvdGhlci4gRm9yIGV4YW1wbGUsIGEgbWFwIG9mIDAtMQo+ID4gYW5kIGEgbWFwIG9mIGp1c3Qg MCB3aGVuIG1lcmdlZCB5aWVsZHMgdGhlIG1hcCBvZiAwLTEuIEN1cnJlbnRseSBhIG5ldwo+ID4g bWFwIGlzIGNyZWF0ZWQgcmF0aGVyIHRoYW4gYWRkaW5nIGEgcmVmZXJlbmNlIGNvdW50IHRvIHRo ZSBvcmlnaW5hbCAwLTEKPiA+IG1hcC4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBJYW4gUm9nZXJz IDxpcm9nZXJzQGdvb2dsZS5jb20+Cj4gPiAtLS0KPiA+ICB0b29scy9saWIvcGVyZi9jcHVtYXAu YyB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYg LS1naXQgYS90b29scy9saWIvcGVyZi9jcHVtYXAuYyBiL3Rvb2xzL2xpYi9wZXJmL2NwdW1hcC5j Cj4gPiBpbmRleCBlZTY2NzYwZjFlNjMuLjk1M2JjNTBiMGU0MSAxMDA2NDQKPiA+IC0tLSBhL3Rv b2xzL2xpYi9wZXJmL2NwdW1hcC5jCj4gPiArKysgYi90b29scy9saWIvcGVyZi9jcHVtYXAuYwo+ ID4gQEAgLTMxOSw2ICszMTksMjkgQEAgc3RydWN0IHBlcmZfY3B1IHBlcmZfY3B1X21hcF9fbWF4 KHN0cnVjdCBwZXJmX2NwdV9tYXAgKm1hcCkKPiA+ICAgICAgIHJldHVybiBtYXAtPm5yID4gMCA/ IG1hcC0+bWFwW21hcC0+bnIgLSAxXSA6IHJlc3VsdDsKPiA+ICB9Cj4gPgo+ID4gKy8qKiBJcyAn YicgYSBzdWJzZXQgb2YgJ2EnLiAqLwo+ID4gK3N0YXRpYyBib29sIHBlcmZfY3B1X21hcF9faXNf c3Vic2V0KGNvbnN0IHN0cnVjdCBwZXJmX2NwdV9tYXAgKmEsCj4gPiArICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IHBlcmZfY3B1X21hcCAqYikKPiA+ICt7Cj4g PiArICAgICBpbnQgaSwgajsKPiA+ICsKPiA+ICsgICAgIGlmIChhID09IGIgfHwgIWIpCj4gPiAr ICAgICAgICAgICAgIHJldHVybiB0cnVlOwo+ID4gKyAgICAgaWYgKCFhIHx8IGItPm5yID4gYS0+ bnIpCj4gPiArICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPiA+ICsgICAgIGogPSAwOwo+ID4g KyAgICAgZm9yIChpID0gMDsgaSA8IGEtPm5yOyBpKyspIHsKPgo+IFNpbmNlIHRoZSBrZXJuZWwg YnVtcGVkIHRoZSBtaW5pbXVtIGdjYyB2ZXJzaW9uIHRvIG9uZSB0aGF0IHN1cHBvcnRzCj4gZGVj bGFyaW5nIGxvb3AgdmFyaWFibGVzIGxvY2FsbHkgYW5kIHRoYXQgcGVyZiBoYXMgYmVlbiB1c2lu ZyB0aGlzIHNpbmNlCj4gZm9yZXZlcjoKPgo+IOKsolthY21lQHRvb2xib3ggcGVyZl0kIGdyZXAg LXIgJyhpbnQgW1s6YWxwaGE6XV0gPSAwOycgdG9vbHMvcGVyZgo+IHRvb2xzL3BlcmYvdXRpbC9i bG9jay1pbmZvLmM6ICAgZm9yIChpbnQgaSA9IDA7IGkgPCBucl9ocHBzOyBpKyspCj4gdG9vbHMv cGVyZi91dGlsL2Jsb2NrLWluZm8uYzogICBmb3IgKGludCBpID0gMDsgaSA8IG5yX2hwcHM7IGkr Kykgewo+IHRvb2xzL3BlcmYvdXRpbC9ibG9jay1pbmZvLmM6ICAgZm9yIChpbnQgaSA9IDA7IGkg PCBucl9yZXBzOyBpKyspCj4gdG9vbHMvcGVyZi91dGlsL3N0cmVhbS5jOiAgICAgICBmb3IgKGlu dCBpID0gMDsgaSA8IG5yX2V2c2VsOyBpKyspCj4gdG9vbHMvcGVyZi91dGlsL3N0cmVhbS5jOiAg ICAgICBmb3IgKGludCBpID0gMDsgaSA8IG5yX2V2c2VsOyBpKyspIHsKPiB0b29scy9wZXJmL3V0 aWwvc3RyZWFtLmM6ICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgZWxzLT5ucl9ldnNlbDsgaSsr KSB7Cj4gdG9vbHMvcGVyZi91dGlsL3N0cmVhbS5jOiAgICAgICBmb3IgKGludCBpID0gMDsgaSA8 IGVzX3BhaXItPm5yX3N0cmVhbXM7IGkrKykgewo+IHRvb2xzL3BlcmYvdXRpbC9zdHJlYW0uYzog ICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBlc19iYXNlLT5ucl9zdHJlYW1zOyBpKyspIHsKPiB0 b29scy9wZXJmL3V0aWwvY3B1bWFwLmM6ICAgICAgICAgICAgICAgZm9yIChpbnQgaiA9IDA7IGog PCBjLT5ucjsgaisrKSB7Cj4gdG9vbHMvcGVyZi91dGlsL21lbS1ldmVudHMuYzogICBmb3IgKGlu dCBqID0gMDsgaiA8IFBFUkZfTUVNX0VWRU5UU19fTUFYOyBqKyspIHsKPiB0b29scy9wZXJmL3V0 aWwvaGVhZGVyLmM6ICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgZmYtPnBoLT5lbnYubnJfaHli cmlkX2NwY19ub2RlczsgaSsrKSB7Cj4gdG9vbHMvcGVyZi9idWlsdGluLWRpZmYuYzogICAgICBm b3IgKGludCBpID0gMDsgaSA8IG51bTsgaSsrKQo+IHRvb2xzL3BlcmYvYnVpbHRpbi1kaWZmLmM6 ICAgICAgICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IHBhaXItPmJsb2NrX2luZm8tPm51bTsg aSsrKSB7Cj4gdG9vbHMvcGVyZi9idWlsdGluLXN0YXQuYzogICAgICBmb3IgKGludCBpID0gMDsg aSA8IHBlcmZfY3B1X21hcF9fbnIoYS0+Y29yZS5jcHVzKTsgaSsrKSB7Cj4g4qyiW2FjbWVAdG9v bGJveCBwZXJmXSQKPgo+IEFuZCB0aGlzIGJ1aWxkcyBvbiBhbGwgbXkgdGVzdCBjb250YWluZXJz LCBwbGVhc2UgdXNlOgo+Cj4gICAgICAgICBmb3IgKGludCBpID0gMCwgaiA9IDA7IGkgPCBhLT5u cjsgaSsrKQo+Cj4gSW4gdGhpcyBjYXNlIHRvIG1ha2UgdGhlIHNvdXJjZSBjb2RlIG1vcmUgY29t cGFjdC4KCkFjay4gV2Ugc3RpbGwgbmVlZCB0byBkZWNsYXJlICdqJyBhbmQgaXQgaXMgYSBiaXQg d2VpcmQgdG8gZGVjbGFyZSBqCmJlZm9yZSBpLiBGd2l3LCBNYWtpbmcuY29uZmlnIGhhcyB0aGUg Q09SRV9DRkxBR1Mgc2V0IHRvIGdudTk5LCBidXQKZGVjbGFyaW5nIGluIHRoZSBsb29wIGlzIGNs ZWFybHkgdmFsaWQgaW4gYzk5LgoKPiA+ICsgICAgICAgICAgICAgaWYgKGEtPm1hcFtpXS5jcHUg PiBiLT5tYXBbal0uY3B1KQo+ID4gKyAgICAgICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK PiA+ICsgICAgICAgICAgICAgaWYgKGEtPm1hcFtpXS5jcHUgPT0gYi0+bWFwW2pdLmNwdSkgewo+ ID4gKyAgICAgICAgICAgICAgICAgICAgIGorKzsKPiA+ICsgICAgICAgICAgICAgICAgICAgICBp ZiAoaiA9PSBiLT5ucikKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0 cnVlOwo+Cj4gT2ssIGFzIGl0cyBndWFyYW50ZWVkIHRoYXQgY3B1X21hcHMgYXJlIG9yZGVyZWQu Cj4KPiA+ICsgICAgICAgICAgICAgfQo+ID4gKyAgICAgfQo+ID4gKyAgICAgcmV0dXJuIGZhbHNl Owo+ID4gK30KPiA+ICsKPiA+ICAvKgo+ID4gICAqIE1lcmdlIHR3byBjcHVtYXBzCj4gPiAgICoK PiA+IEBAIC0zMzUsMTcgKzM1OCwxMiBAQCBzdHJ1Y3QgcGVyZl9jcHVfbWFwICpwZXJmX2NwdV9t YXBfX21lcmdlKHN0cnVjdCBwZXJmX2NwdV9tYXAgKm9yaWcsCj4gPiAgICAgICBpbnQgaSwgaiwg azsKPiA+ICAgICAgIHN0cnVjdCBwZXJmX2NwdV9tYXAgKm1lcmdlZDsKPiA+Cj4gPiAtICAgICBp ZiAoIW9yaWcgJiYgIW90aGVyKQo+ID4gLSAgICAgICAgICAgICByZXR1cm4gTlVMTDsKPiA+IC0g ICAgIGlmICghb3JpZykgewo+ID4gLSAgICAgICAgICAgICBwZXJmX2NwdV9tYXBfX2dldChvdGhl cik7Cj4gPiAtICAgICAgICAgICAgIHJldHVybiBvdGhlcjsKPiA+IC0gICAgIH0KPiA+IC0gICAg IGlmICghb3RoZXIpCj4gPiAtICAgICAgICAgICAgIHJldHVybiBvcmlnOwo+ID4gLSAgICAgaWYg KG9yaWctPm5yID09IG90aGVyLT5uciAmJgo+ID4gLSAgICAgICAgICFtZW1jbXAob3JpZy0+bWFw LCBvdGhlci0+bWFwLCBvcmlnLT5uciAqIHNpemVvZihzdHJ1Y3QgcGVyZl9jcHUpKSkKPiA+ICsg ICAgIGlmIChwZXJmX2NwdV9tYXBfX2lzX3N1YnNldChvcmlnLCBvdGhlcikpCj4gPiAgICAgICAg ICAgICAgIHJldHVybiBvcmlnOwo+Cj4gQ2FuJ3Qgd2UgaGF2ZSBmaXJzdCB0aGUgaW50cm9kdWN0 aW9uIG9mIHBlcmZfY3B1X21hcF9faXNfc3Vic2V0KCkgYW5kCj4gdGhlbiBhbm90aGVyIHBhdGNo IHRoYXQgZ2V0cyB0aGUgcmVmY291bnQsIGkuZS4gdGhlIGZvdXIgbGluZXMgYmVsb3c/CgpJIGJl bGlldmUgdGhhdCB3aWxsIGZhaWwgYXMgaXQnZCBiZSBhbiB1bnVzZWQgc3RhdGljIGZ1bmN0aW9u IHdhcm5pbmcKYW5kIHdlcnJvci4KClRoYW5rcywKSWFuCgo+ID4gKyAgICAgaWYgKHBlcmZfY3B1 X21hcF9faXNfc3Vic2V0KG90aGVyLCBvcmlnKSkgewo+ID4gKyAgICAgICAgICAgICBwZXJmX2Nw dV9tYXBfX3B1dChvcmlnKTsKPiA+ICsgICAgICAgICAgICAgcmV0dXJuIHBlcmZfY3B1X21hcF9f Z2V0KG90aGVyKTsKPiA+ICsgICAgIH0KPiA+Cj4gPiAgICAgICB0bXBfbGVuID0gb3JpZy0+bnIg KyBvdGhlci0+bnI7Cj4gPiAgICAgICB0bXBfY3B1cyA9IG1hbGxvYyh0bXBfbGVuICogc2l6ZW9m KHN0cnVjdCBwZXJmX2NwdSkpOwo+ID4gLS0KPiA+IDIuMzUuMS4xMDIxLmczODExMDFiMDc1LWdv b2cKPgo+IC0tCj4KPiAtIEFybmFsZG8KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FC1C43217 for ; Mon, 28 Mar 2022 20:52:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242064AbiC1Uxx (ORCPT ); Mon, 28 Mar 2022 16:53:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345802AbiC1Uws (ORCPT ); Mon, 28 Mar 2022 16:52:48 -0400 Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8C7E1EC4C for ; Mon, 28 Mar 2022 13:50:33 -0700 (PDT) Received: by mail-ua1-x933.google.com with SMTP id b5so6811662uas.8 for ; Mon, 28 Mar 2022 13:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ZW+N1z8CEv3LE1wD1qgx9rdQlxwgYO+dOMzOsexKCX0=; b=EZ4Pn1hyGJfqkjtJMJ5UzhBpoI2gcU/TfKZi1ib8vKfGTY6MjwmFDxB1vzUajMDh6r TUBWBheCGn0f953AUiliYyBkukL317XB7i0HxGCaXfHXW3FVatPgyA7FJ40NV6qQdcp+ faVNa1Jrr4qqUs5Qi0iaqmtnaUVY84FzVvfk1d+DXnTm0Y30yvhZTJ0oViRoDkrJZZs+ VuI0NwN55nl+a2fNtokkTecoZHXLSYLwoawshrcSRxsVd65zReJmVmEkg3ZuyGBaBpcU qGUzMf35+zwL3Z0AGLehyaFskCPlj8m2JZIBoZvRfXKM2ADgDaFTI/Ef8hS6tVGQUY6E SzDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ZW+N1z8CEv3LE1wD1qgx9rdQlxwgYO+dOMzOsexKCX0=; b=rCZYktf17aJ45ARoL4kxVJd2Fi/Gs84DC1rR3ykhF7KAWhUg5iBbHXEogHztmvN4fj MZC+N6emA85L+yE1gHqFv0x+WNKud8jTHzAxkc/4Cuo/twgfcj7VSn2PWv7GZCyrWK5r eAk964woZvfX87Usw0XG1O+2RcPkd6y1z+4SI9wMR+Uxqh58KMSRyi+FoqFq32gvVMiq rhz9RnVWaUyzrJcDgw0wI1vlXTCFsqnRcMT6i1vg2+fzIb049qd3EBe7vB/oaBtaKzCJ v1Jm7FVW+53cLfW5kn5rI5kWav19x5+6PJ4aezq0rXaVFVgHN8DJECq0FlwH5e9fItpi 9m6g== X-Gm-Message-State: AOAM531sWnVyfCS3i1t+ULt1DuCXYyx/590f3ekb4cJA66WYQ0hiYL/P 1iPKispubYriDCkcHSHz5if17g9w9xhjD+Hb8ayvUA== X-Google-Smtp-Source: ABdhPJxMT9lEACJwR6BGk5c3GR+mHlu2ceSmYd943xCDVaeRhZbnPX80uw9WgTMMk3TRehrA/j1015qLMdmvbyuQwtY= X-Received: by 2002:a9f:2048:0:b0:352:9b4f:ac98 with SMTP id 66-20020a9f2048000000b003529b4fac98mr12932950uam.12.1648500632715; Mon, 28 Mar 2022 13:50:32 -0700 (PDT) MIME-Version: 1.0 References: <20220328062414.1893550-1-irogers@google.com> <20220328062414.1893550-3-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Mon, 28 Mar 2022 13:50:21 -0700 Message-ID: Subject: Re: [PATCH 2/5] perf cpumap: More cpu map reuse by merge. To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , John Garry , Will Deacon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Kajol Jain , James Clark , German Gomez , Adrian Hunter , Riccardo Mancini , Andi Kleen , Alexey Bayduraev , Alexander Antonov , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Stephane Eranian Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2022 at 1:26 PM Arnaldo Carvalho de Melo wrote: > > Em Sun, Mar 27, 2022 at 11:24:11PM -0700, Ian Rogers escreveu: > > perf_cpu_map__merge will reuse one of its arguments if they are equal o= r > > the other argument is NULL. The arguments could be reused if it is know= n > > one set of values is a subset of the other. For example, a map of 0-1 > > and a map of just 0 when merged yields the map of 0-1. Currently a new > > map is created rather than adding a reference count to the original 0-1 > > map. > > > > Signed-off-by: Ian Rogers > > --- > > tools/lib/perf/cpumap.c | 38 ++++++++++++++++++++++++++++---------- > > 1 file changed, 28 insertions(+), 10 deletions(-) > > > > diff --git a/tools/lib/perf/cpumap.c b/tools/lib/perf/cpumap.c > > index ee66760f1e63..953bc50b0e41 100644 > > --- a/tools/lib/perf/cpumap.c > > +++ b/tools/lib/perf/cpumap.c > > @@ -319,6 +319,29 @@ struct perf_cpu perf_cpu_map__max(struct perf_cpu_= map *map) > > return map->nr > 0 ? map->map[map->nr - 1] : result; > > } > > > > +/** Is 'b' a subset of 'a'. */ > > +static bool perf_cpu_map__is_subset(const struct perf_cpu_map *a, > > + const struct perf_cpu_map *b) > > +{ > > + int i, j; > > + > > + if (a =3D=3D b || !b) > > + return true; > > + if (!a || b->nr > a->nr) > > + return false; > > + j =3D 0; > > + for (i =3D 0; i < a->nr; i++) { > > Since the kernel bumped the minimum gcc version to one that supports > declaring loop variables locally and that perf has been using this since > forever: > > =E2=AC=A2[acme@toolbox perf]$ grep -r '(int [[:alpha:]] =3D 0;' tools/per= f > tools/perf/util/block-info.c: for (int i =3D 0; i < nr_hpps; i++) > tools/perf/util/block-info.c: for (int i =3D 0; i < nr_hpps; i++) { > tools/perf/util/block-info.c: for (int i =3D 0; i < nr_reps; i++) > tools/perf/util/stream.c: for (int i =3D 0; i < nr_evsel; i++) > tools/perf/util/stream.c: for (int i =3D 0; i < nr_evsel; i++) { > tools/perf/util/stream.c: for (int i =3D 0; i < els->nr_evsel; i++)= { > tools/perf/util/stream.c: for (int i =3D 0; i < es_pair->nr_streams= ; i++) { > tools/perf/util/stream.c: for (int i =3D 0; i < es_base->nr_streams= ; i++) { > tools/perf/util/cpumap.c: for (int j =3D 0; j < c->nr; j++)= { > tools/perf/util/mem-events.c: for (int j =3D 0; j < PERF_MEM_EVENTS__MA= X; j++) { > tools/perf/util/header.c: for (int i =3D 0; i < ff->ph->env.nr_hybr= id_cpc_nodes; i++) { > tools/perf/builtin-diff.c: for (int i =3D 0; i < num; i++) > tools/perf/builtin-diff.c: for (int i =3D 0; i < pair->block= _info->num; i++) { > tools/perf/builtin-stat.c: for (int i =3D 0; i < perf_cpu_map__nr(a-= >core.cpus); i++) { > =E2=AC=A2[acme@toolbox perf]$ > > And this builds on all my test containers, please use: > > for (int i =3D 0, j =3D 0; i < a->nr; i++) > > In this case to make the source code more compact. Ack. We still need to declare 'j' and it is a bit weird to declare j before i. Fwiw, Making.config has the CORE_CFLAGS set to gnu99, but declaring in the loop is clearly valid in c99. > > + if (a->map[i].cpu > b->map[j].cpu) > > + return false; > > + if (a->map[i].cpu =3D=3D b->map[j].cpu) { > > + j++; > > + if (j =3D=3D b->nr) > > + return true; > > Ok, as its guaranteed that cpu_maps are ordered. > > > + } > > + } > > + return false; > > +} > > + > > /* > > * Merge two cpumaps > > * > > @@ -335,17 +358,12 @@ struct perf_cpu_map *perf_cpu_map__merge(struct p= erf_cpu_map *orig, > > int i, j, k; > > struct perf_cpu_map *merged; > > > > - if (!orig && !other) > > - return NULL; > > - if (!orig) { > > - perf_cpu_map__get(other); > > - return other; > > - } > > - if (!other) > > - return orig; > > - if (orig->nr =3D=3D other->nr && > > - !memcmp(orig->map, other->map, orig->nr * sizeof(struct perf_= cpu))) > > + if (perf_cpu_map__is_subset(orig, other)) > > return orig; > > Can't we have first the introduction of perf_cpu_map__is_subset() and > then another patch that gets the refcount, i.e. the four lines below? I believe that will fail as it'd be an unused static function warning and werror. Thanks, Ian > > + if (perf_cpu_map__is_subset(other, orig)) { > > + perf_cpu_map__put(orig); > > + return perf_cpu_map__get(other); > > + } > > > > tmp_len =3D orig->nr + other->nr; > > tmp_cpus =3D malloc(tmp_len * sizeof(struct perf_cpu)); > > -- > > 2.35.1.1021.g381101b075-goog > > -- > > - Arnaldo