From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67721C25B07 for ; Wed, 10 Aug 2022 14:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232409AbiHJOY3 (ORCPT ); Wed, 10 Aug 2022 10:24:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232637AbiHJOYL (ORCPT ); Wed, 10 Aug 2022 10:24:11 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 342D012ABA for ; Wed, 10 Aug 2022 07:24:08 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id a11so7880184wmq.3 for ; Wed, 10 Aug 2022 07:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=s02MYhFisswhR/oml/6C35b5IOfg5F1QOhp/QJOQoMA=; b=IPggfYhsg7S72d0+crr42oLh2z/EQ2LSKKJdOZMorRJ4If/4qz9Xlow7pIX+YKWZpI +Dzvpz8Lclupl/+LT6cEYFVLW1a48uHLYgCcMMM4ysO5rBGmX1dXj//mAu8J62sHv7ze 7GIaLTyRhF6DknmROuZh7UKX+qf0a3Ox/uQQYrn4oInhIEIWm7hff7Qtsz+AmU+czJr5 H9HWc9HX+b8UV7tUbGnOS8tVgeTziVL1p6HtlxmEd0cj1+0wXpWUy45SdaSgJV3qNn6+ 7MEh5BCog1kIiBu7EQRS6ZpI2G9b7TxLxScvUzULo9qSuU6Yelf9dTTwCuVScRJKgrUw uvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=s02MYhFisswhR/oml/6C35b5IOfg5F1QOhp/QJOQoMA=; b=UsQbyrSDMqJ5Vlwm5I7koaDYjWQnKtmIxWMKkkw0tTWLYYOYrOiBVMx9XEgis/Qlw+ kRIVypxIzxOPt11EVq9aPam9vuyjibJ8YzO0QAEJYF9A5FB+jrm0KAda7vmKedqbm50k Dmz5/2rTn0O68Tw0VZ2wL+lQSVOciuyq9AGnaEJoiShLCxX72cloQxHM1WOUJT2oD6qJ 4WhBOs92UxlETh8ERBoR5K6Aw6TMBGYzVdwyfJfDmY9EOLWt1oizvxAXrYcEFinI33mu W+VAlVg0NTqaHqYK7KcQFMaEYzKTIZHw+6wn5gnNERwZOQPobnQbFUDYWzVePChu2iHA 8QYg== X-Gm-Message-State: ACgBeo1eko8Nwtoq9FCqK1QlOlOwgBByX0PfbFNv5zvnQuDHCWMhIDDN UpqhTW9ZShHjIDSoWZbsRqPBETd2UOHIt0RgX9woFg== X-Google-Smtp-Source: AA6agR7dsoBEuPHZkASaOuZphZaQ28UgXVC0ir0+cOXaD/SFKR5yFMxzrNFRTi5qQwEi9XiCrxZNqPpNqPy2TsqQwCA= X-Received: by 2002:a05:600c:4e86:b0:3a3:417a:2fcd with SMTP id f6-20020a05600c4e8600b003a3417a2fcdmr2716098wmq.149.1660141446416; Wed, 10 Aug 2022 07:24:06 -0700 (PDT) MIME-Version: 1.0 References: <20220804221816.1802790-1-irogers@google.com> <20220804221816.1802790-8-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Wed, 10 Aug 2022 07:23:53 -0700 Message-ID: Subject: Re: [PATCH v4 07/17] perf jevents: Sort json files entries To: John Garry Cc: Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 5, 2022 at 3:49 AM John Garry wrote: > > On 04/08/2022 23:18, Ian Rogers wrote: > > Sort the json files entries on conversion to C. The sort order tries to > > replicated cmp_sevent from pmu.c so that the input there is already > > replicate Ack. > > sorted except for sysfs events. > > > > Add the topic to JsonEvent on reading to simplify. Remove an unnecessary > > lambda in the json reading. > > We sort the attributes of the events alphabetically by attribute name, > right? Is there any advantage in this? Do we need it for later? The sort order is given by the tuple: (not j.desc is None, fix_none(j.topic), fix_none(j.name), fix_none(j.pmu), fix_none(j.metric_name)) which is putting events with descriptions and topics before those without, then sorting by name, then pmu and finally metric_name. The advantage is that when we qsort alias events: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/util/pmu.c?h=perf/core#n1759 the events are already in the sorted format, which should make the code faster - it still has to qsort the sysfs events. Longer term I'd like to make the searching for an event, or metric, by name a binary rather than a linear search. Thanks, Ian > thanks, > John > > > > > Signed-off-by: Ian Rogers > > --- > > tools/perf/pmu-events/jevents.py | 48 +++++++++++++++++++++++--------- > > 1 file changed, 35 insertions(+), 13 deletions(-) > > > > diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py > > index 12d2daf3570c..30e0e792221a 100755 > > --- a/tools/perf/pmu-events/jevents.py > > +++ b/tools/perf/pmu-events/jevents.py > > @@ -18,6 +18,8 @@ _sys_event_tables = [] > > _arch_std_events = {} > > # Track whether an events table is currently being defined and needs closing. > > _close_table = False > > +# Events to write out when the table is closed > > +_pending_events = [] > > > > > > def removesuffix(s: str, suffix: str) -> str: > > @@ -127,6 +129,7 @@ class JsonEvent: > > eventcode |= int(jd['ExtSel']) << 8 > > configcode = int(jd['ConfigCode'], 0) if 'ConfigCode' in jd else None > > self.name = jd['EventName'].lower() if 'EventName' in jd else None > > + self.topic = '' > > self.compat = jd.get('Compat') > > self.desc = fixdesc(jd.get('BriefDescription')) > > self.long_desc = fixdesc(jd.get('PublicDescription')) > > @@ -199,7 +202,7 @@ class JsonEvent: > > s += f'\t{attr} = {value},\n' > > return s + '}' > > > > - def to_c_string(self, topic_local: str) -> str: > > + def to_c_string(self) -> str: > > """Representation of the event as a C struct initializer.""" > > > > def attr_string(attr: str, value: str) -> str: > > @@ -211,25 +214,27 @@ class JsonEvent: > > return attr_string(attr, getattr(self, attr)) > > > > s = '{\n' > > - s += f'\t.topic = "{topic_local}",\n' > > for attr in [ > > 'aggr_mode', 'compat', 'deprecated', 'desc', 'event', 'long_desc', > > 'metric_constraint', 'metric_expr', 'metric_group', 'metric_name', > > - 'name', 'perpkg', 'pmu', 'unit' > > + 'name', 'perpkg', 'pmu', 'topic', 'unit' > > ]: > > s += str_if_present(self, attr) > > s += '},\n' > > return s > > > > > > -def read_json_events(path: str) -> Sequence[JsonEvent]: > > +def read_json_events(path: str, topic: str) -> Sequence[JsonEvent]: > > """Read json events from the specified file.""" > > > > try: > > - return json.load(open(path), object_hook=lambda d: JsonEvent(d)) > > + result = json.load(open(path), object_hook=JsonEvent) > > except BaseException as err: > > print(f"Exception processing {path}") > > raise > > + for event in result: > > + event.topic = topic > > + return result > > > > > > def preprocess_arch_std_files(archpath: str) -> None: > > @@ -237,7 +242,7 @@ def preprocess_arch_std_files(archpath: str) -> None: > > global _arch_std_events > > for item in os.scandir(archpath): > > if item.is_file() and item.name.endswith('.json'): > > - for event in read_json_events(item.path): > > + for event in read_json_events(item.path, topic=''): > > if event.name: > > _arch_std_events[event.name.lower()] = event > > > > @@ -251,19 +256,36 @@ def print_events_table_prefix(tblname: str) -> None: > > _close_table = True > > > > > > -def print_events_table_entries(item: os.DirEntry, topic: str) -> None: > > - """Create contents of an events table.""" > > +def add_events_table_entries(item: os.DirEntry, topic: str) -> None: > > + """Add contents of file to _pending_events table.""" > > if not _close_table: > > raise IOError('Table entries missing prefix') > > - for event in read_json_events(item.path): > > - _args.output_file.write(event.to_c_string(topic)) > > + for e in read_json_events(item.path, topic): > > + _pending_events.append(e) > > > > > > def print_events_table_suffix() -> None: > > """Optionally close events table.""" > > + > > + def event_cmp_key(j: JsonEvent): > > + def fix_none(s: str): > > + if s is None: > > + return '' > > + return s > > + > > + return (not j.desc is None, fix_none(j.topic), fix_none(j.name), fix_none(j.pmu), > > + fix_none(j.metric_name)) > > + > > global _close_table > > - if _close_table: > > - _args.output_file.write("""{ > > + if not _close_table: > > + return > > + > > + global _pending_events > > + for event in sorted(_pending_events, key=event_cmp_key): > > + _args.output_file.write(event.to_c_string()) > > + _pending_events = [] > > + > > + _args.output_file.write("""{ > > \t.name = 0, > > \t.event = 0, > > \t.desc = 0, > > @@ -306,7 +328,7 @@ def process_one_file(parents: Sequence[str], item: os.DirEntry) -> None: > > if not item.is_file() or not item.name.endswith('.json'): > > return > > > > - print_events_table_entries(item, get_topic(item.name)) > > + add_events_table_entries(item, get_topic(item.name)) > > > > > > def print_mapping_table(archs: Sequence[str]) -> None: > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2F9CC00140 for ; Wed, 10 Aug 2022 14:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k7DmUtMSXD7yzMhfnqKux/2S+v1TqqHR5xQt9kq+8u8=; b=JMTxRB9JdQceRY O2ZtXNWWpPIGist3PPDQOzM200XELvGzcXs5FeEdvrzZjKqnskcAtn83NFuSulBh3p4HvFwBL3f7H /pfCEaN/XzHWqA/PvETXYnHtJGUXuKVNalXz47XM3DsXjA1nYPCB4Vf+NoiT69UfHXAr0WQ4rcNgv eHaRsfaPMGJEhxlj4Z5nJ7VOlXvVzdgz64BgfWnzaY8hA6vuJpECrwfww0hYTqEFIVehQB0KrCPDo U9uMkoIRmrt8/cCtpqaSF/b8IMi3RPbu1ba/nnDF2OID4cOdwmoeX1YCWX44Se89uNYH4bUGlQSlx d2Sw9VvSHiSzR8JJ50ZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLmd9-00CHNF-Bb; Wed, 10 Aug 2022 14:24:19 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oLmd0-00CHI5-B8 for linux-arm-kernel@lists.infradead.org; Wed, 10 Aug 2022 14:24:15 +0000 Received: by mail-wm1-x32f.google.com with SMTP id s23so705438wmj.4 for ; Wed, 10 Aug 2022 07:24:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=s02MYhFisswhR/oml/6C35b5IOfg5F1QOhp/QJOQoMA=; b=IPggfYhsg7S72d0+crr42oLh2z/EQ2LSKKJdOZMorRJ4If/4qz9Xlow7pIX+YKWZpI +Dzvpz8Lclupl/+LT6cEYFVLW1a48uHLYgCcMMM4ysO5rBGmX1dXj//mAu8J62sHv7ze 7GIaLTyRhF6DknmROuZh7UKX+qf0a3Ox/uQQYrn4oInhIEIWm7hff7Qtsz+AmU+czJr5 H9HWc9HX+b8UV7tUbGnOS8tVgeTziVL1p6HtlxmEd0cj1+0wXpWUy45SdaSgJV3qNn6+ 7MEh5BCog1kIiBu7EQRS6ZpI2G9b7TxLxScvUzULo9qSuU6Yelf9dTTwCuVScRJKgrUw uvGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=s02MYhFisswhR/oml/6C35b5IOfg5F1QOhp/QJOQoMA=; b=QUEkUP5472A09lV50I06puMw7uahb3I5Eiok/tZSRaKeVXh9e/reP/a6MSBhofpuUp tt2i7LTCBajYQL5cNzzDqsZnedkeE0UbEl72QgK7wDOFQm6x3CuQTdDmvOvAq0oyGH9k oTuQSWPs6Tihm4j0mgfMxEkEIphG75unG5ZFNKwGMWTv6J3zZr/qqyEf5ivEzzDPWRW4 Hb8u5VfkJ1UHp5SXp3aBohYrPcvy9tqBcdL8tupco+YDymqdqzL2+eM4y2NrU3yDFcdk ijxVWgz2zLdJvHkhxQLbyAWAidUxfXWNk6gjsCqFheGAOoRu0tdy1Pw4I8KVxxOP55g+ M+qA== X-Gm-Message-State: ACgBeo1wlp7EC/NgCZUpJwl8RvywUoP8M8RH9+o5Z1PRITXYOop3ga72 MAUxZmbwJDbe6gyyPkApG7maE1+ZKoEeulJUzKPIrQ== X-Google-Smtp-Source: AA6agR7dsoBEuPHZkASaOuZphZaQ28UgXVC0ir0+cOXaD/SFKR5yFMxzrNFRTi5qQwEi9XiCrxZNqPpNqPy2TsqQwCA= X-Received: by 2002:a05:600c:4e86:b0:3a3:417a:2fcd with SMTP id f6-20020a05600c4e8600b003a3417a2fcdmr2716098wmq.149.1660141446416; Wed, 10 Aug 2022 07:24:06 -0700 (PDT) MIME-Version: 1.0 References: <20220804221816.1802790-1-irogers@google.com> <20220804221816.1802790-8-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Wed, 10 Aug 2022 07:23:53 -0700 Message-ID: Subject: Re: [PATCH v4 07/17] perf jevents: Sort json files entries To: John Garry Cc: Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Andi Kleen , Zhengjun Xing , Ravi Bangoria , Kan Liang , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220810_072410_483498_6EB85CBC X-CRM114-Status: GOOD ( 31.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 5, 2022 at 3:49 AM John Garry wrote: > > On 04/08/2022 23:18, Ian Rogers wrote: > > Sort the json files entries on conversion to C. The sort order tries to > > replicated cmp_sevent from pmu.c so that the input there is already > > replicate Ack. > > sorted except for sysfs events. > > > > Add the topic to JsonEvent on reading to simplify. Remove an unnecessary > > lambda in the json reading. > > We sort the attributes of the events alphabetically by attribute name, > right? Is there any advantage in this? Do we need it for later? The sort order is given by the tuple: (not j.desc is None, fix_none(j.topic), fix_none(j.name), fix_none(j.pmu), fix_none(j.metric_name)) which is putting events with descriptions and topics before those without, then sorting by name, then pmu and finally metric_name. The advantage is that when we qsort alias events: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/tree/tools/perf/util/pmu.c?h=perf/core#n1759 the events are already in the sorted format, which should make the code faster - it still has to qsort the sysfs events. Longer term I'd like to make the searching for an event, or metric, by name a binary rather than a linear search. Thanks, Ian > thanks, > John > > > > > Signed-off-by: Ian Rogers > > --- > > tools/perf/pmu-events/jevents.py | 48 +++++++++++++++++++++++--------- > > 1 file changed, 35 insertions(+), 13 deletions(-) > > > > diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py > > index 12d2daf3570c..30e0e792221a 100755 > > --- a/tools/perf/pmu-events/jevents.py > > +++ b/tools/perf/pmu-events/jevents.py > > @@ -18,6 +18,8 @@ _sys_event_tables = [] > > _arch_std_events = {} > > # Track whether an events table is currently being defined and needs closing. > > _close_table = False > > +# Events to write out when the table is closed > > +_pending_events = [] > > > > > > def removesuffix(s: str, suffix: str) -> str: > > @@ -127,6 +129,7 @@ class JsonEvent: > > eventcode |= int(jd['ExtSel']) << 8 > > configcode = int(jd['ConfigCode'], 0) if 'ConfigCode' in jd else None > > self.name = jd['EventName'].lower() if 'EventName' in jd else None > > + self.topic = '' > > self.compat = jd.get('Compat') > > self.desc = fixdesc(jd.get('BriefDescription')) > > self.long_desc = fixdesc(jd.get('PublicDescription')) > > @@ -199,7 +202,7 @@ class JsonEvent: > > s += f'\t{attr} = {value},\n' > > return s + '}' > > > > - def to_c_string(self, topic_local: str) -> str: > > + def to_c_string(self) -> str: > > """Representation of the event as a C struct initializer.""" > > > > def attr_string(attr: str, value: str) -> str: > > @@ -211,25 +214,27 @@ class JsonEvent: > > return attr_string(attr, getattr(self, attr)) > > > > s = '{\n' > > - s += f'\t.topic = "{topic_local}",\n' > > for attr in [ > > 'aggr_mode', 'compat', 'deprecated', 'desc', 'event', 'long_desc', > > 'metric_constraint', 'metric_expr', 'metric_group', 'metric_name', > > - 'name', 'perpkg', 'pmu', 'unit' > > + 'name', 'perpkg', 'pmu', 'topic', 'unit' > > ]: > > s += str_if_present(self, attr) > > s += '},\n' > > return s > > > > > > -def read_json_events(path: str) -> Sequence[JsonEvent]: > > +def read_json_events(path: str, topic: str) -> Sequence[JsonEvent]: > > """Read json events from the specified file.""" > > > > try: > > - return json.load(open(path), object_hook=lambda d: JsonEvent(d)) > > + result = json.load(open(path), object_hook=JsonEvent) > > except BaseException as err: > > print(f"Exception processing {path}") > > raise > > + for event in result: > > + event.topic = topic > > + return result > > > > > > def preprocess_arch_std_files(archpath: str) -> None: > > @@ -237,7 +242,7 @@ def preprocess_arch_std_files(archpath: str) -> None: > > global _arch_std_events > > for item in os.scandir(archpath): > > if item.is_file() and item.name.endswith('.json'): > > - for event in read_json_events(item.path): > > + for event in read_json_events(item.path, topic=''): > > if event.name: > > _arch_std_events[event.name.lower()] = event > > > > @@ -251,19 +256,36 @@ def print_events_table_prefix(tblname: str) -> None: > > _close_table = True > > > > > > -def print_events_table_entries(item: os.DirEntry, topic: str) -> None: > > - """Create contents of an events table.""" > > +def add_events_table_entries(item: os.DirEntry, topic: str) -> None: > > + """Add contents of file to _pending_events table.""" > > if not _close_table: > > raise IOError('Table entries missing prefix') > > - for event in read_json_events(item.path): > > - _args.output_file.write(event.to_c_string(topic)) > > + for e in read_json_events(item.path, topic): > > + _pending_events.append(e) > > > > > > def print_events_table_suffix() -> None: > > """Optionally close events table.""" > > + > > + def event_cmp_key(j: JsonEvent): > > + def fix_none(s: str): > > + if s is None: > > + return '' > > + return s > > + > > + return (not j.desc is None, fix_none(j.topic), fix_none(j.name), fix_none(j.pmu), > > + fix_none(j.metric_name)) > > + > > global _close_table > > - if _close_table: > > - _args.output_file.write("""{ > > + if not _close_table: > > + return > > + > > + global _pending_events > > + for event in sorted(_pending_events, key=event_cmp_key): > > + _args.output_file.write(event.to_c_string()) > > + _pending_events = [] > > + > > + _args.output_file.write("""{ > > \t.name = 0, > > \t.event = 0, > > \t.desc = 0, > > @@ -306,7 +328,7 @@ def process_one_file(parents: Sequence[str], item: os.DirEntry) -> None: > > if not item.is_file() or not item.name.endswith('.json'): > > return > > > > - print_events_table_entries(item, get_topic(item.name)) > > + add_events_table_entries(item, get_topic(item.name)) > > > > > > def print_mapping_table(archs: Sequence[str]) -> None: > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel