From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 243BCC433EF for ; Tue, 14 Jun 2022 16:03:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343872AbiFNQDj (ORCPT ); Tue, 14 Jun 2022 12:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234800AbiFNQDg (ORCPT ); Tue, 14 Jun 2022 12:03:36 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F25A21266 for ; Tue, 14 Jun 2022 09:03:35 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id q15so11871815wrc.11 for ; Tue, 14 Jun 2022 09:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UyHUUWL8SAiICTePDBpRmmC0Gec5VSCStR4LNpntz4M=; b=kcKwhJeVfSqjNnxgmiRdpCMBTH28Y74pyVF8hQ3stw06h8WSSKHyYKGuBkmeeLqmJa nc6sK47AKgIHiTditZkZLlmHdMynilJaj7LNDHuVHcmn5RqujsbF4yAbLlXWvA6MVPJL n5CphE2FVWh0Mxb8GUEOOxULNf4nBMKDrFInPO/6Ju6sEDqRoOgWG1CqKYbjvjpuzfuH MN9uM1xdq/5IeT3fhSG9vthRhmQDi5jhd8hqnncUbWhkIPDpPOSsZLd9UiOeGLmCnMyN izjLBTksxIf6gMNszM3qMivZ7a/JJoApxjBVM61rXD6aqBlPfSnnUFOhnrJ8+Xyjw8BN RV/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UyHUUWL8SAiICTePDBpRmmC0Gec5VSCStR4LNpntz4M=; b=PiMU7ZG/5UraCUcoe+chlWIlf/br6kkUbuQ9zrCjjfAcduZUvfr5eyHC7dfqW3LTco JSdWImOXRqKDWGoV1x8ADVa4rfeX/Ctv69xWHvhywm0qx6HpFqx/vgAzrp10M94fEryK bkv4jKm5ZbcF7ZlVYFi9XO+Ta3fQeNl/JuluqaAdeAa0CuK3N6XFAB75w2hkGR6qrOPR q360AhVjqUQCvU+1nrkiKCEigeEgVcaoZ0EdfF1QY3d360/qVoLg9coaIUeMGQ1Pnufe 0UMdiAtnElcRFruSBNmAAvM53ipj2UkBZH00MesYfVPSG5I5d4YBBucnkYw8UqnruGdS nGqw== X-Gm-Message-State: AJIora/X7tAve5lgtghBDPSyX0bK6ezNi5i6AUDhUAQUkLIJL+KK0Qhx rq2P9A4URX+2IwSzTeKr7mi/77nOrnpW4xWLkEjkTQ== X-Google-Smtp-Source: AGRyM1vVWT53H5pRpO6t/jo0tMvu6+K3hl6TpDVdOfOkaGkzyynlczUAKAcwbZcd98mNqeYOCCraZs/RU2W2QbVM/wM= X-Received: by 2002:adf:e19e:0:b0:211:7169:dfa6 with SMTP id az30-20020adfe19e000000b002117169dfa6mr5620699wrb.654.1655222613580; Tue, 14 Jun 2022 09:03:33 -0700 (PDT) MIME-Version: 1.0 References: <20220527185426.240235-1-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Tue, 14 Jun 2022 09:03:19 -0700 Message-ID: Subject: Re: [PATCH v3 0/3] Rewrite jevents program in python To: John Garry Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Andi Kleen , Zhengjun Xing , Felix Fietkau , Qi Liu , Like Xu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Nick Forrington , Kajol Jain , James Clark , Andrew Kilroy , "Paul A . Clarke" , Will Deacon , Mathieu Poirier , ananth.narayan@amd.com, ravi.bangoria@amd.com, santosh.shukla@amd.com, sandipan.das@amd.com, Caleb Biggers , Perry Taylor , Kshipra Bopardikar , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 14, 2022 at 8:50 AM John Garry wrote: > > On 01/06/2022 23:43, Ian Rogers wrote: > > On Wed, Jun 1, 2022 at 9:17 AM John Garry wrote: > >> On 27/05/2022 19:54, Ian Rogers wrote: > >>> New architectures bring new complexity, such as Intel's hybrid > >>> models. jevents provides an alternative to specifying events in the > >>> kernel and exposing them through sysfs, however, it is difficult to > >>> work with. For example, an error in the json input would yield an > >>> error message but no json file or location. It is also a challenge to > >>> update jsmn.c given its forked nature. > >>> > >>> The changes here switch from jevents.c to a rewrite in python called > >>> jevents.py. This means there is a build time dependency on python, but > >>> such a dependency already exists for asciidoc (used to generate perf's > >>> man pages). If the build detects that python isn't present or is older > >>> than version 3.6 (released Dec. 2016) then an empty file is > >>> substituted for the generated one. > >>> > >>> A challenge with this code is in avoiding regressions. For this reason > >>> the jevents.py produces identical output to jevents.c, validated with a > >>> test script and build target. > >>> > >> Hi Ian, > >> > >> I still see this: > >> > >> ... > >> Makefile.config:906: Python interpreter too old (older than 3.6) > >> disabling jevent generation > >> Makefile.config:939: Old version of libbfd/binutils things like PE > >> executable profiling will not be available > >> Makefile.config:1127: No openjdk development package found, please > >> install JDK package, e.g. openjdk-8-jdk, java-1.8.0-openjdk-devel > >> > >> Auto-detecting system features: > >> ... dwarf: [ on ] > >> ... dwarf_getlocations: [ on ] > >> ... glibc: [ on ] > >> ... libbfd: [ OFF ] > >> ... libbfd-buildid: [ OFF ] > >> ... libcap: [ on ] > >> ... libelf: [ on ] > >> ... libnuma: [ on ] > >> ... numa_num_possible_cpus: [ on ] > >> ... libperl: [ on ] > >> ... libpython: [ on ] > >> ... libcrypto: [ on ] > >> ... libunwind: [ on ] > >> ... libdw-dwarf-unwind: [ on ] > >> ... zlib: [ on ] > >> ... lzma: [ on ] > >> ... get_cpuid: [ on ] > >> ... bpf: [ on ] > >> ... libaio: [ on ] > >> ... libzstd: [ on ] > >> ... disassembler-four-args: [ on ] > >> > >> > >> make[3]: Nothing to be done for 'install_headers'. > >> john@localhost:~/acme/tools/perf> python --version > >> Python 3.6.12 > >> > >> I need to figure out what is going wrong... > > Thanks for testing John! Could you try adding something like this: > > ``` > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config > > index 9538d737d655..c23f39e21a70 100644 > > --- a/tools/perf/Makefile.config > > +++ b/tools/perf/Makefile.config > > @@ -901,6 +901,8 @@ ifneq ($(NO_JEVENTS),1) > > NO_JEVENTS := 1 > > else > > # jevents.py uses f-strings present in Python 3.6 released in Dec. 2016. > > + PYTHON_VERSION=$(shell $(PYTHON) -c 'import sys;print(sys.version_info)') > > + $(error $(PYTHON_VERSION)) > > JEVENTS_PYTHON_GOOD := $(shell $(PYTHON) -c 'import sys;print("1" > > if(sys.version_info.major >= > > 3 and sys.version_info.minor >= 6) else "0")') > > ifneq ($(JEVENTS_PYTHON_GOOD), 1) > > $(warning Python interpreter too old (older than 3.6) disabling > > jevent generation) > > ``` > > That gives: > > Makefile.config:459: No libdw DWARF unwind found, Please install > elfutils-devel/libdw-dev >= 0.158 and/or set LIBDW_DIR > Makefile.config:464: No libdw.h found or old libdw.h found or elfutils > is older than 0.138, disables dwarf support. Please install new > elfutils-devel/libdw-dev > Makefile.config:617: DWARF support is off, BPF prologue is disabled > Makefile.config:667: No debug_frame support found in libunwind-aarch64 > Makefile.config:738: No debug_frame support found in libunwind > Makefile.config:906: *** sys.version_info(major=2, minor=7, micro=13, > releaselevel='final', serial=0).Stop. > Makefile.perf:239: recipe for target 'sub-make' failed > make[1]: *** [sub-make] Error 2 > Makefile:69: recipe for target 'all' failed > make: *** [all] Error 2 > john@debian:~/linux/tools/perf$ python --version > Python 3.6.9 > john@debian:~/linux/tools/perf$ > > > You can also specify which python you want on the make command line, > > for example adding PYTHON=`which python` at the end of your make > > command. > > diff -u tools/perf/trace/beauty/include/linux/socket.h > include/linux/socket.h > Makefile.config:259: *** which python-config not found. Stop. > Makefile.perf:239: recipe for target 'sub-make' failed > make[1]: *** [sub-make] Error 2 > Makefile:69: recipe for target 'all' failed > make: *** [all] Error 2 > john@debian:~/linux/tools/perf$ > > JFYI, this is my alternatives: > > sudo update-alternatives --config python > There are 3 choices for the alternative python (providing > /usr/bin/python). > > Selection Path Priority Status > ------------------------------------------------------------ > 0 /usr/local/bin/python3.6 50 auto mode > 1 /usr/bin/python2.7 1 manual mode > 2 /usr/bin/python3.5 2 manual mode > * 3 /usr/local/bin/python3.6 50 manual mode > > Press to keep the current choice[*], or type selection number: Thanks Gary, Perhaps it relates to dev packages. Perhaps, apt-get install python-dev-is-python3 which should resolve the symlinks. I wonder that you have python dev for python2 but python3 installed without the dev. We should be able to make a Makefile test for this. Thanks, Ian > > > Can someone else try this? Arnaldo? > > Sorry for being useless with this....