From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57100C4332F for ; Fri, 21 Oct 2022 00:02:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229824AbiJUACv (ORCPT ); Thu, 20 Oct 2022 20:02:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229799AbiJUACs (ORCPT ); Thu, 20 Oct 2022 20:02:48 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EB8A22D5F5 for ; Thu, 20 Oct 2022 17:02:46 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id a3so2280845wrt.0 for ; Thu, 20 Oct 2022 17:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=g0tXLeeeAU3F8Jn7158QLbBdSreE5CWF4BGqfvBib/E=; b=W8BszXRc3L9rOZMbFio2HR17eURTaVCmPO1K97+HvYdLlUJ+PB50lDJ5EcsqGpJ0wI 6NRovIuu1hIS0QbInAt8ulY3XPKBN8HwBv0Vgljw3SoWfh915TiDxh5sMSENWrAp/qvF vsH5aD9qtG1LCMM4TWScmDKFMzDLZ/rvrkh3QVNdYMRn39gqGAorBAqLIMSwQ7N4NHy/ QjPd4eB9N14ks6mLB5aJav/5LKioPKC2FqvY5e8larY/lU1diyhySw9lyQEpO4xVwCXd ILKzcOzXX7RlpaTbIlxvdaj6N+QsXYlzM573nn4WV0pqXR9MjRR/n5yn9v+Jwz5yT2+Y o+bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=g0tXLeeeAU3F8Jn7158QLbBdSreE5CWF4BGqfvBib/E=; b=W72Gdj3bRBDpmk6KZluwjxRrtNazYvJEkqY8BWwsdJ98nYYybSXG3hinZ5kOKjAi8L HlX9lv0h2SgaT0jJe5XVGhzmHIRoWbsec6dTA72ObBiIbhf40g7DfKM+8fNGl2YlREOH MlEWTxA81QqI74C0YB4ZXZ8OpsVIlBUVqtbYErFXsyE9JWKqAzweU4Vq9OyCuPD+PxdT 8rLxpWg1Jgl51jU3gS62xQOK7F7uIXKUNhKoO2FABdB444Dr4EMsCOk3MwKHVVf15jVe fKTry6yEGdtR96AclKDyG2eppPb6AF7YTaQkXHy1DDTe98UdwZ+vn170tBZKt5rMhmpi y4mA== X-Gm-Message-State: ACrzQf36PcCVgwhaNPRC6KAVMVHSkEVN0x0cRtlpz40rGGNXpYiU+vKy EtxidMfh9GF91Rsrvd0FiHLgVGOAQCiWQfqwsKBqSA== X-Google-Smtp-Source: AMsMyM7wiItTvNOVVnd6tmij9VOFr3KQYEZYNqcGGG/7i26+pUy2oXOVyp4qXX7Pe0Fw/r6B8zN/Du4+Q7FZkfi4qNI= X-Received: by 2002:adf:e711:0:b0:236:2f7f:4f08 with SMTP id c17-20020adfe711000000b002362f7f4f08mr3389855wrm.375.1666310565290; Thu, 20 Oct 2022 17:02:45 -0700 (PDT) MIME-Version: 1.0 References: <20221020172643.3458767-1-namhyung@kernel.org> <20221020172643.3458767-8-namhyung@kernel.org> In-Reply-To: <20221020172643.3458767-8-namhyung@kernel.org> From: Ian Rogers Date: Thu, 20 Oct 2022 17:02:33 -0700 Message-ID: Subject: Re: [PATCH 7/8] perf test: Test record with --threads option To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Adrian Hunter , linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 20, 2022 at 10:26 AM Namhyung Kim wrote: > > The --threads option changed the perf record behavior significantly, so > it'd be nice if we test it separately. Add --threads options with > different argument in each test supported and check the result. > > Also update the cleanup routine because threads recording produces data > in a directory. > > Signed-off-by: Namhyung Kim Acked-by: Ian Rogers Thanks, Ian > --- > tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh > index c59d1459c960..01aa9531b369 100755 > --- a/tools/perf/tests/shell/record.sh > +++ b/tools/perf/tests/shell/record.sh > @@ -13,8 +13,8 @@ testprog=$(mktemp /tmp/__perf_test.prog.XXXXXX) > testsym="test_loop" > > cleanup() { > - rm -f "${perfdata}" > - rm -f "${perfdata}".old > + rm -rf "${perfdata}" > + rm -rf "${perfdata}".old > > if [ "${testprog}" != "true" ]; then > rm -f "${testprog}" > @@ -171,6 +171,19 @@ test_system_wide() { > err=1 > return > fi > + if ! perf record -aB --synth=no -e cpu-clock,cs --threads=cpu \ > + -o "${perfdata}" ${testprog} 2> /dev/null > + then > + echo "System-wide record [Failed record --threads option]" > + err=1 > + return > + fi > + if ! perf report -i "${perfdata}" -q | grep -q "${testsym}" > + then > + echo "System-wide record [Failed --threads missing output]" > + err=1 > + return > + fi > echo "Basic --system-wide mode test [Success]" > } > > @@ -188,6 +201,19 @@ test_workload() { > err=1 > return > fi > + if ! perf record -e cpu-clock,cs --threads=package \ > + -o "${perfdata}" ${testprog} 2> /dev/null > + then > + echo "Workload record [Failed record --threads option]" > + err=1 > + return > + fi > + if ! perf report -i "${perfdata}" -q | grep -q "${testsym}" > + then > + echo "Workload record [Failed --threads missing output]" > + err=1 > + return > + fi > echo "Basic target workload test [Success]" > } > > -- > 2.38.0.135.g90850a2211-goog >