All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brandon Enochs <enochs.brandon@gmail.com>
To: b43-dev@lists.infradead.org
Subject: Radiotap Channel Bug
Date: Wed, 20 Aug 2014 09:09:10 -0400	[thread overview]
Message-ID: <CAP-AUyhM2gg-Etuy=hCi+18J88Teb7_jkD9yEOuFduGUyb0L_A@mail.gmail.com> (raw)
In-Reply-To: <CAP-AUygR-351cngtV5f5NUyitdAay3+az4=_zkWij61wh7iByw@mail.gmail.com>

Thanks,  I've submitted a bug report to the CentOS team to request a back port.

On Tue, Aug 19, 2014 at 7:36 PM, Brandon Enochs
<enochs.brandon@gmail.com> wrote:
> With CentOS 6.5, the LP phy type currently suffers from a calculation
> error in the way that it reports the channel on which a frame was
> received up through the mac80211 stack.  It should use the
> b43_channel_to_freq_2ghz function; however, it uses the
> b43_freq_to_channel_2ghz instead.  As a result, the radiotap header
> provides nonsensical values for the channel field.  The following
> patch fixes this issue
>
> Sincerely,
> Brandon Enochs
>
> diff -rupN ../linux-2.6.32-431.23.3.el6/drivers/net/wireless/b43/xmit.c
> drivers/net/wireless/b43/xmit.c
> --- ../linux-2.6.32-431.23.3.el6/drivers/net/wireless/b43/xmit.c
> 2014-07-16 05:33:22.000000000 -0400
> +++ drivers/net/wireless/b43/xmit.c 2014-08-19 19:19:20.607959455 -0400
> @@ -821,10 +821,10 @@ void b43_rx(struct b43_wldev *dev, struc
>    * channel number in b43. */
>   if (chanstat & B43_RX_CHAN_5GHZ) {
>   status.band = IEEE80211_BAND_5GHZ;
> - status.freq = b43_freq_to_channel_5ghz(chanid);
> + status.freq = b43_channel_to_freq_5ghz(chanid);
>   } else {
>   status.band = IEEE80211_BAND_2GHZ;
> - status.freq = b43_freq_to_channel_2ghz(chanid);
> + status.freq = b43_channel_to_freq_2ghz(chanid);
>   }
>   break;
>   default:

      parent reply	other threads:[~2014-08-20 13:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-19 23:36 Radiotap Channel Bug Brandon Enochs
2014-08-20  5:04 ` Rafał Miłecki
2014-08-20 13:02   ` Brandon Enochs
2014-08-20 13:09 ` Brandon Enochs [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAP-AUyhM2gg-Etuy=hCi+18J88Teb7_jkD9yEOuFduGUyb0L_A@mail.gmail.com' \
    --to=enochs.brandon@gmail.com \
    --cc=b43-dev@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.