From: Kyle Huey <me@kylehuey.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "Joerg Roedel" <joro@8bytes.org>,
"kvm list" <kvm@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] KVM: VMX: Handle RFLAGS.TF in skip_emulated_instruction
Date: Mon, 28 Nov 2016 08:13:15 -0800 [thread overview]
Message-ID: <CAP045ApB3p+xNOhs6qUcOBTWMybQ81nq=47r4eEmjuNs0E_WYw@mail.gmail.com> (raw)
In-Reply-To: <9eff6257-0420-102d-539a-d3b8b57ba05b@redhat.com>
On Mon, Nov 28, 2016 at 3:42 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 28/11/2016 05:18, Kyle Huey wrote:
>> +
>> + if (unlikely(vmx_get_rflags(vcpu) & X86_EFLAGS_TF)) {
>> + if (vcpu->guest_debug & KVM_GUESTDBG_SINGLESTEP) {
>> + vcpu->run->debug.arch.dr6 = DR6_BS | DR6_FIXED_1 |
>> + DR6_RTM;
>> + vcpu->run->debug.arch.pc = vcpu->arch.singlestep_rip;
>> + vcpu->run->debug.arch.exception = DB_VECTOR;
>> + vcpu->run->exit_reason = KVM_EXIT_DEBUG;
>> + return 0;
>> + }
>> +
>> + /*
>> + * "Certain debug exceptions may clear bit 0-3. The
>> + * remaining contents of the DR6 register are never
>> + * cleared by the processor".
>> + */
>> + vcpu->arch.dr6 &= ~15;
>> + vcpu->arch.dr6 |= DR6_BS | DR6_RTM;
>> + kvm_queue_exception(vcpu, DB_VECTOR);
>> + }
>
> This code is pretty much the same as kvm_vcpu_check_singlestep. Let's
> not duplicate the code and implement skip_emulated_instruction can be
> implemented in x86.c, like
>
> unsigned long rflags = kvm_x86_ops->get_rflags(vcpu);
> int r = EMULATE_DONE;
>
> /* This would be the no_trap variant */
> kvm_x86_ops->skip_emulated_instruction(vcpu);
> kvm_vcpu_check_singlestep(vcpu, rflags, &r);
> return r == EMULATE_DONE;
>
> (because x86.c/vmx.c/svm.c are separate modules, when moving the function
> to x86.c you should rename it to kvm_skip_emulated_instruction).
>
> Paolo
They're not exactly the same. For some reason I don't understand
kvm_vcpu_check_singlestep clears the trap flag. Perhaps that is also
a bug?
- Kyle
next prev parent reply other threads:[~2016-11-28 16:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 4:18 [PATCH 0/5] KVM: VMX: Fix single stepping with emulated instructions Kyle Huey
2016-11-28 4:18 ` [PATCH 1/5] KVM: x86: Add a return value to kvm_emulate_cpuid Kyle Huey
2016-11-28 4:18 ` [PATCH 2/5] KVM: VMX: Reorder some skip_emulated_instruction calls Kyle Huey
2016-11-28 4:18 ` [PATCH 3/5] KVM: VMX: Move skip_emulated_instruction out of nested_vmx_check_vmcs12 Kyle Huey
2016-11-28 4:18 ` [PATCH 4/5] KVM: x86: Add a return value to skip_emulated_instruction and propagate it Kyle Huey
2016-11-28 4:18 ` [PATCH 5/5] KVM: VMX: Handle RFLAGS.TF in skip_emulated_instruction Kyle Huey
2016-11-28 11:42 ` Paolo Bonzini
2016-11-28 16:13 ` Kyle Huey [this message]
2016-11-28 17:19 ` Paolo Bonzini
2016-11-28 18:34 ` Kyle Huey
2016-11-28 22:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAP045ApB3p+xNOhs6qUcOBTWMybQ81nq=47r4eEmjuNs0E_WYw@mail.gmail.com' \
--to=me@kylehuey.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.