From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Munegowda, Keshava" Subject: Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path Date: Wed, 28 Mar 2012 17:31:56 +0530 Message-ID: References: <1332857335-27911-1-git-send-email-grinberg@compulab.co.il> <20120328085231.GD18156@arwen.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from na3sys009aog116.obsmtp.com ([74.125.149.240]:45694 "EHLO na3sys009aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753478Ab2C1MB5 convert rfc822-to-8bit (ORCPT ); Wed, 28 Mar 2012 08:01:57 -0400 Received: by mail-ob0-f176.google.com with SMTP id ef5so1744402obb.35 for ; Wed, 28 Mar 2012 05:01:56 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Raja, Govindraj" Cc: balbi@ti.com, Igor Grinberg , Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org On Wed, Mar 28, 2012 at 4:23 PM, Raja, Govindraj wrote: > On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi wrote: >> On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: >>> When PHY reset pin is connected to a GPIO on external GPIO chip >>> (e.g. I2C), we should not call the gpio_set_value() function, but >>> gpio_set_value_cansleep(). >>> >>> Signed-off-by: Igor Grinberg >> >> Acked-by: Felipe Balbi >> >> Keshava, please give us your tested-by. Patch looks fine to me. > > Tried on beagle-xm where the smsc hub + smsc95xx ethernet controller > relies gpio nreset sequence for initialization. > > Both hub + Ethernet controller get enumerated even after this patch. > > Tested-by: Govindraj.R > >> Thanks govind. >>> --- >>> This patch depends on the patch from Keshava [1]: >>> ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue >>> >>> [1] http://www.spinics.net/lists/linux-omap/msg66774.html >>> >>> =A0drivers/usb/host/ehci-omap.c | =A0 =A04 ++-- >>> =A01 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-o= map.c >>> index 5c78f9e..26e9241 100644 >>> --- a/drivers/usb/host/ehci-omap.c >>> +++ b/drivers/usb/host/ehci-omap.c >>> @@ -258,10 +258,10 @@ static int ehci_hcd_omap_probe(struct platfor= m_device *pdev) >>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 udelay(10); >>> >>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (gpio_is_valid(pdata->reset_gpio_por= t[0])) >>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gpio_set_value(pdata->res= et_gpio_port[0], 1); >>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gpio_set_value_cansleep(p= data->reset_gpio_port[0], 1); >>> >>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (gpio_is_valid(pdata->reset_gpio_por= t[1])) >>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gpio_set_value(pdata->res= et_gpio_port[1], 1); >>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 gpio_set_value_cansleep(p= data->reset_gpio_port[1], 1); >>> =A0 =A0 =A0 } >>> >>> =A0 =A0 =A0 return 0; >>> -- >>> 1.7.3.4 >>> >> >> -- >> balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html