From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Munegowda, Keshava" Subject: Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue Date: Tue, 3 Jul 2012 12:17:28 +0530 Message-ID: References: <1340286132-20634-1-git-send-email-keshava_mgowda@ti.com> <87fw9o32v2.fsf@ti.com> <20120622103050.GG28472@arwen.pp.htv.fi> <87ehp71liv.fsf@ti.com> <20120622203645.GD29290@arwen.pp.htv.fi> <87d34nfdei.fsf@ti.com> <871uku85o8.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <871uku85o8.fsf-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kevin Hilman Cc: balbi-l0cyMroinI0@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Paul Walmsley List-Id: linux-omap@vger.kernel.org On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman wrote: > Felipe, Keshava, > > Kevin Hilman writes: > >> Felipe Balbi writes: >> >> [...] >> >>> Keshava is reverting a fix for a HW errata. I can't accept it as it will >>> cause regressions. Granted, regression by regression, there's no change, >>> but I simply can't knowingly cause a regression to the driver just to >>> have PM working. We need a real fix for this issue. >> >> Sure, as long as there is a fix in this -rc cycle. >> >> This driver intoduced changes in v3.5 that break PM for the whole SoC >> (by preventing CORE retention.) These changes were clearly not tested >> with PM. >> >> If you cannot fix this during the -rc cycle, then you need to revert the >> driver PM changes that broke PM for the *whole* SoC. > > What's the status of this regression? > > This is still broken in v3.5-rc and is preventing CORE retention for the > *whole* SoC. > > Please fix this, either with a proper fix, or a revert for 3.5-rc. The proper fix for this is implement ion of ehci remote wakeup through I/O chain handler; it takes time. As Felipe also mentioned, This patch is OK for now. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html