Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

["Munegowda, Keshava" <keshava_mgowda@ti.com>]

On Tue, Jul 3, 2012 at 5:44 AM, Kevin Hilman <khilman@ti.com> wrote:
> Kevin Hilman <khilman@ti.com> writes:
>
>> Felipe, Keshava,
>>
>> Kevin Hilman <khilman@ti.com> writes:
>>
>>> Felipe Balbi <balbi@ti.com> writes:
>>>
>>> [...]
>>>
>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>>> cause regressions. Granted, regression by regression, there's no change,
>>>> but I simply can't knowingly cause a regression to the driver just to
>>>> have PM working. We need a real fix for this issue.
>>>
>>> Sure, as long as there is a fix in this -rc cycle.
>>>
>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>>> (by preventing CORE retention.)  These changes were clearly not tested
>>> with PM.
>>>
>>> If you cannot fix this during the -rc cycle, then you need to revert the
>>> driver PM changes that broke PM for the *whole* SoC.
>>
>> What's the status of this regression?
>>
>> This is still broken in v3.5-rc and is preventing CORE retention for the
>> *whole* SoC.
>>
>> Please fix this, either with a proper fix, or a revert for 3.5-rc.
>>
>
> BTW, a related issue with this driver (but not sure it's a regression)
> is that USB ethernet does not seem to survive a suspend/resume.
>
> If I'm using a NFS rootfs, after suspend/resume, the NFS servers stops
> responding, and I get these errors:
>
>   nfs: server X.X.X.X not responding, still trying

This issue because of two issues:

1. The phy goes to bad state and ehci ports goes out the suspend
                    Fix was made by resetting the phy and re-power the
ehci ports; but Alan has commented on this.
                 it stil requires a reworks
2. The usb-serial driver does not have reset-resume, so it gets the
different ip address but NFS wont be functional
                     nothing can be done in the ehci driver,
debugging is requried at usb serial driver.

regards
keshava